Installing picard without having the dbus useflag set for PyQt5 causes a hard crash due to import failures. Can be fixed by enabling the dbus useflag on PyQt5 manually, however compiling that a second time is kind of bothersome considering there is a way to depend on certain useflags on other packages (IIRC). Reproducible: Always Steps to Reproduce: 1. PyQt5 without dbus useflag 2. install picard Actual Results: % picard --help Traceback (most recent call last): File "/usr/bin/picard", line 2, in <module> from picard.tagger import main File "/usr/lib/python3.7/site-packages/picard/tagger.py", line 61, in <module> from PyQt5.QtDBus import QDBusConnection ModuleNotFoundError: No module named 'PyQt5.QtDBus' Expected Results: picard starts up normally
Created attachment 657438 [details] emerge --info picard
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13e439d55a82931cfc7c777cdcef70a8f898944a commit 13e439d55a82931cfc7c777cdcef70a8f898944a Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-30 08:04:45 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-30 08:04:58 +0000 media-sound/picard: added dbus to dev-python/PyQt5 dep Closes: https://bugs.gentoo.org/739550 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/picard/picard-2.3.1.ebuild | 2 +- media-sound/picard/picard-2.4.2.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
The crash was fixed and the hard dependency on PyQt5[dbus] removed by https://github.com/metabrainz/picard/pull/1535 Should I open a new issue to ask to remove it again?
(In reply to Julius from comment #3) > The crash was fixed and the hard dependency on PyQt5[dbus] removed by > https://github.com/metabrainz/picard/pull/1535 > > Should I open a new issue to ask to remove it again? yes please. i tried the the patch but it does not apply so it would have to be backported to make it part of 2.4.2: >>> Preparing source in /var/tmp/portage/media-sound/picard-2.4.2-r1/work/picard-release-2.4.2 ... * Applying picard-2.4.2-dbus-optional.patch ... patching file picard/tagger.py Hunk #1 FAILED at 58. Hunk #2 FAILED at 972. 2 out of 2 hunks FAILED -- saving rejects to file picard/tagger.py.rej patching file picard/ui/statusindicator.py Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file picard/ui/statusindicator.py.rej
