Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 739466 - net-im/telegram-desktop{,-bin}-2.3.x: bump request
Summary: net-im/telegram-desktop{,-bin}-2.3.x: bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
: 751085 (view as bug list)
Depends on:
Blocks: CVE-2020-25824
  Show dependency tree
 
Reported: 2020-08-29 00:45 UTC by jorgicio
Modified: 2020-10-29 08:00 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jorgicio 2020-08-29 00:45:54 UTC
Hi!

I noted that past week, Telegram Desktop was updated. Also, for the source-based version, noted that there's an new dependency called libwebrtc, and it's needed for 2.3.x since it comes with video calls.

Also, the bin-based is not updated since some time ago (last version available in Portage Tree is 2.1.3).

Thanks in advance.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2020-08-29 01:25:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=78cb5b93e1c750df1e51e5624a73ed0bc2fb314e

commit 78cb5b93e1c750df1e51e5624a73ed0bc2fb314e
Author:     Henning Schild <henning@hennsch.de>
AuthorDate: 2020-08-18 21:36:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-08-29 01:24:57 +0000

    net-im/telegram-desktop-bin: bump version to 2.3.0
    
    This one drops "x86" because the binary is not available upstream
    anymore. Maybe it comes back, did not yet understand why it went away.
    
    Bug: https://bugs.gentoo.org/739466
    Signed-off-by: Henning Schild <henning@hennsch.de>
    Closes: https://github.com/gentoo/gentoo/pull/17166
    Signed-off-by: Sam James <sam@gentoo.org>

 net-im/telegram-desktop-bin/Manifest               |  2 +
 .../telegram-desktop-bin-2.3.0.ebuild              | 57 ++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 2 Georgy Yakovlev archtester gentoo-dev 2020-08-29 09:50:30 UTC
webrtc is a horrible nightmare to package as it bundles a lot of libraries and harcodes a lot of things. it needs a good whack to untangle everything.

telegram can't be built without webrtc yet.
https://github.com/telegramdesktop/tdesktop/issues/8483

bump will only happen if:
1) https://github.com/desktop-app/tg_owt is packaged (properly)
2) upstream will fix build without webrtc, so we can bump it and continue working on webrtc separately.

only new functionality is webrtc/video calls.
Comment 3 jorgicio 2020-08-29 15:29:59 UTC
(In reply to Larry the Git Cow from comment #1)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=78cb5b93e1c750df1e51e5624a73ed0bc2fb314e
> 
> commit 78cb5b93e1c750df1e51e5624a73ed0bc2fb314e
> Author:     Henning Schild <henning@hennsch.de>
> AuthorDate: 2020-08-18 21:36:12 +0000
> Commit:     Sam James <sam@gentoo.org>
> CommitDate: 2020-08-29 01:24:57 +0000
> 
>     net-im/telegram-desktop-bin: bump version to 2.3.0
>     
>     This one drops "x86" because the binary is not available upstream
>     anymore. Maybe it comes back, did not yet understand why it went away.
>     
>     Bug: https://bugs.gentoo.org/739466
>     Signed-off-by: Henning Schild <henning@hennsch.de>
>     Closes: https://github.com/gentoo/gentoo/pull/17166
>     Signed-off-by: Sam James <sam@gentoo.org>
> 
>  net-im/telegram-desktop-bin/Manifest               |  2 +
>  .../telegram-desktop-bin-2.3.0.ebuild              | 57
> ++++++++++++++++++++++
>  2 files changed, 59 insertions(+)

Thanks, but why 2.3.0 since the most recent version is 2.3.2?

Anyways, thanks!
Comment 4 jorgicio 2020-08-29 15:31:09 UTC
(In reply to Georgy Yakovlev from comment #2)
> webrtc is a horrible nightmare to package as it bundles a lot of libraries
> and harcodes a lot of things. it needs a good whack to untangle everything.
> 
> telegram can't be built without webrtc yet.
> https://github.com/telegramdesktop/tdesktop/issues/8483
> 
> bump will only happen if:
> 1) https://github.com/desktop-app/tg_owt is packaged (properly)
> 2) upstream will fix build without webrtc, so we can bump it and continue
> working on webrtc separately.
> 
> only new functionality is webrtc/video calls.

Yes, that's why I though.

Some days ago tried to package webrtc and it fails. I can't understand how did Arch Linux developers did it.
Comment 5 Georgy Yakovlev archtester gentoo-dev 2020-08-29 17:39:41 UTC
Arch packages allow network access...(and it’s bad)
So then they build webrtc without using system libs.it uses gclient (Google repo wrapper) to download all sources and statically bundle everything inside.
Comment 6 Михаил 2020-10-09 12:44:02 UTC
(In reply to Georgy Yakovlev from comment #2)
> only new functionality is webrtc/video calls.

Version 2.4
* Comment on posts in channels that have a discussion group.
Comment 7 Georgy Yakovlev archtester gentoo-dev 2020-10-26 02:13:48 UTC
*** Bug 751085 has been marked as a duplicate of this bug. ***
Comment 8 Georgy Yakovlev archtester gentoo-dev 2020-10-26 02:19:26 UTC
situation changed a bit since, there' s no more network access required, but everything is still pretty nasty.

tg_owt wants pulseaudio unconditionally, tgvoip needs tg_owt, and telegram needs both.

also it bundles vpx, openh264, nasm and other libs.
there's some slow work happening, and it's possible to build if one bundles tg_owt + tgvoip + telegram in single package, but it will require pulse (to build, not to run), bundle a lot of libs without using system copies.
Comment 9 Larry the Git Cow gentoo-dev 2020-10-26 08:03:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4364658df0ff6f92297648a32dbd28efac732e80

commit 4364658df0ff6f92297648a32dbd28efac732e80
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-10-26 08:00:00 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-10-26 08:01:28 +0000

    net-im/telegram-desktop: bump to 2.4.4
    
    webrtc is imposibble to turn off for now, unfortunately.
    webrtc alsa and pulseaudio will be forced on for now.
    add system-rlottie useflag.
    
    for now tg_owt bundles the following:
    openh264
    abseil-cpp
    libsrtp
    libvpx
    libyuv
    pffft
    rnnoise
    usrsctp
    
    Bug: https://bugs.gentoo.org/736774
    Bug: https://bugs.gentoo.org/749288
    Closes: https://bugs.gentoo.org/739466
    Closes: https://bugs.gentoo.org/707272
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-im/telegram-desktop/Manifest                   |   2 +
 net-im/telegram-desktop/metadata.xml               |   2 +
 .../telegram-desktop/telegram-desktop-2.4.4.ebuild | 184 +++++++++++++++++++++
 3 files changed, 188 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63f3dc6b4dc10343909a7bf431c0303585ba4dca

commit 63f3dc6b4dc10343909a7bf431c0303585ba4dca
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-10-26 08:00:30 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-10-26 08:03:09 +0000

    profiles/base/package.use.force: force some flags on telegram
    
    Bug: https://bugs.gentoo.org/739466
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 profiles/base/package.use.force | 5 +++++
 1 file changed, 5 insertions(+)
Comment 10 Georgy Yakovlev archtester gentoo-dev 2020-10-26 08:05:21 UTC
this is all I can do for now.
unbundling and removing webrtc and pulse requirement is a lot of work, send patches upstream.

there's some work started but stalled

https://github.com/desktop-app/tg_owt/pull/16
Comment 11 Georgy Yakovlev archtester gentoo-dev 2020-10-29 08:00:18 UTC
FYI, removed hard pulse requirement. should build/work with apulse.