Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 737794 - media-gfx/gimp should depend on media-gfx/mypaint-brushes:1.0 - configure: Eeeeeeeeeeeeeeeeeeeeek! Missing dep: mypaint-brushes-1.0
Summary: media-gfx/gimp should depend on media-gfx/mypaint-brushes:1.0 - configure: Ee...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
: 737992 (view as bug list)
Depends on:
Blocks: 735374
  Show dependency tree
 
Reported: 2020-08-18 08:44 UTC by Althorion
Modified: 2020-08-23 12:49 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info '=media-gfx/gimp-2.10.20::gentoo' (file_737794.txt,23.28 KB, text/plain)
2020-08-18 08:45 UTC, Althorion
Details
build.log (file_737794.txt,26.42 KB, text/plain)
2020-08-18 08:46 UTC, Althorion
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Althorion 2020-08-18 08:44:44 UTC
GIMP’s EBUILD state the dependency as >=media-gfx/mypaint-brushes-1.3.0, but that’s not enough: having media-gfx/mypaint-brushes-2.0.2 fails with “Error: missing dependency mypaint-brushes-1.0”.

Reproducible: Always

Steps to Reproduce:
1. Emerge =media-gfx/mypaint-brushes-2.0.2
2. Unmerge media-gfx/mypaint-brushes:2.0
3. Try to emerge media-gfx/gimp
Comment 1 Althorion 2020-08-18 08:45:22 UTC
Created attachment 655218 [details]
emerge --info '=media-gfx/gimp-2.10.20::gentoo'
Comment 2 Althorion 2020-08-18 08:46:16 UTC
Created attachment 655220 [details]
build.log
Comment 3 Althorion 2020-08-18 08:49:25 UTC
Second reproduce step should be, obviously, “Unmerge media-gfx/mypaint-brushes:1.0”, made a typo there.
Comment 4 Sergey Torokhov 2020-08-18 13:27:12 UTC
Thank you for report.

It's required to restrict dependency with mypaint-brushes:1.0 slot if gimp-2.10 isn't possible to be compatible with mypaint-brushes:2.0 slot.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-19 10:36:25 UTC
*** Bug 737992 has been marked as a duplicate of this bug. ***
Comment 6 Miroslav Šulc gentoo-dev 2020-08-20 09:32:21 UTC
gimp-9999 obviously needs mypaint-brushes from both slots, that is 1.0 and 2.0. i did not test with other versions of gimp though.
Comment 7 Miroslav Šulc gentoo-dev 2020-08-20 10:09:16 UTC
here are the relevant lines from the configuration phase:

# grep mypaint /var/tmp/portage/media-gfx/gimp-9999/temp/build.log 
checking for libmypaint >= 1.4.0... yes
checking for mypaint-brushes-1.0... yes

and these are the versions i have installed:

# equery list mypaint-brushes
 * Searching for mypaint-brushes ...
[IP-] [  ] media-gfx/mypaint-brushes-1.3.0-r1:1.0
[IP-] [  ] media-gfx/mypaint-brushes-2.0.2:2.0
Comment 8 Sergey Torokhov 2020-08-20 15:01:04 UTC
(In reply to Miroslav Šulc from comment #6)
> gimp-9999 obviously needs mypaint-brushes from both slots, that is 1.0 and
> 2.0. i did not test with other versions of gimp though.

I have to change gimp-9999 slot from :2 to :3 (or maybe :2.99) and set :2 restriction within gimp plugins as gimp-9999 already depends on gtk+-3 and python3. I.e. it's other branch  of gimp, not the same as gimp-2.10.x.
Comment 9 Miroslav Šulc gentoo-dev 2020-08-20 16:00:01 UTC
(In reply to Sergey Torokhov from comment #8)
> I have to change gimp-9999 slot from :2 to :3 (or maybe :2.99) and set :2
> restriction within gimp plugins as gimp-9999 already depends on gtk+-3 and
> python3. I.e. it's other branch  of gimp, not the same as gimp-2.10.x.

yes, that makes sense. looking at the about window it reports to be 2.99.1 so maybe slot 2.99 would be a better choice until they change the version.
Comment 10 Sergey Torokhov 2020-08-21 22:45:55 UTC
I currently test the gimp-2.10.20 ebuild with has_version "media-gfx/mypaint-brushes:2.0" condition with sed for configure.ac replacement of "mypaint-brushes-1.0" with "mypaint-brushes-2.0". As mentioned on https://github.com/mypaint/mypaint-brushes/releases for mypaint-brushes-2.0.0

> Mostly identical to 1.3 brushes with a few tweaks for some new inputs available in mypaint 2.x, such as viewzoom and viewrotation

So I assume it should work too with gimp
Comment 11 Larry the Git Cow gentoo-dev 2020-08-22 06:16:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0cf75f1ab2d3bcd808dee9d1b733fba4782baa3

commit a0cf75f1ab2d3bcd808dee9d1b733fba4782baa3
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2020-08-21 23:45:30 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-08-22 06:16:41 +0000

    media-gfx/gimp: fix build and run with media-gfx/mypaint-brushes:2.0
    
    Closes: https://bugs.gentoo.org/737794
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 media-gfx/gimp/gimp-2.10.18-r2.ebuild | 230 ++++++++++++++++++++++++++++++++++
 media-gfx/gimp/gimp-2.10.20-r1.ebuild | 228 +++++++++++++++++++++++++++++++++
 2 files changed, 458 insertions(+)
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-23 12:49:51 UTC
(In reply to Sergey Torokhov from comment #10)
> I currently test the gimp-2.10.20 ebuild with has_version
> "media-gfx/mypaint-brushes:2.0" condition with sed for configure.ac
> replacement of "mypaint-brushes-1.0" with "mypaint-brushes-2.0". As
> mentioned on https://github.com/mypaint/mypaint-brushes/releases for
> mypaint-brushes-2.0.0
> 
> > Mostly identical to 1.3 brushes with a few tweaks for some new inputs available in mypaint 2.x, such as viewzoom and viewrotation
> 
> So I assume it should work too with gimp

Thanks for fixing this, by the way. I was testing this myself after chatting with fordfrog, but a maintainer fix is even better. :)