Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 726994 - app-admin/doas-6.6.1: Add local USE flag for timestamp
Summary: app-admin/doas-6.6.1: Add local USE flag for timestamp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Felix Janda
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-03 18:47 UTC by Gabriel David
Modified: 2023-02-26 01:17 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
An ebuild that should fix this issue (doas-6.6.1-r1.ebuild,795 bytes, text/plain)
2020-06-03 18:47 UTC, Gabriel David
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel David 2020-06-03 18:47:00 UTC
Created attachment 643298 [details]
An ebuild that should fix this issue

In upstream, they decided to disable persist/timestamp/timeout because of security reasons. However, I believe there should be an option for the user to enable this, since it can be incredibly useful. Below I attached an ebuild that should fix this issue.
Comment 1 foxhkron 2020-06-27 13:36:25 UTC
I was about to make the same proposal, the persist feature can be useful.
Comment 2 Larry the Git Cow gentoo-dev 2020-08-08 09:04:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30f4904ab214b580f31f72a4560f1aac93043970

commit 30f4904ab214b580f31f72a4560f1aac93043970
Author:     Felix Janda <felix.janda@posteo.de>
AuthorDate: 2020-08-05 02:28:04 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-08-08 09:04:07 +0000

    app-admin/doas: Add support for experimental persist feature
    
    Closes: https://bugs.gentoo.org/726994
    Signed-off-by: Felix Janda <felix.janda@posteo.de>
    Closes: https://github.com/gentoo/gentoo/pull/16519
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-admin/doas/doas-6.6.1.ebuild | 3 ++-
 app-admin/doas/metadata.xml      | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)
Comment 3 Joonas Niilola gentoo-dev 2020-10-25 12:39:31 UTC
I'm looking into stabilizing 6.6.1, but I don't like the name of this feature. Should the USE flag be renamed as 'experimental', or 'persist'?
Comment 4 Larry the Git Cow gentoo-dev 2020-11-03 11:57:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc01de15c8d003e70065beb7c27bfeca253f3337

commit dc01de15c8d003e70065beb7c27bfeca253f3337
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-11-03 11:56:12 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-03 11:57:14 +0000

    app-admin/doas: rename 'timestamp' IUSE to 'persist'
    
    Bug: https://bugs.gentoo.org/751991
    Bug: https://bugs.gentoo.org/726994
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-admin/doas/doas-6.6.1.ebuild | 4 ++--
 app-admin/doas/metadata.xml      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-01-27 00:21:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6dc00fd47701bf7b9891258ff4331fbe9f47abe

commit f6dc00fd47701bf7b9891258ff4331fbe9f47abe
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-01-27 00:19:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-27 00:21:20 +0000

    profiles/base/p.use.stable.mask: mask app-admin/doas[persist]
    
    Bug: https://bugs.gentoo.org/726994
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/base/package.use.stable.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 6 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2021-07-10 20:38:19 UTC
For anyone coming here looking for details about why the flag is masked:

There's a warning here in the README: https://github.com/Duncaen/OpenDoas#persisttimestamptimeout

Which points to a longer explanation in timestamp.c: https://github.com/Duncaen/OpenDoas/blob/9a25a6d7b6be3ed4ffb822c5a3fa178057d18329/timestamp.c#L19
Comment 7 Larry the Git Cow gentoo-dev 2023-02-26 01:17:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99e1495dfc6616f5b33f8a90ba08f1039a8b005b

commit 99e1495dfc6616f5b33f8a90ba08f1039a8b005b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-26 01:16:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-26 01:17:40 +0000

    profiles/base: drop doas[persist] stable-mask
    
    The stable-mask was well intentioned, but:
    1. It's a popular application and stable masks are hard for new users
    to understand and deal with early on;
    
    2. Eli Schwartz points out sudo has the same problem on Linux anyway.
    
    I think the mask does more harm than good.
    
    Closes: https://bugs.gentoo.org/726994
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/base/package.use.stable.mask | 6 ------
 1 file changed, 6 deletions(-)