Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 723314 - sci-calculators/tilp2-1.18 configure error when /bin/sh != bash (PATCH)
Summary: sci-calculators/tilp2-1.18 configure error when /bin/sh != bash (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2020-05-16 05:35 UTC by Matt Whitlock
Modified: 2021-08-20 02:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix-configure-bashism.patch (fix-configure-bashism.patch,516 bytes, patch)
2020-05-16 05:35 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2020-05-16 05:35:51 UTC
Created attachment 639494 [details, diff]
fix-configure-bashism.patch

tilp2's configure.ac contains a Bashism (use of == operator with test built-in). Thus, configure emits an error when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features.

if test "x$build" == "x$host" ; then

checking for the host compiler... ./configure: 20469: test: xx86_64-pc-linux-gnu: unexpected operator

The attached patch removes the Bashism and allows sci-calculators/tilp2-1.18 to configure without error when /bin/sh is Dash.
Comment 1 Larry the Git Cow gentoo-dev 2021-08-20 02:18:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe419f34f7df788b25799373c54d80ecde80c9ae

commit fe419f34f7df788b25799373c54d80ecde80c9ae
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-08-20 02:14:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-08-20 02:14:08 +0000

    sci-calculators/tilp2: fix bashism in configure
    
    Thanks-to: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/723314
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-calculators/tilp2/files/tilp2-1.18-nonbash.patch | 12 ++++++++++++
 sci-calculators/tilp2/tilp2-1.18.ebuild              |  4 ++++
 2 files changed, 16 insertions(+)