Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 723094 - dev-util/mdds-1.6.0 configure errors when /bin/sh != bash
Summary: dev-util/mdds-1.6.0 configure errors when /bin/sh != bash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2020-05-14 19:21 UTC by Matt Whitlock
Modified: 2020-05-28 17:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2020-05-14 19:21:07 UTC
mdds's configure.ac contains Bashisms (use of == operator with test built-in). Thus, configure emits errors when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features.

Suggest setting CONFIG_SHELL=/bin/bash when running configure.


Example configure output follows. Note the occurrences of "unexpected operator."


checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
./configure: 2512: test: x: unexpected operator
./configure: 2524: test: x: unexpected operator
./configure: 2548: test: xyes: unexpected operator
./configure: 2554: test: xno: unexpected operator
./configure: 2569: test: xyes: unexpected operator
./configure: 2585: test: xno: unexpected operator
checking for x86_64-pc-linux-gnu-g++... x86_64-pc-linux-gnu-g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether x86_64-pc-linux-gnu-g++ accepts -g... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of x86_64-pc-linux-gnu-g++... none
checking for gdb... /usr/bin/gdb
checking for expect... no
checking for runtest... no
./configure: 3592: test: xno: unexpected operator


The "unexpected operator" messages are not present when CONFIG_SHELL=/bin/bash.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-05-15 07:04:18 UTC
Upstream patch welcome.
Comment 2 Larry the Git Cow gentoo-dev 2020-05-28 17:09:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=145fbf100e4f0e9d75f24b08f403dcc43137d2f8

commit 145fbf100e4f0e9d75f24b08f403dcc43137d2f8
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-05-28 16:42:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-05-28 17:09:01 +0000

    dev-util/mdds: Fix bashisms in configure.ac
    
    Reported-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/723094
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-util/mdds/files/mdds-1.6.0-bashism.patch | 75 ++++++++++++++++++++++++++++
 dev-util/mdds/mdds-1.6.0.ebuild              |  5 +-
 2 files changed, 79 insertions(+), 1 deletion(-)