Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 720866 - sys-apps/portage should not set PKG_CONFIG_PATH to /usr/lib64/pkgconfig
Summary: sys-apps/portage should not set PKG_CONFIG_PATH to /usr/lib64/pkgconfig
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
: 720904 (view as bug list)
Depends on: 126801
Blocks: 720940 721152
  Show dependency tree
 
Reported: 2020-05-03 20:40 UTC by Mike Gilbert
Modified: 2020-07-22 16:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2020-05-03 20:40:49 UTC
In phase-functions.sh, we set PKG_CONFIG_PATH to "${EPREFIX}/usr/$(get_libdir)/pkgconfig".

This causes breakage in meson.eclass when building x11-libs/gdk-pixbuf:

meson setup --buildtype plain --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload --build.pkg-config-path /usr/lib64/pkgconfig --pkg-config-path /usr/lib64/pkgconfig ...

../gdk-pixbuf-2.40.0/meson.build:198:2: ERROR: Dependency "shared-mime-info" not found, tried pkgconfig and cmake

Portage should either not set this variable, or we should set both PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR as given below.

PKG_CONFIG_PATH="${EPREFIX}/usr/share/pkgconfig"
PKG_CONFIG_LIBDIR="${EPREFIX}/usr/$(get_libdir)/pkgconfig"
Comment 1 Larry the Git Cow gentoo-dev 2020-05-03 20:44:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e569e669447a74c2269a0d0f86f53af70fe19284

commit e569e669447a74c2269a0d0f86f53af70fe19284
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-05-03 20:43:41 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-05-03 20:43:41 +0000

    meson.eclass: ignore PKG_CONFIG_PATH due to Portage bug
    
    Bug: https://bugs.gentoo.org/720866
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 eclass/meson.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Zac Medico gentoo-dev 2020-05-03 20:57:39 UTC
The PKG_CONFIG_PATH setting comes from here:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=d802344f16b10b6529762806cbdd38f7edb57aff

commit d802344f16b10b6529762806cbdd38f7edb57aff
Author:     Simon Stelling <blubb@gentoo.org>
AuthorDate: 2006-04-06 19:47:04 +0000
Commit:     Simon Stelling <blubb@gentoo.org>
CommitDate: 2006-04-06 19:47:04 +0000

    set PKG_CONFIG_PATH correct on multilib systems; bug 126801
    
    svn path=/main/trunk/; revision=3083

 bin/ebuild.sh | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 3 Mike Gilbert gentoo-dev 2020-05-03 21:22:35 UTC
Modern versions of pkg-config have the correct libdir specified at compile time. I think we should just drop this code.
Comment 4 Larry the Git Cow gentoo-dev 2020-05-03 21:42:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e2df750e074a54f85aa4f2c109fe8ceea2b9359a

commit e2df750e074a54f85aa4f2c109fe8ceea2b9359a
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-05-03 21:28:44 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-05-03 21:38:13 +0000

    phase-functions.sh: do not set PKG_CONFIG_PATH
    
    Recent pkg-config should have the correct path built in by default.
    
    Bug: https://bugs.gentoo.org/720866
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Reviewed-by: Zac Medico <zmedico@gentoo.org>

 bin/phase-functions.sh | 4 ----
 1 file changed, 4 deletions(-)
Comment 5 Arfrever Frehtes Taifersar Arahesis 2020-05-04 07:56:23 UTC
*** Bug 720904 has been marked as a duplicate of this bug. ***
Comment 6 Mart Raudsepp gentoo-dev 2020-05-05 21:01:57 UTC
Now packages using python3.pc appear broken with current workarounds, as python-utils-r1.eclass sets PKG_CONFIG_PATH and meson.eclass just ignores it...
Comment 7 Larry the Git Cow gentoo-dev 2020-05-05 21:28:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8447ae886cb4465129e8687f38cea0e6d784c4ef

commit 8447ae886cb4465129e8687f38cea0e6d784c4ef
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-05-05 21:26:42 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-05-05 21:28:05 +0000

    meson.eclass: append /usr/share/pkgconfig to PKG_CONFIG_PATH
    
    Bug: https://bugs.gentoo.org/720866
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 eclass/meson.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2020-05-25 00:24:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77960c6cf984530dbcab9fe507e170e7a2fe7dcf

commit 77960c6cf984530dbcab9fe507e170e7a2fe7dcf
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-05-25 00:20:07 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-05-25 00:20:58 +0000

    sys-apps/portage: Bump to version 2.3.100
    
     #715108 Change default BINPKG_COMPRESS to zstd
     #719456 Add dependency on app-arch/zstd
     #720866 Do not set PKG_CONFIG_PATH
     #721402 Hostname UnicodeEncodeError surrogates not allowed
     #721516 Suppress precompressed QA notice for docompress -x
    
    Bug: https://bugs.gentoo.org/721152
    Bug: https://bugs.gentoo.org/715108
    Bug: https://bugs.gentoo.org/719456
    Bug: https://bugs.gentoo.org/720866
    Bug: https://bugs.gentoo.org/721402
    Bug: https://bugs.gentoo.org/721516
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest               |   1 +
 sys-apps/portage/portage-2.3.100.ebuild | 261 ++++++++++++++++++++++++++++++++
 2 files changed, 262 insertions(+)