Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 719010 - dev-python/jupyter{,_console}: need py3.7, 3.8 port
Summary: dev-python/jupyter{,_console}: need py3.7, 3.8 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: python3.7-compat 718506
  Show dependency tree
 
Reported: 2020-04-23 08:37 UTC by Michał Górny
Modified: 2020-05-12 09:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-23 08:37:46 UTC
The packages are stuck on py3.6 which means they will be pain once we switch to 3.7.  Please test them on 3.7 *and* 3.8 (so we don't to revisit this in a few months), and update PYTHON_COMPAT appropriately.  If it doesn't work, please either fix it, remove Python or issue last rites.  Please consider this urgent.
Comment 1 Nick 2020-05-03 15:57:08 UTC
I tested python 3.7 with jupyter and jupyter_console and everything works fine for me when I set PYTHON_TARGETS to +python3_7, -python3_6:

[ebuild   R   ~] dev-python/jupyter_console-6.0.0::nmeyer  USE="-doc -test" PYTHON_TARGETS="python3_7 -python3_6" 0 KiB
[ebuild   R   ~] dev-python/jupyter-1.0.0-r2::nmeyer  USE="-doc" PYTHON_TARGETS="python3_7 -python3_6" 0 KiB

I enabled test use flag and feature and confirmed that tests passed on python3_7

>>> Test phase: dev-python/jupyter_console-6.0.0
 * python3_7: running distutils-r1_run_phase python_test
nose.plugins.cover: ERROR: Coverage not available: unable to import coverage module
....Warning: Output is not to a terminal (fd=1).
Warning: Input is not to a terminal (fd=0).
.....
----------------------------------------------------------------------
Ran 9 tests in 8.037s

OK
 * python3_7: running distutils-r1_run_phase _distutils-r1_clean_egg_info
>>> Completed testing dev-python/jupyter_console-6.0.0

I also tested python3_8 and that _seems_ to work fine as well, but to even test it I had to version bump and add 3.8 to PYTHON_COMPAT to more than 10 dependencies in my local overlay.

Should 3.8 be added to PYTHON_COMPAT of these packages before 3.8 is added to their dependencies? Or could I open a PR that just adds 3.7 and then later followup with a larger PR that bumps all the dependencies required to add 3.8?

These are the dependencies I bumped for testing 3.8, although they install for me and seem to work with -test and -doc, I suspect some of them may be broken with +test or +doc:

dev-python/ipykernel dev-python/ipyparallel dev-python/ipython dev-python/ipywidgets dev-python/jupyter_client dev-python/jupyter dev-python/jupyter_core dev-python/nbconvert dev-python/nbformat dev-python/notebook dev-python/widgetsnbextension dev-python/jupyter_console dev-python/qtconsole

Exact versions:

=dev-python/ipykernel-5.2.1 =dev-python/ipyparallel-6.2.5 =dev-python/ipython-7.14.0 =dev-python/ipywidgets-7.5.1 =dev-python/jupyter_client-6.1.3 =dev-python/jupyter_core-4.6.3 =dev-python/nbconvert-5.6.1 =dev-python/nbformat-5.0.6 =dev-python/notebook-6.0.3 =dev-python/widgetsnbextension-3.5.1 dev-python/jupyter_console =dev-python/qtconsole-4.7.3
Comment 2 Larry the Git Cow gentoo-dev 2020-05-03 16:40:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cae4815901737b988516d78f3e6ac7216e2aca1c

commit cae4815901737b988516d78f3e6ac7216e2aca1c
Author:     Nicholas Meyer <nickaristocrates@gmail.com>
AuthorDate: 2020-05-03 05:01:07 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-05-03 16:40:02 +0000

    dev-python/jupyter: add python3_7 to PYTHON_COMPAT
    
    Closes: https://bugs.gentoo.org/719010
    Signed-off-by: Nicholas Meyer <nickaristocrates@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/15627
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/jupyter/jupyter-1.0.0-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=321113f2c0b1e5c5a191640696943d4a2ebcc6c5

commit 321113f2c0b1e5c5a191640696943d4a2ebcc6c5
Author:     Nicholas Meyer <nickaristocrates@gmail.com>
AuthorDate: 2020-05-03 04:59:09 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-05-03 16:40:01 +0000

    dev-python/jupyter_console: add python3_7 to PYTHON_COMPAT
    
    Closes: https://bugs.gentoo.org/719010
    Signed-off-by: Nicholas Meyer <nickaristocrates@gmail.com>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/jupyter_console/jupyter_console-6.0.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Benda Xu gentoo-dev 2020-05-12 09:07:44 UTC
Thanks you Nicholas for the tests and pull request!