Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 718450 - net-misc/s3cmd: need py3.7, 3.8 port
Summary: net-misc/s3cmd: need py3.7, 3.8 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2020-09-21
Assignee: Igor Testen
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: python3.7-compat
  Show dependency tree
 
Reported: 2020-04-19 20:02 UTC by Michał Górny
Modified: 2020-08-24 13:38 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bump ver, python, EAPI (s3cmd-2.1.0.ebuild,599 bytes, text/plain)
2020-08-23 11:12 UTC, Richard Freeman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-19 20:02:05 UTC
The packages are stuck on py3.6 which means they will be pain once we switch to 3.7.  Please test them on 3.7 *and* 3.8 (so we don't to revisit this in a few months), and update PYTHON_COMPAT appropriately.  If it doesn't work, please either fix it, remove Python or issue last rites.  Please consider this urgent.
Comment 1 Matt Whitlock 2020-04-25 19:05:47 UTC
Note: Version 2.1.0 of s3cmd explicitly supports Python 3.7 and 3.8:

https://github.com/s3tools/s3cmd/blob/v2.1.0/setup.py#L112

Just need a version bump.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-08-16 10:05:07 UTC
ping.
Comment 3 Richard Freeman gentoo-dev 2020-08-23 11:12:56 UTC
Created attachment 656352 [details]
bump ver, python, EAPI

The attached bump works for me.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-23 11:17:14 UTC
(In reply to Richard Freeman from comment #3)
> Created attachment 656352 [details]
> bump ver, python, EAPI
> 
> The attached bump works for me.

Given it's last-rited, I don't think anyone will mind if you commit this and look after it.
Comment 5 Richard Freeman gentoo-dev 2020-08-23 11:57:14 UTC
(In reply to Sam James from comment #4)
> (In reply to Richard Freeman from comment #3)
> > Created attachment 656352 [details]
> > bump ver, python, EAPI
> > 
> > The attached bump works for me.
> 
> Given it's last-rited, I don't think anyone will mind if you commit this and
> look after it.

Yeah, I was planning on stepping in if I didn't hear anything soon, but figured I'd make this one last ping.

mgorny, I'll clean up the mask after I clean up the package.  I haven't been closely following the 3.6 removal - if you need this fast-tracked for stabilization faster than 30d let me know, otherwise I'll plan to do the normal wait.
Comment 6 David Seifert gentoo-dev 2020-08-23 11:59:47 UTC
(In reply to Richard Freeman from comment #5)
> (In reply to Sam James from comment #4)
> > (In reply to Richard Freeman from comment #3)
> > > Created attachment 656352 [details]
> > > bump ver, python, EAPI
> > > 
> > > The attached bump works for me.
> > 
> > Given it's last-rited, I don't think anyone will mind if you commit this and
> > look after it.
> 
> Yeah, I was planning on stepping in if I didn't hear anything soon, but
> figured I'd make this one last ping.
> 
> mgorny, I'll clean up the mask after I clean up the package.  I haven't been
> closely following the 3.6 removal - if you need this fast-tracked for
> stabilization faster than 30d let me know, otherwise I'll plan to do the
> normal wait.

* please also try adding py 3.9
* setuptools in DEPEND isn't needed anymore
* clean up the metadata section:

DESCRIPTION="Command line client for Amazon S3"
HOMEPAGE="https://s3tools.org/s3cmd"
SRC_URI="mirror://sourceforge/s3tools/${P/_/-}.tar.gz"

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="amd64 ~ia64 x86 ~amd64-linux ~x64-macos"
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-08-23 12:05:11 UTC
Stabilization of package that's masked makes no sense. By definition, it's not being tested by anyone. Just drop it to ~arch.
Comment 8 Richard Freeman gentoo-dev 2020-08-23 12:12:50 UTC
(In reply to Michał Górny from comment #7)
> Stabilization of package that's masked makes no sense. By definition, it's
> not being tested by anyone. Just drop it to ~arch.

Well, the new package is going in ~arch so that it can be tested.  I'll be stabilizing it in 30d regardless.

I wasn't sure if there was a rush to get rid of 3.6 and having the old stable package around would be a problem.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-08-23 12:19:24 UTC
Or just unmask the old one. Just don't keep it masked before stabilizing.
Comment 10 Larry the Git Cow gentoo-dev 2020-08-24 13:38:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c97602245546d9aec9831d21640e6d1c38c1247

commit 5c97602245546d9aec9831d21640e6d1c38c1247
Author:     Richard Freeman <rich0@gentoo.org>
AuthorDate: 2020-08-24 13:31:59 +0000
Commit:     Richard Freeman <rich0@gentoo.org>
CommitDate: 2020-08-24 13:35:57 +0000

    net-misc/s3cmd: bump, python3.7+ support
    
    Closes: https://bugs.gentoo.org/718450
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Richard Freeman <rich0@gentoo.org>

 net-misc/s3cmd/Manifest           |  1 +
 net-misc/s3cmd/metadata.xml       |  4 ++++
 net-misc/s3cmd/s3cmd-2.1.0.ebuild | 23 +++++++++++++++++++++++
 3 files changed, 28 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d28ba09e91df06f8058904cddabbb3b2bdc5620

commit 1d28ba09e91df06f8058904cddabbb3b2bdc5620
Author:     Richard Freeman <rich0@gentoo.org>
AuthorDate: 2020-08-24 13:33:35 +0000
Commit:     Richard Freeman <rich0@gentoo.org>
CommitDate: 2020-08-24 13:36:53 +0000

    package.mask: unmask s3cmd after fix
    
    Bug: https://bugs.gentoo.org/718450
    Signed-off-by: Richard Freeman <rich0@gentoo.org>

 profiles/package.mask | 1 -
 1 file changed, 1 deletion(-)