Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717752 - games-roguelike/dwarf-fortress-0.47.04 version bump
Summary: games-roguelike/dwarf-fortress-0.47.04 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-16 20:17 UTC by Martin Doucha
Modified: 2022-07-06 08:39 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Diff of ebuilds (df_diff,604 bytes, text/plain)
2020-05-12 23:33 UTC, Rick Foland
Details
Diff of Ebuilds Updated (df44.07.diff,602 bytes, patch)
2020-05-28 01:40 UTC, Rick Foland
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Doucha 2020-04-16 20:17:44 UTC
New version of Dwarf Fortress is out. This release brings epic levels of organized villainy and fixes several game-breaking bugs, for example unit inventory corruption in fortress mode when your squad returns from a raid on another fort, which will crash the game.

Reproducible: Always
Comment 1 Rick Foland 2020-05-12 02:49:42 UTC
Version 47.04 builds fine with the current ebuild, but errors with EAPI 7. Is using EAPI 7 mandatory or can I push this package using 6?
Comment 2 Rick Foland 2020-05-12 02:57:30 UTC
Whoops. I didn't realize this was maintained by the games project. Forget what I said. I'm looking into the failure on EAPI 7 now.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-05-12 03:18:57 UTC
(In reply to Rick Foland from comment #2)
> Whoops. I didn't realize this was maintained by the games project. Forget
> what I said. I'm looking into the failure on EAPI 7 now.

Any PR would still be gladly welcomed.
Comment 4 Rick Foland 2020-05-12 03:34:10 UTC
Okay, I think I got it. It was using some depreciated functions that it was inheriting from the versionator eclass. I replaced them with the new ones and everything is working with EAPI 7.I made the below changes:

EAPI=7

inherit toolchain-funcs

MY_PV=$(ver_rs 1 _ "$(ver_cut 2-)")
Comment 5 Rick Foland 2020-05-12 23:33:52 UTC
Created attachment 638488 [details]
Diff of ebuilds
Comment 6 Rick Foland 2020-05-28 01:40:27 UTC
Created attachment 642128 [details, diff]
Diff of Ebuilds Updated

The parsing of the version changed up on me today and I fixed it in the ebuild.
Comment 7 Matthew Smith gentoo-dev 2022-04-14 16:53:13 UTC
(sorry for the noise, I did not mean to close the bug)
Comment 8 Larry the Git Cow gentoo-dev 2022-07-06 08:39:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97a24df3591ca7bebd0fcd189e1da5f16240715c

commit 97a24df3591ca7bebd0fcd189e1da5f16240715c
Author:     Joshua Goins <josh@redstrate.com>
AuthorDate: 2022-06-28 23:57:28 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-07-06 08:37:53 +0000

    games-roguelike/dwarf-fortress: add 0.47.05
    
    Signed-off-by: Joshua Goins <josh@redstrate.com>
    Co-authored-by: Sven Eusewig <sveneusewig@yahoo.de>
    Co-authored-by: Wolfgang E. Sanyer <ezzieyguywuf@gmail.com>
    Closes: https://bugs.gentoo.org/703384
    Closes: https://bugs.gentoo.org/703386
    Closes: https://bugs.gentoo.org/717752
    Closes: https://bugs.gentoo.org/729002
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-roguelike/dwarf-fortress/Manifest            |  2 +
 .../dwarf-fortress/dwarf-fortress-0.47.05.ebuild   | 97 ++++++++++++++++++++++
 .../files/dwarf-fortress-0.47.05-fix-cmath.patch   | 11 +++
 ...warf-fortress-0.47.05-segfault-fix-729002.patch | 49 +++++++++++
 4 files changed, 159 insertions(+)