Created attachment 615184 [details] ydiff-1.1.ebuild Commit to show rename: https://github.com/ymattw/ydiff/commit/ba7dea407c0748fdca37232a026d2bc25df16bea Commit from which changes were diff'd against release 1.1: https://github.com/ymattw/ydiff/commit/c3771b98e4379c85c2e9be67e19301ae42a17b9e Reason for patching release 1.1: Test fails with Python versions greater than 3.6. The fix for Python >=3.7: https://github.com/ymattw/ydiff/commit/0fdd167f927b2782a11385f046fb19bf59a8f494 ydiff works, and passed tests for 2.7, 3.6, 3.7, and 3.8. There are warnings in the log that I'm unclear on the severity of. Bug #616446 might need to be revisited. I recommend removing older revisions of cdiff since they do not share the same Python compatibility as 1.1.
Created attachment 615186 [details, diff] master branch merge
Created attachment 615188 [details] build.log
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: • Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman • KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD • A bot can look for additional mistakes, if you upload a PR via github
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6868e6f31fca7a3ed0ee803b4f4eb7f405a5a31a commit 6868e6f31fca7a3ed0ee803b4f4eb7f405a5a31a Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2020-03-18 00:37:36 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2020-03-18 00:42:11 +0000 dev-util/cdiff: 1.1, transition to dev-util/ydiff Bug: https://bugs.gentoo.org/710538 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-2.3.92, Repoman-2.3.20 dev-util/cdiff/cdiff-1.1.ebuild | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4072fa366a599b2cf3267d0bbcdceb63df1a228e commit 4072fa366a599b2cf3267d0bbcdceb63df1a228e Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2020-03-18 00:27:54 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2020-03-18 00:42:10 +0000 dev-util/ydiff: New package, successor to dev-util/cdiff Bug: https://bugs.gentoo.org/710538 Signed-off-by: Sebastian Pipping <sping@gentoo.org> Package-Manager: Portage-2.3.92, Repoman-2.3.20 dev-util/ydiff/Manifest | 1 + dev-util/ydiff/metadata.xml | 12 ++++++++++++ dev-util/ydiff/ydiff-1.1.ebuild | 30 ++++++++++++++++++++++++++++++ 3 files changed, 43 insertions(+)
(In reply to Jason Chan from comment #1) > Created attachment 615186 [details, diff] [details, diff] > master branch merge Hi Jason, could you elaborate how that patch was created and why we need it on top of ydiff 1.1? Thank you!
@sping, can you lastrite cdiff when ready?
ydiff is not Gentoo-stable but cdiff is. So a last-rite of cdiff would be trouble to users of stable without prior stabilisation.
That's why I said 'when ready'.
Can we stabilize it now?
amd64 stable
x86 stable. Closing.
mgorny, you can last-rite dev-util/cdiff now if you like.
Lemme reuse the bug since it carries all info on why it's happening.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=319773e7cca2c25d4dd3f734e07f73df722e2fda commit 319773e7cca2c25d4dd3f734e07f73df722e2fda Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-06-05 05:21:16 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-06-05 05:21:37 +0000 package.mask: Last rite dev-util/cdiff Bug: https://bugs.gentoo.org/710538 Signed-off-by: Michał Górny <mgorny@gentoo.org> profiles/package.mask | 5 +++++ 1 file changed, 5 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62f7495f92dc2c173f9ff189a7b354de4f3279b8 commit 62f7495f92dc2c173f9ff189a7b354de4f3279b8 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2020-07-13 04:53:38 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2020-07-13 04:53:38 +0000 dev-util/cdiff: Remove last-rited pkg Closes: https://bugs.gentoo.org/710538 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-util/cdiff/Manifest | 1 - dev-util/cdiff/cdiff-1.0.ebuild | 31 --------------------- dev-util/cdiff/cdiff-1.1.ebuild | 21 -------------- dev-util/cdiff/cdiff-9999.ebuild | 32 ---------------------- ...ff-0.9.2-disable-unimportant-failing-test.patch | 11 -------- dev-util/cdiff/metadata.xml | 9 ------ profiles/package.mask | 5 ---- 7 files changed, 110 deletions(-)
