Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706930 - games-rpg/freedroidrpg-1.0_rc2 : fails to build with -fno-common or gcc-10
Summary: games-rpg/freedroidrpg-1.0_rc2 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-28 18:41 UTC by Toralf Förster
Modified: 2020-09-13 12:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.95 KB, text/plain)
2020-01-28 18:42 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,130.17 KB, text/plain)
2020-01-28 18:42 UTC, Toralf Förster
Details
environment (environment,127.98 KB, text/plain)
2020-01-28 18:42 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,12.91 KB, application/x-bzip)
2020-01-28 18:42 UTC, Toralf Förster
Details
games-rpg:freedroidrpg-1.0_rc2:20200128-112941.log (games-rpg:freedroidrpg-1.0_rc2:20200128-112941.log,83.29 KB, text/plain)
2020-01-28 18:42 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,12.32 KB, application/x-bzip)
2020-01-28 18:42 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,35.47 KB, application/x-bzip)
2020-01-28 18:42 UTC, Toralf Förster
Details
Fix building with gcc-10 (freedroidrpg-1.0RC2-gcc10.patch,2.36 KB, patch)
2020-06-21 11:03 UTC, Michael Uleysky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-28 18:41:58 UTC
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -DFD_DATADIR='"/usr/share/freedroidrpg"' -DTOP_DATADIR='".."' -I../lua -DLOCALEDIR='"/usr/share/locale"'  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/usr/include/libdrm  -pipe -Wall -Wno-format-zero-length -O2 -pipe -march=native -fno-common -c -o widgets/widget_text_list.o widgets/widget_text_list.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -DFD_DATADIR='"/usr/share/freedroidrpg"' -DTOP_DATADIR='".."' -I../lua -DLOCALEDIR='"/usr/share/locale"'  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/usr/include/libdrm  -pipe -Wall -Wno-format-zero-length -O2 -pipe -march=native -fno-common -c -o savestruct.o savestruct.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -DFD_DATADIR='"/usr/share/freedroidrpg"' -DTOP_DATADIR='".."' -I../lua -DLOCALEDIR='"/usr/share/locale"'  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/usr/include/libdrm  -pipe -Wall -Wno-format-zero-length -O2 -pipe -march=native -fno-common -c -o version.o version.c
x86_64-pc-linux-gnu-gcc -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -I/usr/include/libdrm  -pipe -Wall -Wno-format-zero-length -O2 -pipe -march=native -fno-common -rdynamic -Wl,--as-needed -Wl,-O1 -Wl,--as-needed -o freedroidRPG action.o addon_crafting_ui.o animate.o armor.o automap.o benchmark.o BFont.o blocks.o bullet.o character.o chat.o colldet.o dynarray.o enemy.o event.o faction.o floor_tiles.o font.o game_act.o game_ui.o getopt.o getopt1.o graphics.o hud.o image.o influ.o init.o input.o items.o item_upgrades.o item_upgrades_ui.o keyboard.o lang.o light.o lists.o lua.o luaconfig.o main.o map.o map_label.o menu.o misc.o mission.o npc.o obstacle.o obstacle_extension.o open_gl.o open_gl_atlas.o open_gl_debug.o open_gl_shaders.o pathfinder.o pngfuncs.o quest_browser_ui.o rtprof.o saveloadgame.o savestruct_internal.o scandir.o shop.o skills.o sound.o sound_effects.o string.o takeover.o text.o text_public.o title.o view.o waypoint.o lua/luaFD.o lua/luaFD_tux.o lua/luaFD_npc.o lvledit/lvledit.o lvledit/lvledit_actions.o lvledit/lvledit_beautify_actions.o lvledit/lvledit_display.o lvledit/lvledit_enemy.o lvledit/lvledit_input.o lvledit/lvledit_map.o lvledit/lvledit_menu.o lvledit/lvledit_object_lists.o lvledit/lvledit_tools.o lvledit/lvledit_tool_move.o lvledit/lvledit_tool_place.o lvledit/lvledit_tool_select.o lvledit/lvledit_validator.o lvledit/lvledit_widgets.o lvledit/lvledit_widget_categoryselect.o lvledit/lvledit_widget_map.o lvledit/lvledit_widget_minimap.o lvledit/lvledit_widget_toolbar.o mapgen/gram_simple.o mapgen/mapgen.o mapgen/themes.o savegame/convert.o savegame/filters_0_16.o savegame/filters_0_16_1.o widgets/widgets.o widgets/widget_autoscroll_text.o widgets/widget_background.o widgets/widget_button.o widgets/widget_group.o widgets/widget_text.o widgets/widget_text_list.o savestruct.o version.o  ../lua/liblua.a  -lSDL -lpthread -lGL  -lm -lGLEW -lGLU -lGL    -lSDL_gfx -lSDL_image -lpng -ljpeg -lz -lm 
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: animate.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-libressl-20200125-150902

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Tue, 28 Jan 2020 10:46:23 +0000

emerge -qpvO games-rpg/freedroidrpg
[ebuild  N    ] games-rpg/freedroidrpg-1.0_rc2  USE="nls opengl -debug -devtools -profile -sanitize -sound"
Comment 1 Toralf Förster gentoo-dev 2020-01-28 18:42:01 UTC
Created attachment 606646 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-28 18:42:04 UTC
Created attachment 606648 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-28 18:42:06 UTC
Created attachment 606650 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-28 18:42:09 UTC
Created attachment 606652 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-28 18:42:12 UTC
Created attachment 606654 [details]
games-rpg:freedroidrpg-1.0_rc2:20200128-112941.log
Comment 6 Toralf Förster gentoo-dev 2020-01-28 18:42:15 UTC
Created attachment 606656 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-01-28 18:42:18 UTC
Created attachment 606658 [details]
temp.tbz2
Comment 8 Michael Uleysky 2020-06-21 11:03:11 UTC
Created attachment 645498 [details, diff]
Fix building with gcc-10

Correctly placed extern's solve the problem. Patch attached.
Comment 9 Alexey 2020-09-12 22:34:12 UTC
Confirming, the patch works, thanks!
Comment 10 Larry the Git Cow gentoo-dev 2020-09-13 12:50:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8debeb4149f2bd0d067b7fbc6b3235ff69f4ed0c

commit 8debeb4149f2bd0d067b7fbc6b3235ff69f4ed0c
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-09-12 22:42:58 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-09-13 12:49:23 +0000

    games-rpg/freedroidrpg: fix build on gcc 10
    
    And fix prefix and add py3.8
    
    Closes: https://bugs.gentoo.org/706930
    Package-Manager: Portage-3.0.4, Repoman-2.3.23
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Closes: https://github.com/gentoo/gentoo/pull/17516
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../files/freedroidrpg-1.0_rc2-fnocommon.patch     | 49 ++++++++++++++++++++++
 games-rpg/freedroidrpg/freedroidrpg-1.0_rc2.ebuild |  9 +++-
 2 files changed, 56 insertions(+), 2 deletions(-)