Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 692774 - [Future EAPI] Less strict naming rules for files in updates directory
Summary: [Future EAPI] Less strict naming rules for files in updates directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL:
Whiteboard: in-eapi-8
Keywords:
Depends on:
Blocks: future-eapi
  Show dependency tree
 
Reported: 2019-08-23 16:00 UTC by Ulrich Müller
Modified: 2021-06-13 20:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2019-08-23 16:00:55 UTC
Naming rules within the updates directory are currently:
"It contains one file per quarter year, named [1-4]Q-[YYYY] for the first to fourth quarter of a given year, for example 1Q-2004 or 3Q-2006."

This is rather strict and won't allow to change to a different (e.g., monthly or yearly) naming scheme. Also, I don't see why we would need that restriction in the spec.

Therefore, I'd suggest to update the rules for EAPI 8, along these lines:
"All files in this directory will be processed, unless their name begins with a dot. Any subdirectories will be ignored."
Comment 1 Ulrich Müller gentoo-dev 2020-10-24 15:50:50 UTC
(In reply to Ulrich Müller from comment #0)
> "All files in this directory will be processed, unless their name begins
> with a dot. Any subdirectories will be ignored."

Make this "All regular files in this directory will be processed, unless their name begins with a dot."
Comment 2 Zac Medico gentoo-dev 2020-11-22 08:48:51 UTC
If we allow arbitrary names in profiles/updates then I wonder how we're supposed to order the updates, given that order sometimes matters.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-11-22 08:53:29 UTC
(In reply to Zac Medico from comment #2)
> If we allow arbitrary names in profiles/updates then I wonder how we're
> supposed to order the updates, given that order sometimes matters.

pkgcheck is supposed to report all the common cases, and make developers use idempotent updates.
Comment 4 Ulrich Müller gentoo-dev 2020-11-22 12:13:30 UTC
PMS doesn't specify any ordering right now:
https://projects.gentoo.org/pms/7/pms.html#x1-360004.4.4

As a matter of fact, I had complained about this in bug 296713, but ciaranm convinced me that the wording is fine as it is. (We could add the sentence I suggested in bug 296713 comment #14 if you think that it would clarify things.)
Comment 5 Larry the Git Cow gentoo-dev 2021-05-24 04:55:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=09d783eb12ed1f93550d86f1ee2437012ffc7cc2

commit 09d783eb12ed1f93550d86f1ee2437012ffc7cc2
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-05-12 16:10:10 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-05-24 04:40:21 +0000

    Relax update filenames as permitted for EAPI 8
    
    Bug: https://bugs.gentoo.org/692774
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/update.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2021-06-13 19:18:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pms.git/commit/?id=a14e130eacbd19fb8e835d2d385ac94ba693f23a

commit a14e130eacbd19fb8e835d2d385ac94ba693f23a
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2021-05-16 16:44:50 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-06-05 08:55:33 +0000

    EAPI 8 has less strict naming rules in the updates directory
    
    Bug: https://bugs.gentoo.org/692774
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eapi-differences.tex |  5 ++++-
 tree-layout.tex      | 25 +++++++++++++++++++++----
 2 files changed, 25 insertions(+), 5 deletions(-)