Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 690968 - [Future EAPI] unpack: Remove support for 7-Zip, RAR, and LHA
Summary: [Future EAPI] unpack: Remove support for 7-Zip, RAR, and LHA
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL:
Whiteboard: in-eapi-8
Keywords:
Depends on:
Blocks: future-eapi
  Show dependency tree
 
Reported: 2019-07-29 06:38 UTC by Michał Górny
Modified: 2021-06-13 20:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-07-29 06:38:28 UTC
Some stats:

.7z - 4 packages
.rar - 5 packages
.lha/.lzh - unused
.lzma - ~13 packages (I ran out of fingers ;-))

I think we could kill at least the first three, either removing them entirely in a future EAPI, or requesting use of unpacker.eclass via tree policy.

Why?  My main argument is that at least the two middle formats are rather baroque and have non-free dependencies.  In the rare occurrence of actually having to install an ebuild using one of those formats, I end up having to install additional programs while I already have other (apparently free) programs capable of unpacking them.

With those formats, I think unpacker.eclass is a better solution as it lets us easily adjust dependency lists and support alternative software.

Keeping .lzma is probably fine as I don't expect xz-utils to remove support for it anytime soon.
Comment 1 Ulrich Müller gentoo-dev 2019-07-29 17:13:41 UTC
There is also .Z which is used by 18 packages, and is handled by gzip. I would suggest that we keep both .Z and .lzma.

No strong opinion about the other three.
Comment 2 Ulrich Müller gentoo-dev 2020-02-22 22:04:13 UTC
As a matter of fact, the devmanual says that .rar must not be used:
https://devmanual.gentoo.org/ebuild-writing/functions/src_unpack/other-formats/#rar-files

".rar files must be repackaged locally into a .tar.bz2 file."
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-23 06:13:05 UTC
(In reply to Ulrich Müller from comment #2)
> As a matter of fact, the devmanual says that .rar must not be used:
> https://devmanual.gentoo.org/ebuild-writing/functions/src_unpack/other-
> formats/#rar-files
> 
> ".rar files must be repackaged locally into a .tar.bz2 file."

That's not going to work for mirror-restricted files though.
Comment 4 Larry the Git Cow gentoo-dev 2021-05-24 04:37:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=9ea780739f2489611da13223acf87ce3780bef6a

commit 9ea780739f2489611da13223acf87ce3780bef6a
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-05-12 12:19:15 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-05-24 04:35:28 +0000

    Remove unpack support for 7z, lha and rar in EAPI 8
    
    Bug: https://bugs.gentoo.org/690968
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/eapi.sh          | 12 ++++++++++++
 bin/phase-helpers.sh | 26 +++++++++++++++++++-------
 2 files changed, 31 insertions(+), 7 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-06-13 19:18:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pms.git/commit/?id=7ecef5fa690f1fcff2c615e4ea757d629a7bbdcf

commit 7ecef5fa690f1fcff2c615e4ea757d629a7bbdcf
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-12-24 21:50:30 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-06-05 08:55:41 +0000

    EAPI 8 removes .7z, .rar, .lha unpack support
    
    Bug: https://bugs.gentoo.org/690968
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 eapi-differences.tex | 10 ++++++++++
 pkg-mgr-commands.tex | 21 ++++++++++++++-------
 2 files changed, 24 insertions(+), 7 deletions(-)