Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684308 - dev-perl/Net-SSLeay-1.880.0 stabilization
Summary: dev-perl/Net-SSLeay-1.880.0 stabilization
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: AMD64 Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard: was: dev-perl/Net-SSLeay-1.850.0 USE=...
Keywords: STABLEREQ
: 687136 687196 690522 695512 (view as bug list)
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2019-04-24 21:34 UTC by Tomas Jelinek
Modified: 2019-11-30 21:51 UTC (History)
8 users (show)

See Also:
Package list:
dev-perl/Net-SSLeay-1.880.0
Runtime testing required: ---
stable-bot: sanity-check+


Attachments
emerge --info dev-perl/Net-SSLeay (emerge-info.txt,18.26 KB, text/plain)
2019-04-24 21:34 UTC, Tomas Jelinek
no flags Details
build.log (build.log,6.74 KB, text/plain)
2019-04-24 21:35 UTC, Tomas Jelinek
no flags Details
Libre291-perl-ssl.patch (Libre291-perl-ssl.patch,690 bytes, patch)
2019-04-24 22:15 UTC, pagorman
no flags Details | Diff
Libre291-perl-ssl.patch (SSLeay.patch,693 bytes, patch)
2019-04-24 22:23 UTC, pagorman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Jelinek 2019-04-24 21:34:53 UTC
Created attachment 574078 [details]
emerge --info dev-perl/Net-SSLeay

The problem is present after dev-libs/libressl-2.9.1 update.
Comment 1 Tomas Jelinek 2019-04-24 21:35:41 UTC
Created attachment 574080 [details]
build.log
Comment 2 pagorman 2019-04-24 21:54:44 UTC
Same error present in v 1.820.0 after the upgrade to LibreSSL-2.9.1 on amd64
Comment 3 pagorman 2019-04-24 22:15:13 UTC
Created attachment 574082 [details, diff]
Libre291-perl-ssl.patch

Another missing 

"&& !defined(LIBRESSL_VERSION_NUMBER)" 

statement. Since this one worked before with LibreSSL-2.8.3, I threw in some more well-defined "if" logic for the defined logic paths.

Testing: Installs good with dev-perl/Net-SSLeay-1.82

I hope it works well on v1.85!
Comment 4 pagorman 2019-04-24 22:23:36 UTC
Created attachment 574084 [details, diff]
Libre291-perl-ssl.patch

cleaner install.
Comment 5 Tomas Jelinek 2019-04-24 22:31:04 UTC
Thanks, I can confirm the patch works for 1.850.0 as well.
Comment 6 needle 2019-04-27 01:10:37 UTC
Confirmed. 
I hit this issue using dev-perl/Net-SSLeay-1.820.0 and dev-libs/libressl-2.9.1.

Rebuilding with applied patch fixes this. Patch works.
dev-perl/Net-SSLeay-1.850.0 hast not been tested.

Thanks.
Comment 7 Emmanuel Andry 2019-04-29 21:34:16 UTC
Patch doesn't work for me on 1.85 :

* Applying Libre291-perl-ssl.patch ...
1 out of 1 hunk FAILED -- saving rejects to file SSLeay. [ !! ]
Comment 8 Emmanuel Andry 2019-05-09 08:41:13 UTC
Masked 1.85, I confirm that patch fixes build for 1.82
Comment 9 Stefan Strogin gentoo-dev 2019-05-09 11:22:32 UTC
You can use dev-perl/Net-SSLeay-1.860.0* from the libressl overlay (https://github.com/gentoo/libressl)

It supports LibreSSL without any patches.
Comment 10 hkBst 2019-05-22 07:12:30 UTC
Presumably the stable release 1.88 should have the necessary changes as well...
Comment 11 Toralf Förster gentoo-dev 2019-05-24 20:16:27 UTC
1.860.0_p9 works well at a stable LibreSSL system
Comment 12 Andreas Sturmlechner gentoo-dev 2019-06-01 15:25:38 UTC
*** Bug 687136 has been marked as a duplicate of this bug. ***
Comment 13 Quentin Retornaz 2019-06-02 13:34:10 UTC
*** Bug 687196 has been marked as a duplicate of this bug. ***
Comment 14 Jory A. Pratt gentoo-dev 2019-07-02 04:20:51 UTC
*** Bug 687136 has been marked as a duplicate of this bug. ***
Comment 15 Larry the Git Cow gentoo-dev 2019-07-10 08:13:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19f6b8c827f9212ccd27e7d24de21c07630ecac2

commit 19f6b8c827f9212ccd27e7d24de21c07630ecac2
Author:     Stefan Strogin <steils@gentoo.org>
AuthorDate: 2019-05-25 10:22:02 +0000
Commit:     Kent Fredric <kentnl@gentoo.org>
CommitDate: 2019-07-10 08:13:00 +0000

    dev-perl/Net-SSLeay: Bump version to 1.880.0
    
    - Restore previously broken tests
    - CFLAGS repsect logic reworked for upstream tooling changes
    - LIBDIR respect logic reworked for upstream tooling changes
    - NETWORK_TESTS handling logic reworked for upstream tooling changes
    
    Upstream:
    - Clarify licensing to be consistently Artistic-2
    - Improved OpenSSL 1.1.1 support
    - Improved TLS 1.3 support
    - Fixed memory leaks in cb_data_advanced_put
    
    Bug: https://rt.cpan.org/Ticket/Display.html?id=106314
    Bug: https://rt.cpan.org/Ticket/Display.html?id=128207
    Closes: https://bugs.gentoo.org/556010
    Closes: https://bugs.gentoo.org/684308
    Closes: https://bugs.gentoo.org/686730
    Closes: https://github.com/gentoo/gentoo/pull/12101
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <steils@gentoo.org>
    Signed-off-by: Kent Fredric <kentnl@gentoo.org>

 dev-perl/Net-SSLeay/Manifest                       |  1 +
 dev-perl/Net-SSLeay/Net-SSLeay-1.880.0.ebuild      | 63 ++++++++++++++++++++++
 .../files/Net-SSLeay-1.88-fix-libdir.patch         | 27 ++++++++++
 .../files/Net-SSLeay-1.88-fix-network-tests.patch  | 17 ++++++
 4 files changed, 108 insertions(+)
Comment 16 Andreas Sturmlechner gentoo-dev 2019-07-23 20:22:08 UTC
*** Bug 690522 has been marked as a duplicate of this bug. ***
Comment 17 Jeroen Roovers (RETIRED) gentoo-dev 2019-09-27 13:55:51 UTC
*** Bug 695512 has been marked as a duplicate of this bug. ***
Comment 18 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2019-09-28 11:35:11 UTC
Guess its not fixed yet....
Comment 19 Quentin Retornaz 2019-09-28 11:45:05 UTC
(In reply to Kent Fredric (IRC: kent\n) from comment #18)
> Guess its not fixed yet....

It’s fixed, I’ve just built it with dev-libs/libressl-3.0.0
Comment 20 kfm 2019-09-28 18:58:46 UTC
(In reply to Kent Fredric (IRC: kent\n) from comment #18)
> Guess its not fixed yet....

It is. The problem is that, for as long as the fixed version remains stuck behind ~arch keywords, many libressl users are going to keep on running head first into this issue. Not everyone uses ~arch globally, or expects to do so in order to benefit from this kind of fix.
Comment 21 Quentin Retornaz 2019-09-28 22:25:56 UTC
(In reply to Kerin Millar from comment #20)
> It is. The problem is that, for as long as the fixed version remains stuck
> behind ~arch keywords, many libressl users are going to keep on running head
> first into this issue. Not everyone uses ~arch globally, or expects to do so
> in order to benefit from this kind of fix.

I dont know how others are trying to fix libressl related issues, but when I encounter one, I’m trying ~arch versions to see if it can fix it.
I’m running a stable arch system with ~arch for some packages.
Comment 22 kfm 2019-09-28 23:52:34 UTC
(In reply to Quentin R. from comment #21)
> I dont know how others are trying to fix libressl related issues, but when I
> encounter one, I’m trying ~arch versions to see if it can fix it.
> I’m running a stable arch system with ~arch for some packages.

That's a sensible thing to do in the course of troubleshooting but it wasn't really the point. To recap:-

• The compatibility issue is addressed in Net-SSLeay but the stable-keyworded version remains affected.
• Users of libressl that don't act as you do continue to report bugs against Net-SSLeay.
• These additional reports cause sufficient confusion for this bug to have been re-opened in error.

Assuming that there are no peripheral reasons to avoid doing so, the obvious resolution to all of this is to keyword as stable the version of Net-SSLeay that addresses this bug.
Comment 23 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2019-10-01 13:57:38 UTC
I'm thinking its "not fixed" due to the dupe reports that indicate they tested this exact fixed version.

Bug #695512

> Tested with 1.820.0, 1.850.0 and 1.880.0

So either the reporter mis-tested, lied, or its not fixed.

But I don't have the tools to determine the truth.
Comment 24 Alexander Weber 2019-10-01 14:54:46 UTC
I tested with `emerge -va1 =dev-perl/Net-SSLeay-1.880.0` in https://bugs.gentoo.org/695512 and it fails with the same error as with 1.820.0

Did not alternated other packages, the dev-libs/libressl was 2.9.2.

Anyway, I cannot retest them again because I am crawling back to openssl.
Comment 25 Quentin Retornaz 2019-10-01 15:52:39 UTC
(In reply to Kent Fredric (IRC: kent\n) from comment #23)
> I'm thinking its "not fixed" due to the dupe reports that indicate they
> tested this exact fixed version.
> 
> Bug #695512
> 
> > Tested with 1.820.0, 1.850.0 and 1.880.0
> 
> So either the reporter mis-tested, lied, or its not fixed.
> 
> But I don't have the tools to determine the truth.

The only thing I can tell is that libressl 3.0.0 and Net-SSLeay 1.880.0 works together. I haven't tested other versions.
Comment 26 kfm 2019-10-01 21:56:18 UTC
I use libressl-2.9.2, which is the stable version from the perspective of both Gentoo and upstream. Note that libressl-2.9.1 was not a stable release and neither was 2.9.0. Essentially, a given minor release of a given major series constitutes the first (officially) stable version of the major series whenever upstream say so.

Anyway, I can build Net-SSLeay-1.888.0 against libressl-2.9.2 without issue. Indeed, that's why I have had the former sitting in package.accept_keywords since it became available.
Comment 27 Thomas Raschbacher gentoo-dev 2019-10-07 06:36:16 UTC
I can confirm that with  dev-libs/libressl-2.9.2 the error is still there with current stable and  1.850.0.

dev-perl/Net-SSLeay-1.880.0 compiles just fine with above libressl version.
Comment 28 Andreas K. Hüttel archtester gentoo-dev 2019-10-25 16:19:04 UTC
(In reply to Thomas Raschbacher from comment #27)
> I can confirm that with  dev-libs/libressl-2.9.2 the error is still there
> with current stable and  1.850.0.
> 
> dev-perl/Net-SSLeay-1.880.0 compiles just fine with above libressl version.

Well seems like things can only get better.
Comment 29 Andreas K. Hüttel archtester gentoo-dev 2019-10-25 16:20:44 UTC
Please stabilize dev-perl/Net-SSLeay-1.880.0
Comment 30 Thomas Deutschmann (RETIRED) gentoo-dev 2019-10-25 20:33:41 UTC
x86 stable
Comment 31 Agostino Sarubbo gentoo-dev 2019-10-26 14:44:54 UTC
amd64 stable
Comment 32 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2019-11-01 10:10:51 UTC
arm stable
Comment 33 Aaron Bauman (RETIRED) gentoo-dev 2019-11-07 18:37:17 UTC
arm64 stable
Comment 34 Agostino Sarubbo gentoo-dev 2019-11-12 10:14:19 UTC
sparc stable
Comment 35 Agostino Sarubbo gentoo-dev 2019-11-12 10:16:32 UTC
s390 stable
Comment 36 Agostino Sarubbo gentoo-dev 2019-11-12 10:39:20 UTC
ppc64 stable
Comment 37 Agostino Sarubbo gentoo-dev 2019-11-12 16:02:49 UTC
ppc stable
Comment 38 Agostino Sarubbo gentoo-dev 2019-11-13 11:29:25 UTC
ia64 stable
Comment 39 Matt Turner gentoo-dev 2019-11-17 04:03:13 UTC
alpha stable
Comment 40 Sergei Trofimovich (RETIRED) gentoo-dev 2019-11-30 21:51:15 UTC
hppa stable

Last arch. Closing.