Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683436 - media-sound/gtick-0.5.4 double .desktop entries
Summary: media-sound/gtick-0.5.4 double .desktop entries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal minor
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-04-16 03:57 UTC by Mārtiņš Mačs
Modified: 2020-03-21 19:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mārtiņš Mačs 2019-04-16 03:57:21 UTC
GTick has two .desktop entries in /usr/share/applications:
* one created by `make install`,
* second created by `make_desktop_entry` in ebuild.

This is due to recent update from 0.5.0 to 0.5.4.
0.5.0 did not include .desktop entry, so it was created by ebuild.
However 0.5.4 now includes its own .desktop file, but ebuild still creates one.

I guess `make_desktop_entry` should be removed.
Comment 1 Larry the Git Cow gentoo-dev 2020-03-21 19:40:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7ebc693196f45c5fe3fb3eda2aa61123ca6f66b6

commit 7ebc693196f45c5fe3fb3eda2aa61123ca6f66b6
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2020-03-19 18:13:49 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-03-21 19:39:59 +0000

    media-sound/gtick: Various fixes
    
    * Fix build with -fno-common
    * Don't install duplicate desktop entry
    * Fix .desktop file
    * Install additional icons and update icons cache
    * Move AppStream metadata into /usr/share/metainfo
    * Change license to GPL3+
    
    Closes: https://bugs.gentoo.org/683436
    Closes: https://bugs.gentoo.org/709396
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/14921
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/gtick/files/gtick-0.5.4-desktop.patch  | 32 +++++++++++
 .../gtick/files/gtick-0.5.4-fno-common.patch       | 27 +++++++++
 media-sound/gtick/gtick-0.5.4-r1.ebuild            | 65 ++++++++++++++++++++++
 3 files changed, 124 insertions(+)