Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683338 - mail-filter/opendkim-2.10.3-r8/r9 : install fails because opendkim group is not created
Summary: mail-filter/opendkim-2.10.3-r8/r9 : install fails because opendkim group is n...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 688966
  Show dependency tree
 
Reported: 2019-04-14 20:02 UTC by Phil Stracchino (Unix Ronin)
Modified: 2019-07-17 09:17 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Stracchino (Unix Ronin) 2019-04-14 20:02:38 UTC
In mail-filter/opendkim-2.10.3-r8, successful installation requires that the opendkim group exists.  However, the ebuild install section simply assumes that it does exist, and does not create it if it does not already exist, causing update from older releases which do not require the opendkim group to fail.  The ebuild creates the opendkim USER, but never creates the opendkim group.

Suggested fix:

--- opendkim-2.10.3-r9.ebuild.orig      2019-03-31 17:39:32.000000000 -0400
+++ opendkim-2.10.3-r9.ebuild   2019-04-14 16:00:33.032095027 -0400
@@ -46,10 +46,11 @@

 pkg_setup() {
        # This user can read your private keys, and must therefore not be
        # shared with any other package.
        enewuser opendkim
+    enewgroup opendkim
 }

 src_prepare() {
        default


I'm not certain if this is a COMPLETE fix.  I still ended up with manual configuration to do, but it did install successfully.


emerge --info:
Portage 2.3.62 (python 3.6.5-final-0, default/linux/amd64/17.0, gcc-8.2.0, glibc-2.28-r6, 4.20.13-gentoo-minbar x86_64)
=================================================================
System uname: Linux-4.20.13-gentoo-minbar-x86_64-Intel-R-_Xeon-R-_CPU_E5620_@_2.40GHz-with-gentoo-2.6
KiB Mem:    24621888 total,   6299048 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sun, 14 Apr 2019 06:00:01 +0000
Head commit of repository gentoo: 29e18610bc4a9590b74692c0fd50df5bc8c5336e
Head commit of repository palemoon: b965198cc11049d86663a0a1e3c12bec471a2c82

sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.30 p5) 2.30.0
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.14.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.38.3-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r4::gentoo, 2.31.1-r4::gentoo
sys-devel/gcc:            8.2.0-r6::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.0-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts:

palemoon
    location: /var/db/repos/palemoon
    sync-type: git
    sync-uri: https://github.com/deu/palemoon-overlay.git
    masters: gentoo

mysql
    location: /var/lib/layman/mysql
    sync-type: laymansync
    sync-uri: https://anongit.gentoo.org/git/proj/mysql.git
    masters: gentoo
    priority: 50

gentoo-dev-alaric
    location: /var/lib/layman/alaric
    sync-type: rsync
    sync-uri: rsync://babylon5/dev-alaric
    masters: gentoo
    priority: 60
    sync-rsync-vcs-ignore: true
    sync-rsync-extra-opts:

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -mfpmath=sse -mcx16 -mpopcnt"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe -mfpmath=sse -mcx16 -mpopcnt"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y --verbose-conflicts --keep-going"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.cites.uiuc.edu/pub/gentoo                 http://gentoo.chem.wisc.edu/gentoo                 http://gentoo.osuosl.org                 http://www.gtlib.gatech.edu/pub/gentoo                 ftp://mirrors.rit.edu/gentoo                 http://mirrors.cs.wmich.edu/gentoo                 "
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en_US en"
MAKEOPTS="-j16"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl aes amd64 bash-completion berkdb bzip2 cdda cddb cli crypt cxx dri fltk fortran gdbm iconv id3tag imagemagick ipv6 ithreads jpeg2k libtirpc mmx mmxext multilib mysql ncurses nls nptl nsplugin openmp opus pam pcre qt5 readline seccomp speex sse sse2 sse4 sse4_1 sse4_2 ssl tcpd theora threads tk tools unicode utils v4l v4l2 vdpau vorbis x264 xattr xpm zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="actions alias auth_basic authn_core authn_alias authn_anon authn_dbm authn_default authn_file authz_core authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_html proxy_http rewrite setenvif socache_shmcb speling status unixd unique_id userdir vhost_alias xml2enc" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="mga" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Michael Orlitzky gentoo-dev 2019-04-16 22:15:54 UTC
I don't know why you're not getting the group, too, but you're right that I shouldn't be relying on that behavior when it's easy enough to add the enewgroup.
Comment 2 Phil Stracchino (Unix Ronin) 2019-04-16 22:18:57 UTC
(In reply to Michael Orlitzky from comment #1)
> I don't know why you're not getting the group, too, but you're right that I
> shouldn't be relying on that behavior when it's easy enough to add the
> enewgroup.

Are you relying on the default of USERGROUPS_ENAB yes?  TTurning that off is always one of the first things I do because I dislike its side effects.  I think it was a mistake on Red Hat's part in the first place.
Comment 3 Ralph Seichter 2019-04-16 22:30:19 UTC
I have added the missing enewgroup call to a pull request I opened about two hours ago.
Comment 4 Larry the Git Cow gentoo-dev 2019-04-16 22:59:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f7972686b2df35e61187a82e47566d402178c6c

commit 8f7972686b2df35e61187a82e47566d402178c6c
Author:     Ralph Seichter <github@seichter.de>
AuthorDate: 2019-04-16 20:17:14 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-04-16 22:53:46 +0000

    mail-filter/opendkim: Removed 'gnutls' support, added enewgroup
    
    Removed support for the 'gnutls' use flag. Added missing enewgroup
    statement. These modifications address the two bugs listed below.
    
    Closes: https://bugs.gentoo.org/682906
    Closes: https://bugs.gentoo.org/683338
    Signed-off-by: Ralph Seichter <gentoo@seichter.de>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 mail-filter/opendkim/opendkim-2.10.3-r10.ebuild | 227 ++++++++++++++++++++++++
 1 file changed, 227 insertions(+)
Comment 5 Michael Orlitzky gentoo-dev 2019-04-16 23:03:43 UTC
(In reply to Phil Stracchino (Unix Ronin) from comment #2)
> (In reply to Michael Orlitzky from comment #1)
> > I don't know why you're not getting the group, too, but you're right that I
> > shouldn't be relying on that behavior when it's easy enough to add the
> > enewgroup.
> 
> Are you relying on the default of USERGROUPS_ENAB yes?

Yeah, our current enewuser function uses that setting (which is a bug). We shouldn't be relying on it; it's just easy to miss because things look like they work on one machine but not another.

Anyway, Ralph just fixed it in -r10.
Comment 6 Patrice BOUVARD 2019-07-17 08:01:51 UTC
I can't believe mail-filter/opendkim-2.10.3-r8 is still the only stable version when the install process is clearly broken because of this issue.
Comment 7 Ralph Seichter 2019-07-17 09:17:31 UTC
See https://bugs.gentoo.org/688966