Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683128 - dev-lang/rust-1.34.0 version bump
Summary: dev-lang/rust-1.34.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-12 03:59 UTC by Oleg
Modified: 2019-04-13 03:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
=dev-lang/rust-1.34 (rust-1.34.0.ebuild,9.00 KB, text/plain)
2019-04-12 03:59 UTC, Oleg
Details
Fixed fix-configure-of-bundled-llvm (1.34.0-fix-configure-of-bundled-llvm.patch,1.47 KB, patch)
2019-04-12 04:01 UTC, Oleg
Details | Diff
https://github.com/rust-lang/rust/pull/58947 (1.34.0-fix-rustdoc.patch,4.27 KB, patch)
2019-04-12 04:03 UTC, Oleg
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg 2019-04-12 03:59:09 UTC
Created attachment 572540 [details]
=dev-lang/rust-1.34

https://blog.rust-lang.org/2019/04/11/Rust-1.34.0.html
Comment 1 Oleg 2019-04-12 04:01:12 UTC
Created attachment 572542 [details, diff]
Fixed fix-configure-of-bundled-llvm
Comment 3 Georgy Yakovlev archtester gentoo-dev 2019-04-12 05:02:06 UTC
I've bumped rust already without seeing this.

Also bundled llvm is 8.0.0 and I believe this is the correct version for fixing bundled llvm
https://reviews.llvm.org/D59632

I'll add this.

what is second patch about?

I need proper patches with upstream commit information, signed-off line and some explanation what it fixes, not just bare diffs.
Comment 4 Larry the Git Cow gentoo-dev 2019-04-12 05:08:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dad9246cf2dd4fc349139ceb963efe11bce75e63

commit dad9246cf2dd4fc349139ceb963efe11bce75e63
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-04-12 05:00:42 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-04-12 05:08:02 +0000

    dev-lang/rust: fix cblas headers again, don't build RISCV
    
    Bug: https://bugs.gentoo.org/676278
    Bug: https://bugs.gentoo.org/678186
    Bug: https://bugs.gentoo.org/683128
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 ...Add-additional-headers-only-if-they-exist.patch | 41 ++++++++++++++++++++++
 .../{rust-1.34.0.ebuild => rust-1.34.0-r1.ebuild}  |  3 ++
 2 files changed, 44 insertions(+)
Comment 5 Oleg 2019-04-12 05:11:02 UTC
Second patch fixes https://github.com/rust-lang/rust/issues/58587 if doc and wasm are enabled.
Comment 6 Oleg 2019-04-12 05:14:50 UTC
I've also added miri and sanitize use flags for missing features and zsh-completion as workaround for https://bugs.gentoo.org/675026
Comment 7 Georgy Yakovlev archtester gentoo-dev 2019-04-12 05:33:14 UTC
thanks for explanation, I'll look at this a bit later and add patches.
Comment 8 Georgy Yakovlev archtester gentoo-dev 2019-04-13 03:14:07 UTC
I can't reproduce doc failure with wasm+doc.

also enabling miri does not work nicely, because it complains about setting SYSROOT and -Z nightly flags on release versions.


you seem to use a lot of custom ebuilds with extra changes and different slot, maybe it's something on your system.


I'm leaving current -r1 as is in the tree and consider it bumped, but I'll keep in mind enabling miri later.