Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678186 - dev-lang/rust - Needlessly builds experimental LLVM targets
Summary: dev-lang/rust - Needlessly builds experimental LLVM targets
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-16 23:07 UTC by James Le Cuirot
Modified: 2019-04-12 05:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to set experimental-targets to empty string (rust-experimental-targets.patch,460 bytes, patch)
2019-02-16 23:07 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2019-02-16 23:07:59 UTC
Created attachment 565574 [details, diff]
Patch to set experimental-targets to empty string

I don't know when this started but at least as of 1.32.0, the experimental RISCV and WebAssembly targets are unconditionally enabled when building the bundled LLVM. You can see this from the arguments it passes to CMake. This ebuild patch prevents it.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2019-02-19 00:50:12 UTC
I'll merge your patch but this change was introduced via https://github.com/rust-lang/rust/commit/48996f9e759912140ccc98072e9e55fa6480a9d7 and https://github.com/rust-lang/rust/commit/7a5e8bdc020e2c169cd65b01e5befb66dc5a41c8
Comment 2 Larry the Git Cow gentoo-dev 2019-02-19 01:23:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2ecf54bd693ad68ed5ec85ea4d07e5ac2e65f4a

commit c2ecf54bd693ad68ed5ec85ea4d07e5ac2e65f4a
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-02-19 00:52:19 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-02-19 01:23:28 +0000

    dev-lang/rust: don't build experimental LLVM targets
    
    Reported-by: James Le Cuirot <chewi@gentoo.org>
    Closes: https://bugs.gentoo.org/678186
    Package-Manager: Portage-2.3.60, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/rust/rust-1.30.1-r1.ebuild | 1 +
 dev-lang/rust/rust-1.31.1.ebuild    | 1 +
 dev-lang/rust/rust-1.32.0.ebuild    | 1 +
 3 files changed, 3 insertions(+)
Comment 3 Dirkjan Ochtman (RETIRED) gentoo-dev 2019-02-19 09:27:57 UTC
Did anyone test these changes with the wasm USE flag enabled?
Comment 4 James Le Cuirot gentoo-dev 2019-02-19 22:44:52 UTC
(In reply to Dirkjan Ochtman from comment #3)
> Did anyone test these changes with the wasm USE flag enabled?

Unfortunately it fails:

error: Could not create LLVM TargetMachine for triple: wasm32-unknown-unknown: No available targets are compatible with triple "wasm32-unknown-unknown"

Sorry, I didn't know that wasm was WebAssembly. Easily fixed with usex though. Why is it not an LLVM_TARGETS flag like the others?
Comment 5 Larry the Git Cow gentoo-dev 2019-02-24 23:21:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74ecef85908202a33018ed9decdcf57bdd4d25d7

commit 74ecef85908202a33018ed9decdcf57bdd4d25d7
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2019-02-24 23:19:52 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-02-24 23:19:52 +0000

    dev-lang/rust: Fix wasm USE flag by restoring WebAssembly target
    
    Bug: https://bugs.gentoo.org/678186
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 dev-lang/rust/rust-1.30.1-r1.ebuild | 2 +-
 dev-lang/rust/rust-1.31.1.ebuild    | 2 +-
 dev-lang/rust/rust-1.32.0.ebuild    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2019-04-12 05:08:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dad9246cf2dd4fc349139ceb963efe11bce75e63

commit dad9246cf2dd4fc349139ceb963efe11bce75e63
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-04-12 05:00:42 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-04-12 05:08:02 +0000

    dev-lang/rust: fix cblas headers again, don't build RISCV
    
    Bug: https://bugs.gentoo.org/676278
    Bug: https://bugs.gentoo.org/678186
    Bug: https://bugs.gentoo.org/683128
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 ...Add-additional-headers-only-if-they-exist.patch | 41 ++++++++++++++++++++++
 .../{rust-1.34.0.ebuild => rust-1.34.0-r1.ebuild}  |  3 ++
 2 files changed, 44 insertions(+)