Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 682958 - media-libs/libmypaint: patches to make it compatible with gegl 0.4.x
Summary: media-libs/libmypaint: patches to make it compatible with gegl 0.4.x
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sebastian Pipping
URL: https://github.com/mypaint/libmypaint...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-09 16:36 UTC by Pacho Ramos
Modified: 2019-04-29 01:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2019-04-09 16:36:09 UTC
I have seen Fedora and Arch are applying this patches to be compatible with newer versions for this libs
https://src.fedoraproject.org/rpms/libmypaint/blob/master/f/libmypaint-1.3.0-gegl04.patch
https://src.fedoraproject.org/rpms/libmypaint/blob/master/f/libmypaint-1.3.0-sphinx18.patch

Thanks
Comment 1 Timo Ollech 2019-04-26 11:40:08 UTC
gimp-2.10.8-r1 depends on >=media-libs/libmypaint-1.3.0 which in turn needs gegl-0.3 while gimp needs >=media-libs/gegl-0.4.12:0.4[cairo]. So actually https://bugs.gentoo.org/681082 should not be closed for amd64 yet.
Comment 2 Timo Ollech 2019-04-27 18:27:31 UTC
Am I the only one getting errors building gegl-0.3?

/bin/sh ../../libtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../.. -I../../gegl -I../../gegl -I../../gegl/buffer -I../../gegl/buffer -I../../gegl/graph -I../../gegl/graph -I../../gegl/module -I../../gegl/module -I../../gegl/operation -I../../gegl/operation -I../../gegl/opencl -I../../gegl/opencl -I../../gegl/process -I../../gegl/process -I../../gegl/property-types -I../../gegl/property-types  -pthread -I/usr/include/json-glib-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/babl-0.1  -O2 -pipe -march=native -mmmx -msse -ftree-vectorize -ffast-math -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -c -o tiff_save_la-tiff-save.lo `test -f 'tiff-save.c' || echo './'`tiff-save.c
ff-save.c: In function ‘add_audio_stream’:
ff-save.c:293:17: error: ‘CODEC_FLAG_GLOBAL_HEADER’ undeclared (first use in this function); did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
     c->flags |= CODEC_FLAG_GLOBAL_HEADER;
                 ^~~~~~~~~~~~~~~~~~~~~~~~
                 AV_CODEC_FLAG_GLOBAL_HEADER
ff-save.c:293:17: note: each undeclared identifier is reported only once for each function it appears in
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../.. -I../../gegl -I../../gegl -I../../gegl/buffer -I../../gegl/buffer -I../../gegl/graph -I../../gegl/graph -I../../gegl/module -I../../gegl/module -I../../gegl/operation -I../../gegl/operation -I../../gegl/opencl -I../../gegl/opencl -I../../gegl/process -I../../gegl/process -I../../gegl/property-types -I../../gegl/property-types -pthread -I/usr/include/json-glib-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/babl-0.1 -O2 -pipe -march=native -mmmx -msse -ftree-vectorize -ffast-math -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -c tiff-save.c  -fPIC -DPIC -o .libs/tiff_save_la-tiff-save.o
ff-save.c: In function ‘add_video_stream’:
ff-save.c:634:18: error: ‘CODEC_FLAG_GLOBAL_HEADER’ undeclared (first use in this function); did you mean ‘AV_CODEC_FLAG_GLOBAL_HEADER’?
      c->flags |= CODEC_FLAG_GLOBAL_HEADER;
                  ^~~~~~~~~~~~~~~~~~~~~~~~
                  AV_CODEC_FLAG_GLOBAL_HEADER
ff-save.c: In function ‘open_video’:
ff-save.c:702:30: error: ‘AVFMT_RAWPICTURE’ undeclared (first use in this function); did you mean ‘AVFMT_NOFILE’?
   if (!(oc->oformat->flags & AVFMT_RAWPICTURE))
                              ^~~~~~~~~~~~~~~~
                              AVFMT_NOFILE
/bin/sh ../../libtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -I../.. -I../../gegl -I../../gegl -I../../gegl/buffer -I../../gegl/buffer -I../../gegl/graph -I../../gegl/graph -I../../gegl/module -I../../gegl/module -I../../gegl/operation -I../../gegl/operation -I../../gegl/opencl -I../../gegl/opencl -I../../gegl/process -I../../gegl/process -I../../gegl/property-types -I../../gegl/property-types  -pthread -I/usr/include/json-glib-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/babl-0.1 -O2 -pipe -march=native -mmmx -msse -ftree-vectorize -ffast-math -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -c -o ppm-load.lo ppm-load.c
ff-save.c: In function ‘write_video_frame’:
ff-save.c:806:28: error: ‘AVFMT_RAWPICTURE’ undeclared (first use in this function); did you mean ‘AVFMT_NOFILE’?
   if (oc->oformat->flags & AVFMT_RAWPICTURE)
                            ^~~~~~~~~~~~~~~~
                            AVFMT_NOFILE

This is media-libs/gegl-0.3.26 trying to build with media-video/ffmpeg-4.1.3.
Comment 3 Pacho Ramos gentoo-dev 2019-04-27 18:31:21 UTC
That is a different bug: open a bug for gegl-0.3 and make it block bug 653678 (ffmpeg-4 tracker)

Thanks
Comment 4 Timo Ollech 2019-04-27 18:35:36 UTC
The better alternative would be to stabilize media-libs/gegl-0.3.34, because that fixed the errors (see bug 654172).
Comment 5 Timo Ollech 2019-04-27 18:47:53 UTC
Just opened stabilization request in bug 684522.
Comment 6 Larry the Git Cow gentoo-dev 2019-04-28 18:53:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a6496a474e73efa519387bd81a9585820baec58

commit 8a6496a474e73efa519387bd81a9585820baec58
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2019-04-28 18:50:20 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2019-04-28 18:53:02 +0000

    media-libs/libmypaint: Move 1.3.0 to gegl:0.4
    
    Closes: https://bugs.gentoo.org/682958
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-2.3.65, Repoman-2.3.12

 .../files/libmypaint-1.3.0-gegl-0.4.14.patch       | 100 +++++++++++++++++++++
 media-libs/libmypaint/libmypaint-1.3.0-r2.ebuild   |  68 ++++++++++++++
 2 files changed, 168 insertions(+)
Comment 7 Ionen Wolkens gentoo-dev 2019-04-29 01:01:13 UTC
While the compatibility is nice, I'd like to remind that GIMP actually doesn't need libmypaint to be built with gegl support (the USE flag was removed from GIMP dependencies a while back because of this).

I'm not entirely sure what even needs this at all. At the very least, I see no reason for the gegl USE flag to be a default. I turned it off myself just to avoid the 0.3 dependencies as it was entirely useless either way (and I do use GIMP without issues).