Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678888 - app-admin/sudo: add USE=libressl
Summary: app-admin/sudo: add USE=libressl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: libressl-support
  Show dependency tree
 
Reported: 2019-02-27 02:35 UTC by Stefan Strogin
Modified: 2019-03-03 02:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Strogin gentoo-dev 2019-02-27 02:35:09 UTC
Can we add "libressl" flag for LibreSSL support?

app-admin/sudo compiles fine with LibreSSL without any patches, so we need only the USE flag, for example:

    gcrypt? ( dev-libs/libgcrypt:= )
    libressl? ( dev-libs/libressl:0= )
    openssl? ( dev-libs/openssl:0= )

REQUIRED_USE="?? ( gcrypt libressl openssl )"

it's not very similar to examples in https://wiki.gentoo.org/wiki/Project:LibreSSL
But I think adding USE=ssl would be inappropriate and confusing as sudo really doesn't establish SSL/TLS connections (AFAIK).
Comment 1 Anthony Basile gentoo-dev 2019-02-27 13:23:03 UTC
(In reply to Stefan Strogin from comment #0)
> Can we add "libressl" flag for LibreSSL support?
> 
> app-admin/sudo compiles fine with LibreSSL without any patches, so we need
> only the USE flag, for example:
> 
>     gcrypt? ( dev-libs/libgcrypt:= )
>     libressl? ( dev-libs/libressl:0= )
>     openssl? ( dev-libs/openssl:0= )
> 
> REQUIRED_USE="?? ( gcrypt libressl openssl )"
> 
> it's not very similar to examples in
> https://wiki.gentoo.org/wiki/Project:LibreSSL
> But I think adding USE=ssl would be inappropriate and confusing as sudo
> really doesn't establish SSL/TLS connections (AFAIK).

This looks good to me and I agree with the logic.
Comment 2 Larry the Git Cow gentoo-dev 2019-03-02 17:49:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=163afe017bcc932e043a5422af897e5073df37da

commit 163afe017bcc932e043a5422af897e5073df37da
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2019-02-27 03:35:45 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-02 17:46:04 +0000

    app-admin/sudo: add USE=system-digest & USE=libressl
    
    Add system-digest USE flag for building with support of using message
    digest functions from libgcrypt, LibreSSL or OpenSSL, depending on
    USE gcrypt or libressl, instead of sudo's own implementation.
    
    Minor amend of USE flag descriptions as per descriptions from sudo's
    configure.ac and ChangeLog.
    
    Closes: https://bugs.gentoo.org/678888
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11168
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 app-admin/sudo/metadata.xml          |  9 +++++++--
 app-admin/sudo/sudo-1.8.27-r1.ebuild | 20 +++++++++++++++-----
 2 files changed, 22 insertions(+), 7 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-03-03 02:36:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/libressl.git/commit/?id=03d06c7ba9388d0eb030e711f7b350419f2c6b85

commit 03d06c7ba9388d0eb030e711f7b350419f2c6b85
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2019-03-03 02:35:00 +0000
Commit:     Stefan Strogin <stefan.strogin@gmail.com>
CommitDate: 2019-03-03 02:35:00 +0000

    app-admin/sudo: drop; fixed in gentoo.git
    
    Bug: https://bugs.gentoo.org/678888
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>

 app-admin/sudo/Manifest                 |   2 -
 app-admin/sudo/metadata.xml             |  24 ----
 app-admin/sudo/sudo-1.8.23-r1.ebuild    | 234 ------------------------------
 app-admin/sudo/sudo-1.8.23.ebuild       | 227 -----------------------------
 app-admin/sudo/sudo-1.8.25_p1-r1.ebuild | 245 --------------------------------
 5 files changed, 732 deletions(-)