Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675318 - =media-libs/vidstab-1.1.0-r1: error: unrecognized command line option «-msse2»; did you mean «-misel»?
Summary: =media-libs/vidstab-1.1.0-r1: error: unrecognized command line option «-msse2...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Kalin KOZHUHAROV
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 675190
  Show dependency tree
 
Reported: 2019-01-13 10:36 UTC by Sergei Trofimovich (RETIRED)
Modified: 2019-01-14 16:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
=media-libs:vidstab-1.1.0-r1.FAIL (=media-libs:vidstab-1.1.0-r1.FAIL,36.00 KB, text/plain)
2019-01-13 10:36 UTC, Sergei Trofimovich (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-13 10:36:49 UTC
Created attachment 560830 [details]
=media-libs:vidstab-1.1.0-r1.FAIL

Looks like FEATURES=test tries to pass x86-specidic flag during compilation:

[1/17] /usr/bin/powerpc64-unknown-linux-gnu-gcc -DDISABLE_ORC -DTESTING -DUSE_OMP -DUSE_SSE2 -I/dev/shm/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/tests/../src  -DNDEBUG -O2 -pipe -fdiagnostics-show-option -frecord-gcc-switches   -Wall -O0 -Wno-pointer-sign -std=gnu99 -msse2 -ffast-math -fno-show-column -fopenmp -MD -MT CMakeFiles/tests.dir/tests.c.o -MF CMakeFiles/tests.dir/tests.c.o.d -o CMakeFiles/tests.dir/tests.c.o -c /dev/shm/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/tests/tests.c
/usr/bin/powerpc64-unknown-linux-gnu-gcc -DDISABLE_ORC -DTESTING -DUSE_OMP -DUSE_SSE2 -I/dev/shm/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/tests/../src  -DNDEBUG -O2 -pipe -fdiagnostics-show-option -frecord-gcc-switches   -Wall -O0 -Wno-pointer-sign -std=gnu99 -msse2 -ffast-math -fno-show-column -fopenmp -MD -MT CMakeFiles/tests.dir/tests.c.o -MF CMakeFiles/tests.dir/tests.c.o.d -o CMakeFiles/tests.dir/tests.c.o -c /dev/shm/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/tests/tests.c
powerpc64-unknown-linux-gnu-gcc: ошибка: unrecognized command line option «-msse2»; did you mean «-misel»?

Happens at least on powerpc and ia64.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-13 10:38:20 UTC
emerge --info

Portage 2.3.53 (python 3.6.6-final-0, default/linux/powerpc/ppc64/17.0/64bit-userland/desktop/gnome/systemd, gcc-8.2.0, glibc-2.28-r4, 4.9.16-gentoo ppc64)
=================================================================
System uname: Linux-4.9.16-gentoo-ppc64-POWER8_-architected-,_altivec_supported-with-gentoo-2.6
KiB Mem:    24805420 total,   3309920 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sat, 12 Jan 2019 08:30:01 +0000
Head commit of repository gentoo: 7315bbbfcc4c0aecc2aa9d92818bd7eedb607569
sh bash 4.4_p23
ld GNU ld (Gentoo 2.30 p3) 2.30.0
app-shells/bash:          4.4_p23::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.6::gentoo, 3.7.0::gentoo
dev-util/cmake:           3.13.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.14::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.15.1-r1::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r3::gentoo, 2.31.1-r3::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo, 8.2.0-r6::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.20::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r4::gentoo
Repositories:

gentoo
    location: /bound/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="ppc64 ~ppc64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="powerpc64-unknown-linux-gnu"
CFLAGS="-O2 -pipe -fdiagnostics-show-option -frecord-gcc-switches"
CHOST="powerpc64-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/bound/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict stricter test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="ru_RU.UTF-8"
LC_ALL=""
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j13 -l12"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/dev/shm"
USE="X a52 aac acl alsa berkdb big-endian bluetooth branding bzip2 cairo cdda cdr cli client colord corefonts crypt cups cxx dbus dri dts dvd dvdr eds emboss encode evo exif fam flac fortran gdbm gif glamor gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk http2 ibm iconv icu introspection ipv6 jpeg lcms ldap libnotify libsecret mad mng mp3 mp4 mpeg nautilus ncurses nls nptl ogg opengl openmp pam pango pcre pcre16 pdf playlist png policykit ppc64 ppds pulseaudio python qt5 readline sdl seccomp sound spell sqlite ssl startup-notification svg systemd tcpd test text tiff tracker truetype udev udisks unicode upower usb vala vorbis wxwidgets x264 xattr xcb xkb xml xv xvfb xvid zlib" ABI_PPC="64" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="fbdev mga nv r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-13 10:45:32 UTC
Probably comes from unconditional addition at:

    tests/CMakeLists.txt:add_definitions( -DUSE_SSE2 -msse2 -ffast-math -fno-show-column ) # -DUSE_SSE2_ASM

and at

    transcode/CMakeLists.txt:add_definitions( -DUSE_SSE2 -msse2 -ffast-math )

On the ebuild side it's surprising to see src_test() to rerun configure and make phases:

    multilib_src_test() {
        local mycmakeargs=(
                -DUSE_OMP="$(usex openmp)"
        )
        local CMAKE_USE_DIR="${CMAKE_USE_DIR}/tests"
        local BUILD_DIR="${BUILD_DIR}/tests"
        cmake-utils_src_configure
        cmake-utils_src_make
        "${BUILD_DIR}"/tests || die
    }

Was it done to workaround something? It needs at least a comment to explain why 'cmake-utils_src_test' was not enough.
Comment 3 Craig Andrews gentoo-dev 2019-01-14 15:29:13 UTC
(In reply to Sergei Trofimovich from comment #2)
> Probably comes from unconditional addition at:
> 
>     tests/CMakeLists.txt:add_definitions( -DUSE_SSE2 -msse2 -ffast-math
> -fno-show-column ) # -DUSE_SSE2_ASM
> 
> and at
> 
>     transcode/CMakeLists.txt:add_definitions( -DUSE_SSE2 -msse2 -ffast-math )
> 
> On the ebuild side it's surprising to see src_test() to rerun configure and
> make phases:
> 
>     multilib_src_test() {
>         local mycmakeargs=(
>                 -DUSE_OMP="$(usex openmp)"
>         )
>         local CMAKE_USE_DIR="${CMAKE_USE_DIR}/tests"
>         local BUILD_DIR="${BUILD_DIR}/tests"
>         cmake-utils_src_configure
>         cmake-utils_src_make
>         "${BUILD_DIR}"/tests || die
>     }
> 
> Was it done to workaround something? It needs at least a comment to explain
> why 'cmake-utils_src_test' was not enough.

Note that CMAKE_USE_DIR and BUILD_DIR are being set - we need to run configure and make in the "tests" directory. So configure and make are not being rerun - they're being run for the first time from the tests directory. I thought that was pretty self explanatory.

'cmake-utils_src_test' uses ctest to run the tests which is not what vidstab uses (vidstab has its own home-grown thing), hence 'cmake-utils_src_test' cannot be used.

If there's a better way to do this, please let me know - I'm always eager to improve things :)
Comment 4 Larry the Git Cow gentoo-dev 2019-01-14 16:15:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3a19c8172c6e0b736ea746132956aa5dddc18d1b

commit 3a19c8172c6e0b736ea746132956aa5dddc18d1b
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2019-01-14 16:14:57 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-01-14 16:15:13 +0000

    media-libs/vidstab: For tests, use sse2 only if it is available
    
    Reported upstream at https://github.com/georgmartius/vid.stab/pull/70
    
    Closes: https://bugs.gentoo.org/675318
    Package-Manager: Portage-2.3.55, Repoman-2.3.12
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 ...ab-1.1.0-tests-use-sse2-only-if-available.patch | 33 ++++++++++++++++++++++
 media-libs/vidstab/vidstab-1.1.0-r1.ebuild         |  9 ++++--
 media-libs/vidstab/vidstab-9999.ebuild             |  9 +++---
 3 files changed, 44 insertions(+), 7 deletions(-)