Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675190 - media-libs/vidstab-1.1.0-r1: add ~alpha ~arm ~arm64 ~ia64 ~ppc ~ppc64 ~mips
Summary: media-libs/vidstab-1.1.0-r1: add ~alpha ~arm ~arm64 ~ia64 ~ppc ~ppc64 ~mips
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords: CC-ARCHES, KEYWORDREQ
Depends on: 675318
Blocks: 517890
  Show dependency tree
 
Reported: 2019-01-11 16:22 UTC by Craig Andrews
Modified: 2020-04-30 08:46 UTC (History)
3 users (show)

See Also:
Package list:
media-libs/vidstab-1.1.0-r2 ~alpha ~arm ~arm64 ~ia64 ~ppc ~ppc64 ~mips
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Andrews gentoo-dev 2019-01-11 16:22:07 UTC
Please add keywords for media-libs/vidstab-1.1.0-r1
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-13 10:39:26 UTC
test suite passes unportable -msse2 flag unconditionally: bug #675318
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-17 08:00:12 UTC
~ia64 keyworded
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-17 23:21:14 UTC
~ppc keyworded
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2019-01-21 23:42:58 UTC
~ppc64 keyworded
Comment 5 Craig Andrews gentoo-dev 2019-02-11 17:46:59 UTC
Ping alpha, arm, arm64, mips arches - can you please keyword?
Comment 6 Tobias Klausmann gentoo-dev 2019-02-12 09:45:18 UTC
This should have a use-dependency between USE=test and USE=openmp, otherwise tests will fail (will not stop Alpha from keywording):

[17/17] : && /usr/bin/alpha-unknown-linux-gnu-gcc -mieee -pipe -O2 -mcpu=ev67  -Wl,-O1 -Wl,--as-needed   -rdynamic CMakeFiles/tests.dir/tests.c.o CMakeFiles/tests.dir/testutils.c.o CMakeFiles/tests.dir/testframework.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1
.1.0/src/vsvector.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab
-1.1.0/src/transform.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.s
tab-1.1.0/src/transformfloat.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/wo
rk/vid.stab-1.1.0/src/transformfixedpoint.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidsta
b-1.1.0-r1/work/vid.stab-1.1.0/src/libvidstab.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vi
dstab-1.1.0-r1/work/vid.stab-1.1.0/src/transformtype.c.o CMakeFiles/tests.dir/var/tmp/portage/media-
libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/frameinfo.c.o CMakeFiles/tests.dir/var/tmp/portage/med
ia-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/serialize.c.o CMakeFiles/tests.dir/var/tmp/portage/
media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/localmotion2transform.c.o CMakeFiles/tests.dir/v
ar/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/motiondetect.c.o CMakeFiles/tests
.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/motiondetect_opt.c.o CMakeF
iles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/orc/motiondetecto
rc.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/boxb
lur.c.o  -o tests  -lm && :
FAILED: tests                                                                                      
: && /usr/bin/alpha-unknown-linux-gnu-gcc -mieee -pipe -O2 -mcpu=ev67  -Wl,-O1 -Wl,--as-needed   -rd
ynamic CMakeFiles/tests.dir/tests.c.o CMakeFiles/tests.dir/testutils.c.o CMakeFiles/tests.dir/testfr
amework.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src
/vsvector.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/s
rc/transform.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.
0/src/transformfloat.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.s
tab-1.1.0/src/transformfixedpoint.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-
r1/work/vid.stab-1.1.0/src/libvidstab.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.
1.0-r1/work/vid.stab-1.1.0/src/transformtype.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/vid
stab-1.1.0-r1/work/vid.stab-1.1.0/src/frameinfo.c.o CMakeFiles/tests.dir/var/tmp/portage/media-libs/
vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/serialize.c.o CMakeFiles/tests.dir/var/tmp/portage/media-li
bs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/localmotion2transform.c.o CMakeFiles/tests.dir/var/tmp/p
ortage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/motiondetect.c.o CMakeFiles/tests.dir/var
/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/motiondetect_opt.c.o CMakeFiles/tes
ts.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/orc/motiondetectorc.c.o C
MakeFiles/tests.dir/var/tmp/portage/media-libs/vidstab-1.1.0-r1/work/vid.stab-1.1.0/src/boxblur.c.o 
 -o tests  -lm && :                                                                                
CMakeFiles/tests.dir/tests.c.o: In function `test_motionDetect':                                    
(.text+0x27fc): undefined reference to `omp_set_dynamic'
collect2: error: ld returned 1 exit status                              
ninja: build stopped: subcommand failed.
Comment 7 Larry the Git Cow gentoo-dev 2019-02-12 09:49:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32875c5ca269e5fbc72fe5ecc4774eec4eb4dd93

commit 32875c5ca269e5fbc72fe5ecc4774eec4eb4dd93
Author:     Tobias Klausmann <klausman@gentoo.org>
AuthorDate: 2019-02-12 09:49:18 +0000
Commit:     Tobias Klausmann <klausman@gentoo.org>
CommitDate: 2019-02-12 09:49:31 +0000

    media-libs/vidstab-1.1.0-r1: add ~alpha keyword
    
    Bug: http://bugs.gentoo.org/675190
    Signed-off-by: Tobias Klausmann <klausman@gentoo.org>

 media-libs/vidstab/vidstab-1.1.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Craig Andrews gentoo-dev 2019-02-12 21:45:04 UTC
(In reply to Tobias Klausmann from comment #6)
> This should have a use-dependency between USE=test and USE=openmp, otherwise
> tests will fail (will not stop Alpha from keywording):
> 
Thanks for reporting that! Reported upstream at https://github.com/georgmartius/vid.stab/pull/72 and fixed in Gentoo: https://github.com/gentoo/gentoo/commit/71f514f4e7d513bf456b613649ce4e19879d21db
Comment 9 Georgy Yakovlev gentoo-dev 2019-02-18 04:04:42 UTC
built and tested on arm and arm64 (real hw)

caught this

-- Checking for module 'orc-0.4'
--   Package 'orc-0.4', required by 'virtual:world', not found
-- Could NOT find LibOrc (missing: ORC_LIBRARY ORC_INCLUDE_DIR)

is it expected?
Comment 10 Georgy Yakovlev gentoo-dev 2019-02-18 05:12:43 UTC
looks like it's a bug in tests

root cmakefile contains this comment
### ORC is not used in any active code at the moment  ###
# I tried it with 0.4.14
#  0.4.10 did not work (not all opcode implemented)
# find_package(Orc)
if(ORC_FOUND)


yet the tests contain
find_package(Orc)
if(ORC_FOUND)
add_definitions( -DUSE_ORC ${ORC_DEFINITIONS})
include_directories( ${ORC_INCLUDE_DIRS} )
else()
add_definitions( -DDISABLE_ORC)
endif()
....snip
if(ORC_FOUND)
target_link_libraries(tests ${ORC_LIBRARIES})
endif()
Comment 11 Larry the Git Cow gentoo-dev 2019-02-18 07:58:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ea333a4383745b9c15255f17d08f9f96265b73e

commit 1ea333a4383745b9c15255f17d08f9f96265b73e
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-02-18 05:16:51 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-02-18 07:57:49 +0000

    media-libs/vidstab: keyword on ~arm64
    
    Bug: https://bugs.gentoo.org/675190
    Package-Manager: Portage-2.3.60, Repoman-2.3.12
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 media-libs/vidstab/vidstab-1.1.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 12 Georgy Yakovlev gentoo-dev 2019-02-18 08:07:05 UTC
after speaking with leio on IRC I've added arm64.

can't commit arm without arch ack.
Comment 13 Mart Raudsepp gentoo-dev 2019-02-18 08:33:33 UTC
Just p.use.mask what's needed for mips...
Comment 14 Sergei Trofimovich (RETIRED) gentoo-dev 2019-03-24 21:28:25 UTC
commit 644928c637f8b60929ac6b2742329069f98bc7e6
Author: Markus Meier <maekke@gentoo.org>
Date:   Tue Feb 19 22:14:48 2019 +0100

    media-libs/vidstab: add ~arm, bug #675190