Bug 672290 – media-video/vlc-3.0.4 USE=fdk - codec/fdkaac.c:291:34: error: ‘AACENC_InfoStruct’ {aka ‘struct <anonymous>’} has no member named ‘encoderDelay’; did you mean ‘nDelay’?

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Leonid Kopylov 2018-11-30 11:05:00 UTC]

# emerge -pqv '=media-video/vlc-3.0.4::gentoo'
[ebuild   R   ] media-video/vlc-3.0.4  USE="X a52 alsa dbus dts dvbpsi dvd encode fdk* ffmpeg flac fontconfig gcrypt gnome-keyring gstreamer jpeg libnotify libsamplerate mp3 mpeg musepack ncurses ogg png postproc pulseaudio qt5 samba ssl svg truetype udev vorbis wayland x264 xml (-altivec) -aom -archive -aribsub -bidi -bluray -cddb -chromaprint -chromecast -dc1394 -debug (-directx) -faad -fluidsynth -gme -ieee1394 -jack -kate -libass -libav -libcaca -libtar -libtiger -linsys -lirc -live -lua -macosx-notifications (-macosx-qtkit) -matroska -modplug -mtp (-neon) -nfs -omxil -opencv -optimisememory -opus -projectm -rdp -run-as-root -sdl-image -sftp -shout -sid -skins -soxr -speex -srt -taglib -test -theora -tremor -twolame -upnp -v4l -vaapi -vdpau -vnc -vpx -wma-fixed -x265 -zeroconf -zvbi" CPU_FLAGS_X86="mmx sse"

# emerge --info '=media-video/vlc-3.0.4::gentoo'
Portage 2.3.52 (python 3.6.6-final-0, default/linux/amd64/17.1/desktop/gnome/systemd, gcc-8.2.0, glibc-2.28-r2, 4.19.5-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.19.5-gentoo-x86_64-Intel-R-_Core-TM-_i7-6700_CPU_@_3.40GHz-with-gentoo-2.6
KiB Mem:     8170548 total,   6043516 free
KiB Swap:    4194300 total,   4194300 free
Timestamp of repository gentoo: Fri, 30 Nov 2018 09:30:01 +0000
Head commit of repository gentoo: 2bb88dac1aea74d1927e1fd45b6592d575eb837d
sh bash 4.4_p23
ld GNU ld (Gentoo 2.31.1 p3) 2.31.1
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.6::gentoo, 3.7.0::gentoo
dev-util/cmake:           3.13.1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r1::gentoo
sys-devel/gcc:            8.2.0-r4::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts:
    sync-rsync-verify-max-age: 24

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA FraunhoferFDK google-chrome PUEL RAR Nero-EULA-US OPERA-2014 skype-4.0.0.7-copyright TeamViewer"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.isoc.org.il/pub/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en he ru en_US he_IL ru_RU"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac accessibility acl acpi alsa amd64 anacron berkdb bluetooth branding bzip2 cairo cdda cdio cdr cli client colord crypt cryptsetup cups curl cxx dbus device-mapper doc dos dot drawing dri dts dvd dvdr eds emboss encode evo examples exif experimental fam fdk flac fontconfig fortran gd gdbm geoip gif glamor gles gnome gnome-keyring gnome-online-accounts go googledrive gpg gpm gssapi gstreamer gtk gui haptic html http iconv icu idn introspection ipv6 iscsi itunes jadetex java jpeg jpeg2k kerberos lastfm latex lcms ldap libkms libnotify libsecret libtirpc logrotate mad math mbox mdadm minizip mng mount mp3 mp4 mpd mpeg mpx multilib multimon musepack mysql mysqli nautilus ncurses ndiff networkmanager nls nptl nscd offensive ogg openexr opengl openmp pam pango pcap pcre pdf pdfimport perl png policykit postgres postproc ppds pulseaudio python qrcode qt5 raw readline samba sasl sdl seccomp slp smi spell sqlite sshdump ssl startup-notification svg symlink sync-plugin-portage systemd tcpd tfshark threads tiff tk tools tracker truetype udev udisks unicode upower usb usbredir vala vlc vorbis wayland webkit wifi winbind wininst wxwidgets x264 xa xattr xcb xetex xinerama xkb xml xv xvfb xvid zenmap zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev" KERNEL="linux" L10N="en en-US he ru" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver scripting-beanshell wiki-publisher scripting-javascript" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby23 ruby24" USERLAND="GNU" VIDEO_CARDS="vmware" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

media-video/vlc-3.0.4::gentoo was built with the following:
USE="X a52 alsa dbus dts dvbpsi dvd encode ffmpeg flac fontconfig gcrypt gnome-keyring gstreamer jpeg libnotify libsamplerate mp3 mpeg musepack ncurses ogg png postproc pulseaudio qt5 samba ssl svg truetype udev vorbis wayland x264 xml (-altivec) -aom -archive -aribsub -bidi -bluray -cddb -chromaprint -chromecast -dc1394 -debug (-directx) -faad -fdk -fluidsynth -gme -ieee1394 -jack -kate -libass -libav -libcaca -libtar -libtiger -linsys -lirc -live -lua -macosx-notifications (-macosx-qtkit) -matroska -modplug -mtp (-neon) -nfs -omxil -opencv -optimisememory -opus -projectm -rdp -run-as-root -sdl-image -sftp -shout -sid -skins -soxr -speex -srt -taglib -test -theora -tremor -twolame -upnp -v4l -vaapi -vdpau -vnc -vpx -wma-fixed -x265 -zeroconf -zvbi" ABI_X86="(64)" CPU_FLAGS_X86="mmx sse"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer -std=c++11"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -L/usr/lib64/sidplay/builders/"

[Comment 1 Leonid Kopylov 2018-11-30 11:05:35 UTC]

Created attachment 556770 [details]
build.log

[Comment 2 Chris Smith 2018-11-30 14:31:42 UTC]

This is a problem after upgrade to media-libs/fdk-aac-2.0.0 which changes the ABI (for one, encoderDelay was changed to nDelay).

[Comment 3 Klaus Kusche 2018-12-02 10:57:10 UTC]

Same here.

[Comment 4 Luke A. Guest 2018-12-03 07:39:00 UTC]

Confirmed here too.

[Comment 5 Luke A. Guest 2018-12-03 07:55:52 UTC]

(In reply to Luke A. Guest from comment #4)
> Confirmed here too.

https://github.com/mstorsjo/fdk-aac/issues/93

[Comment 6 Luke A. Guest 2018-12-03 08:03:18 UTC]

Created attachment 556986 [details, diff]
Fixes tis error.

[Comment 7 Attila Tóth 2018-12-04 21:47:03 UTC]

(In reply to Luke A. Guest from comment #6)
> Created attachment 556986 [details, diff] [details, diff]
> Fixes tis error.

Patch works for me. Thanks!

[Comment 8 Chris Smith 2018-12-07 00:03:49 UTC]

Is the patch not good enough to be added to the tree? Is there something else we're waiting for?

[Comment 9 Adrian Bassett 2018-12-07 08:51:16 UTC]

(In reply to Chris Smith from comment #8)
> Is the patch not good enough to be added to the tree? Is there something
> else we're waiting for?

It works for me.  If you don't want to wait you can copy the patch to /etc/portage/patches/media-video/vlc/0001-Fix-FDKAAC-AACENC_InfoStruct-member-name-change-from.patch where the vlc ebuild will pick it up automatically.

[Comment 10 Ștefan Talpalaru 2018-12-08 18:30:30 UTC]

A fixed vlc-3.0.4-r1 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay

[Comment 11 Andreas Sturmlechner 2018-12-09 10:53:52 UTC]

(In reply to Luke A. Guest from comment #6)
> Created attachment 556986 [details, diff] [details, diff]
> Fixes tis error.

Did you submit this patch upstream for review? It is not in vlc.git master yet. Can we track an upstream bug number?

[Comment 12 devsk 2018-12-10 23:03:06 UTC]

Looking at the diff, I wonder what was the pressing need to change the field name and break stuff all over? This is bad development model and reviewer did not do his/her job.

[Comment 13 Lars Wendler (Polynomial-C) (RETIRED) 2019-01-11 09:58:58 UTC]

vlc-3.0.6 (didn't test 3.0.5) builds against media-libs/fdk-aac-2.0.0 without any patch being required...

[Comment 14 Lars Wendler (Polynomial-C) (RETIRED) 2019-01-11 10:03:15 UTC]

(In reply to Lars Wendler (Polynomial-C) from comment #13)
> vlc-3.0.6 (didn't test 3.0.5) builds against media-libs/fdk-aac-2.0.0
> without any patch being required...

Err, no, I was wrong. Sorry, I checked trhe buidl with USE="-fdk" (I thought I had that added to my package.use file but I didn't). So the bug still isn't fixed by upstream...

[Comment 15 Larry the Git Cow 2019-01-13 00:13:04 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=690c91858babd424e44e9ccf938e74f73fb85e94

commit 690c91858babd424e44e9ccf938e74f73fb85e94
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2019-01-12 23:48:32 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2019-01-13 00:12:42 +0000

    media-video/vlc: Restrict to <media-libs/fdk-aac-2.0.0
    
    Bug: https://bugs.gentoo.org/672290
    Package-Manager: Portage-2.3.55, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-video/vlc/vlc-3.0.6.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Comment 16 jospezial 2019-02-23 23:17:28 UTC]

https://git.videolan.org/?p=vlc.git;a=commit;h=6ea9b13fe82fae2b25b7371c6c36d6296db28ccb

"Fix building vlc with libfdk-aac v2

When flushing the encoder, we now need to provide non-null buffer
parameters for everything, even if they are unused.

The encoderDelay parameter has been replaced by two, nDelay and
nDelayCore."

[Comment 17 Larry the Git Cow 2019-02-24 18:01:43 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=315cd1cf34c962f988d7a7806a0e9843da0ff77e

commit 315cd1cf34c962f988d7a7806a0e9843da0ff77e
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2019-02-24 17:22:27 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2019-02-24 18:01:24 +0000

    media-video/vlc: Fix build with libvpx-1.8.0, fdk-aac-2.0.0
    
    Thanks-to: jospezial <[e-mail]>
    Bug: https://bugs.gentoo.org/677606
    Bug: https://bugs.gentoo.org/672290
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../vlc/files/vlc-3.0.6-fdk-aac-2.0.0.patch        |  84 ++++
 media-video/vlc/files/vlc-3.0.6-libvpx-1.8.0.patch |  35 ++
 media-video/vlc/vlc-3.0.6-r1.ebuild                | 501 +++++++++++++++++++++
 3 files changed, 620 insertions(+)

[Comment 18 Larry the Git Cow 2019-03-16 22:42:13 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e542b54bceb8e672006a4af535bcd3f91ab19b07

commit e542b54bceb8e672006a4af535bcd3f91ab19b07
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2019-03-16 21:32:31 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2019-03-16 22:41:42 +0000

    media-video/vlc: Drop 3.0.4
    
    Closes: https://bugs.gentoo.org/672290
    Closes: https://bugs.gentoo.org/677606
    Closes: https://bugs.gentoo.org/669924
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-video/vlc/Manifest         |   1 -
 media-video/vlc/vlc-3.0.4.ebuild | 490 ---------------------------------------
 2 files changed, 491 deletions(-)