Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669924 - media-video/vlc-3.0.4 automagic to media-sound/mpg123
Summary: media-video/vlc-3.0.4 automagic to media-sound/mpg123
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on: 678702
Blocks:
  Show dependency tree
 
Reported: 2018-10-29 16:08 UTC by Denis Kaganovich
Modified: 2019-03-16 22:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
vlc-mpg123-noauto.patch: USE=mpg123 vs auto (vlc-mpg123-noauto.patch,1.38 KB, patch)
2018-10-29 16:08 UTC, Denis Kaganovich
Details | Diff
vlc-mp3-select.patch: mp3 USE->REQUIRED_USE (vlc-mp3-select.patch,1.75 KB, patch)
2018-10-29 18:38 UTC, Denis Kaganovich
Details | Diff
vlc-mp3-select1.patch: (fixed) mp3 USE->REQUIRED_USE (vlc-mp3-select1.patch,1.82 KB, patch)
2018-10-29 18:44 UTC, Denis Kaganovich
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Kaganovich 2018-10-29 16:08:59 UTC
Created attachment 553608 [details, diff]
vlc-mpg123-noauto.patch: USE=mpg123 vs auto

media-video/vlc-3.0.4 automagic to media-sound/mpg123, trivial solveable by $(use_enable mpg123). Patch for new useflag "mpg123" attached.

And more: this is default mp3 codec if exists, so I get unmotivated distortion from miscompiled mpg123 (graphite + sse).

Simple test: vlc -l|grep mpg123
Comment 1 Denis Kaganovich 2018-10-29 18:38:37 UTC
Created attachment 553654 [details, diff]
vlc-mp3-select.patch: mp3 USE->REQUIRED_USE

Even better: move "mp3" to REQUIRED_USE, as mp3 decoder is ffmpeg too (just without USE=mp3 - this is for lame encoder). I add untested by me libav, this is same with ffmpeg as fork. So there are 4 real flags for single mp3.
Comment 2 Denis Kaganovich 2018-10-29 18:44:28 UTC
Created attachment 553656 [details, diff]
vlc-mp3-select1.patch: (fixed) mp3 USE->REQUIRED_USE

sorry, one error fixed
Comment 3 Larry the Git Cow gentoo-dev 2018-10-30 12:49:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6c71d4dcc4c322e7b0b333d60106296aaea808e

commit d6c71d4dcc4c322e7b0b333d60106296aaea808e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-10-30 12:43:22 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-10-30 12:48:50 +0000

    media-video/vlc: Add USE mad, switch USE mp3 to media-sound/mpg123
    
    Reported-by: Denis Kaganovich <mahatma@eu.by>
    Bug: https://bugs.gentoo.org/669924
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 media-video/vlc/vlc-3.0.9999.ebuild | 14 ++++++++------
 media-video/vlc/vlc-9999.ebuild     | 14 ++++++++------
 2 files changed, 16 insertions(+), 12 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2019-01-13 00:13:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56bb745a7dfdf4bdbf340164f7bdca573e921b0f

commit 56bb745a7dfdf4bdbf340164f7bdca573e921b0f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-01-12 23:42:08 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-01-13 00:12:41 +0000

    media-video/vlc: 3.0.6 version bump, add USE 10bit,dav1d
    
    Fix media-sound/mpg123 automagic
    
    Bug: https://bugs.gentoo.org/669924
    Closes: https://bugs.gentoo.org/675056
    Package-Manager: Portage-2.3.55, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-video/vlc/Manifest            |   1 +
 media-video/vlc/metadata.xml        |   2 +
 media-video/vlc/vlc-3.0.6.ebuild    | 502 ++++++++++++++++++++++++++++++++++++
 media-video/vlc/vlc-3.0.9999.ebuild |  19 +-
 media-video/vlc/vlc-9999.ebuild     |  19 +-
 5 files changed, 531 insertions(+), 12 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2019-03-16 22:42:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e542b54bceb8e672006a4af535bcd3f91ab19b07

commit e542b54bceb8e672006a4af535bcd3f91ab19b07
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-03-16 21:32:31 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-03-16 22:41:42 +0000

    media-video/vlc: Drop 3.0.4
    
    Closes: https://bugs.gentoo.org/672290
    Closes: https://bugs.gentoo.org/677606
    Closes: https://bugs.gentoo.org/669924
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-video/vlc/Manifest         |   1 -
 media-video/vlc/vlc-3.0.4.ebuild | 490 ---------------------------------------
 2 files changed, 491 deletions(-)