Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666798 - net-misc/owncloud-client needs dependency on gnome-base/libgnome-keyring
Summary: net-misc/owncloud-client needs dependency on gnome-base/libgnome-keyring
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-23 09:08 UTC by haarp
Modified: 2020-02-04 11:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description haarp 2018-09-23 09:08:46 UTC
In order to store passwords, libgnome-keyring is needed. It will work without, but not store passwords. I propose an useflag.

also see https://github.com/owncloud/client/issues/6500
Comment 1 Bernard Cafarelli gentoo-dev 2020-02-03 09:59:42 UTC
Sounds like the perfect definition for a pure runtime dependency, will add in upcoming bump
Comment 2 Larry the Git Cow gentoo-dev 2020-02-03 10:16:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bff6586b9943bea7f60c54dedcfa8fc4e34d4460

commit bff6586b9943bea7f60c54dedcfa8fc4e34d4460
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2020-02-03 10:11:46 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2020-02-03 10:11:57 +0000

    net-misc/owncloud-client: 2.6.1 version bump
    
    Drop shibboleth USE-flag, it was completely dropped upstream
    Add optional gnome-keyring runtime dependency
    Fix USE=test build option
    Use xdg eclass for icon cache update
    
    Closes: https://bugs.gentoo.org/666798
    Closes: https://bugs.gentoo.org/706594
    Package-Manager: Portage-2.3.87, Repoman-2.3.20
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 net-misc/owncloud-client/Manifest                  |  1 +
 .../owncloud-client-2.6.1.13407.ebuild             | 84 ++++++++++++++++++++++
 2 files changed, 85 insertions(+)
Comment 3 haarp 2020-02-03 12:04:55 UTC
@ Bernard Cafarelli

Thanks for adding the useflag. However you made it depend on gnome-base/gnome-keyring, but the required package is gnome-base/libgnome-keyring
Comment 4 Bernard Cafarelli gentoo-dev 2020-02-03 20:30:24 UTC
Thanks for checking!
Hmm that is strange, the code does not contain anything related to libgnome-keyring (and gnome-keyring itself is just referenced in documentation, not directly).

Time to grep a bit more to find where the lib is called
Comment 5 Bernard Cafarelli gentoo-dev 2020-02-03 21:26:40 UTC
OK forcing the flag on qtkeychain may not be that useful for owncloud-client (if you have it working without), but this is cleaner:
USE=gnome-keyring now requires USE flag to be enabled also on dev-libs/qtkeychain, which pulls in libgnome-keyring and enables some stuff in qtkeychain itself

Will push in revbump (as this changes the deps)
Comment 6 Larry the Git Cow gentoo-dev 2020-02-03 21:28:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a58a827c79d22c798203011a117f345c8fd0b73

commit 2a58a827c79d22c798203011a117f345c8fd0b73
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2020-02-03 21:28:31 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2020-02-03 21:28:43 +0000

    net-misc/owncloud-client: update USE=gnome-keyring dependency
    
    Per bug comment, libgnome-keyring itself is actually needed, though
    there are no direct calls in owncloud-client itself. So depend on
    qtkeychain[gnome-keyring]
    
    Closes: https://bugs.gentoo.org/666798
    Package-Manager: Portage-2.3.87, Repoman-2.3.20
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 ...ient-2.6.1.13407.ebuild => owncloud-client-2.6.1.13407-r1.ebuild} | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 7 haarp 2020-02-04 09:34:58 UTC
Thanks, it's working now.

It seems enabling the useflag on qtkeychain alters behavior slightly, making Owncloud store the password differently. It will prompt for the password once more and save it in the keychain again. It will work from there on.
Comment 8 Bernard Cafarelli gentoo-dev 2020-02-04 11:07:10 UTC
Nice!

From a quick read in qtkeychain source code [1] and libsecret home page [2], it seems qtkeychain can work with gnome-keyring as legacy code, finding it at runtime (not updated for a few years) or through glib/libsecret (activated by USE flag) which is mentioned as replacement for libgnome-keyring.

So this is indeed a separate path, probably explaining the need to reenter the password. At least this time it uses the "modern" access, so you should be good for a long time

[1] https://github.com/frankosterfeld/qtkeychain
[2] https://wiki.gnome.org/Projects/Libsecret