Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656866 - www-apps/cgit[highlight]: should use python eclass and sanitize the deps
Summary: www-apps/cgit[highlight]: should use python eclass and sanitize the deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aaron Bauman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-29 18:52 UTC by Michał Górny
Modified: 2021-02-07 23:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-29 18:52:28 UTC
Currently USE=highlight installs pygments-based highlighter without specific Python shebang.  As a result, if pygments are installed for different Python version than the script is run with, cgit silently gives zero output (we've just hit this on infra).

Please make it use python-single-r1, python_fix_shebang the script and make a clear [${PYTHON_USEDEP}] on pygments.  I guess you also want to kill the '||' then, and either have separate flags for the two highlighters, or forget about the other one.
Comment 1 Larry the Git Cow gentoo-dev 2021-02-07 23:00:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddf5e438066fd35555faa2e7c867175a3206e095

commit ddf5e438066fd35555faa2e7c867175a3206e095
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2021-02-07 22:56:56 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2021-02-07 22:56:56 +0000

    www-apps/cgit: drop libressl; fix highlight deps; add python stuff
    
    * This changes the highlighter explicitly to dev-python/pygments which
    negates the need to patch bug #574056
    * This also depends on python-single-r1 and fixes all py script shebangs
    * Fix QA issues with || dies
    * Drop libressl support
    
    Closes: https://bugs.gentoo.org/574056
    Closes: https://bugs.gentoo.org/656866
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 www-apps/cgit/cgit-1.2.3-r200.ebuild | 107 +++++++++++++++++++++++++++++++++++
 1 file changed, 107 insertions(+)