Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 574056 - www-apps/cgit: patch syntax-highlighting.sh
Summary: www-apps/cgit: patch syntax-highlighting.sh
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Aaron Bauman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-07 07:16 UTC by Daniel M. Weeks
Modified: 2021-02-07 23:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2016-02-07 07:16:14 UTC
The highlight-based script provided with cgit (syntax-highlighting.sh) defaults to using highlight with version 2 command line options. There is another exec line for version 3 but it is commented out by default. Since Gentoo only has version 3 ebuilds of highlight now it seems logical to patch that script and default to the version 3 command.

For history see also bug #379583.

Reproducible: Always
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2016-02-11 15:49:05 UTC
the set proxy maintainer is known to have become inactive. Setting to maintainer-needed
Comment 2 Jason A. Donenfeld gentoo-dev 2016-02-12 03:36:03 UTC
I'll probably just move it to highlight 3 upstream.

Does anybody actually use highlight 2?
Comment 3 Alex Xu (Hello71) 2017-03-23 16:17:44 UTC
(In reply to Jason A. Donenfeld from comment #2)
> I'll probably just move it to highlight 3 upstream.
> 
> Does anybody actually use highlight 2?

guess not
Comment 4 Larry the Git Cow gentoo-dev 2021-02-07 23:00:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddf5e438066fd35555faa2e7c867175a3206e095

commit ddf5e438066fd35555faa2e7c867175a3206e095
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2021-02-07 22:56:56 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2021-02-07 22:56:56 +0000

    www-apps/cgit: drop libressl; fix highlight deps; add python stuff
    
    * This changes the highlighter explicitly to dev-python/pygments which
    negates the need to patch bug #574056
    * This also depends on python-single-r1 and fixes all py script shebangs
    * Fix QA issues with || dies
    * Drop libressl support
    
    Closes: https://bugs.gentoo.org/574056
    Closes: https://bugs.gentoo.org/656866
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 www-apps/cgit/cgit-1.2.3-r200.ebuild | 107 +++++++++++++++++++++++++++++++++++
 1 file changed, 107 insertions(+)