Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651208 - sys-apps/portage: add profile-formats extension that allows ::repo atoms
Summary: sys-apps/portage: add profile-formats extension that allows ::repo atoms
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Normal enhancement with 1 vote (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 240187 778869
  Show dependency tree
 
Reported: 2018-03-22 23:21 UTC by Zac Medico
Modified: 2021-09-07 16:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2018-03-22 23:21:52 UTC
For third-party profiles, it can be useful to use ::repo atoms in configurations. Currently, this is possible by putting 5-progress in the 'eapi' file, but it would be nice to be able to enable this via profile-formats.
Comment 1 Tim Harder gentoo-dev 2018-03-22 23:39:46 UTC
Could this just be added to EAPI 7 instead? I'd rather useful things be added to the spec instead of adding more extensions to profile-formats and/or layout.conf.

Honestly, it's way overdue that at least the portage-1 and portage-2 extensions be folded into PMS as well.
Comment 2 Zac Medico gentoo-dev 2018-03-23 00:13:59 UTC
(In reply to Tim Harder from comment #1)
> Could this just be added to EAPI 7 instead? I'd rather useful things be
> added to the spec instead of adding more extensions to profile-formats
> and/or layout.conf.

In the past, I recall significant resistance to allowing ::repo atoms in ebuilds. Are you suggesting to allow it ebuild dependencies or just in profile atoms?

> Honestly, it's way overdue that at least the portage-1 and portage-2
> extensions be folded into PMS as well.

Agreed.
Comment 3 William L. Thomson Jr. 2018-03-23 01:05:39 UTC
Not exactly a duplicate but I brought this up here in bug 641020. Though others were against overlays masking aspects of the tree as commented in that bug. I would like to mask dev-java/*::gentoo in an overlay. Which overlay masking is what was mentioned on list.
https://archives.gentoo.org/gentoo-dev/message/630ce1c77fae10dd442a0d85be3b95a2

As a work around I had to create a package...
https://github.com/Obsidian-StudiosInc/os-xtoo/tree/master/app-portage/mask-gentoo-dev-java


But in general ::repo format is not allowed in any areas of overlay profiles. Having it anywhere would be a step forward for sure!
Comment 4 Tim Harder gentoo-dev 2018-03-23 07:56:43 UTC
(In reply to Zac Medico from comment #2)
> (In reply to Tim Harder from comment #1)
> > Could this just be added to EAPI 7 instead? I'd rather useful things be
> > added to the spec instead of adding more extensions to profile-formats
> > and/or layout.conf.
> 
> In the past, I recall significant resistance to allowing ::repo atoms in
> ebuilds. Are you suggesting to allow it ebuild dependencies or just in
> profile atoms?

Just profile atoms, using it for ebuild deps doesn't make sense to me as generally you want those to override easily without having to mangle deps if you copy ebuilds around.
Comment 5 Zac Medico gentoo-dev 2020-10-21 00:27:07 UTC
The profile-formats = build-id implementation shows how to implement an atom syntax extension in profiles:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=c6e3af2b1e419d70443a74575e9b762a101a3912
Comment 6 Larry the Git Cow gentoo-dev 2021-03-28 09:12:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=378e6f32f15ce3ce0c22fd31a90c79efa01c3def

commit 378e6f32f15ce3ce0c22fd31a90c79efa01c3def
Author:     Felix Bier <felix.bier@rohde-schwarz.com>
AuthorDate: 2021-03-17 22:51:05 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-03-28 09:02:40 +0000

    Add profile format extension for repo atoms
    
    This commit adds a profile format extension that
    allows to use repo atoms in profile files.
    
    Bug: https://bugs.gentoo.org/651208
    Closes: https://github.com/gentoo/portage/pull/687
    Signed-off-by: Felix Bier <felix.bier@rohde-schwarz.com>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/repository/config.py                            |  5 ++++-
 .../binpkg_multi_instance/test_build_id_profile_format.py   | 13 ++++++++++---
 man/portage.5                                               |  6 ++++--
 3 files changed, 18 insertions(+), 6 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2021-03-29 07:34:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b227821cc18ee50ede6b9cb6493820a0460cd1bb

commit b227821cc18ee50ede6b9cb6493820a0460cd1bb
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-03-29 07:31:19 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-03-29 07:34:04 +0000

    sys-apps/portage: Bump to version 3.0.18
    
     #651208 profile-repo-deps profile-formats support
     #719260 remove glsa --quiet blank line
     #722748 suppress emerge --oneshot portage suggestion
    
    Bug: https://bugs.gentoo.org/778869
    Bug: https://bugs.gentoo.org/651208
    Bug: https://bugs.gentoo.org/719260
    Bug: https://bugs.gentoo.org/722748
    Package-Manager: Portage-3.0.18, Repoman-3.0.2
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.18.ebuild | 279 +++++++++++++++++++++++++++++++++
 2 files changed, 280 insertions(+)
Comment 8 Shiba 2021-09-07 16:13:04 UTC
Is it normal that I can make this work for package.mask only? I tried adding ::gentoo atoms to profile/package.{unmask,use.mask}, but they were all ignored. Am I missing something?