Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 640654 - sys-apps/iproute2-4.14.1-r1: src_configure() is broken, making all deps automagic
Summary: sys-apps/iproute2-4.14.1-r1: src_configure() is broken, making all deps autom...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 639536
  Show dependency tree
 
Reported: 2017-12-11 08:09 UTC by Hector Martin
Modified: 2017-12-15 11:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hector Martin 2017-12-11 08:09:47 UTC
src_configure() writes the config to 'Config':

        cat <<-EOF > Config
        TC_CONFIG_ATM := $(usex atm y n)
        TC_CONFIG_XT  := $(usex iptables y n)
        TC_CONFIG_NO_XT := $(usex iptables n y)
        # We've locked in recent enough kernel headers #549948
        TC_CONFIG_IPSET := y
        HAVE_BERKELEY_DB := $(usex berkdb y n)
        HAVE_MNL      := $(usex minimal n y)
        HAVE_ELF      := $(usex minimal n y)
        HAVE_SELINUX  := $(usex selinux y n)
        IP_CONFIG_SETNS := ${setns}
        # Use correct iptables dir, #144265 #293709
        IPT_LIB_DIR := $(use iptables && ${PKG_CONFIG} xtables --variable=xtlibdir)
        EOF

But the 'configure' script does:

# Output file which is input to Makefile
CONFIG=config.mk

'Config' does nothing (there is no reference to it). The Makefile ends up running ./configure itself to generate config.mk, which makes all dependencies automagic.

Note that config.mk doesn't seem to quite have the same contents as Config, so simply changing the filename may not be sufficient.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-11 21:08:45 UTC
Good catch! Change happened in 4.14.0:
    https://github.com/shemminger/iproute2/commit/5f1df307b47f7f0b28a29d85418a3934cc3a83b2

iproute2 $ git tag --contains=5f1df307b47f7f0b28a29d85418a3934cc3a83b2
v4.14.0
v4.14.1
Comment 2 Anthony Basile gentoo-dev 2017-12-11 23:51:57 UTC
(In reply to Sergei Trofimovich from comment #1)
> Good catch! Change happened in 4.14.0:
>    
> https://github.com/shemminger/iproute2/commit/
> 5f1df307b47f7f0b28a29d85418a3934cc3a83b2
> 
> iproute2 $ git tag --contains=5f1df307b47f7f0b28a29d85418a3934cc3a83b2
> v4.14.0
> v4.14.1

I've got something of a fix in bug #639536#c7.  After configure generates config.mk, you can append the old Config and this will override the previous values.  A more elegant solution might sed the lines of config.mk.
Comment 3 Hector Martin 2017-12-14 12:44:56 UTC
The fix in bug #639536#c7 seems to work (if perhaps not the most elegant).
Comment 4 Larry the Git Cow gentoo-dev 2017-12-15 11:48:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5eafd8616730adc6677072d82c2c9e48c351b507

commit 5eafd8616730adc6677072d82c2c9e48c351b507
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2017-12-15 11:35:36 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2017-12-15 11:48:50 +0000

    sys-apps/iproute2: Rev bump
    
    Closes: https://bugs.gentoo.org/640654
    Bug: https://bugzilla.redhat.com/1514963
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 .../files/iproute2-4.14.1-fix-tc-actions.patch     | 222 +++++++++++++++++++++
 sys-apps/iproute2/iproute2-4.14.1-r2.ebuild        | 146 ++++++++++++++
 2 files changed, 368 insertions(+)