639536 – sys-apps/iproute2-4.14.1-r2: stablereq

Bug 639536 - sys-apps/iproute2-4.14.1-r2: stablereq

Summary: sys-apps/iproute2-4.14.1-r2: stablereq

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Stabilization (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:	STABLEREQ

Depends on:	621662 640654
Blocks:	639522
	Show dependency tree

Reported:	2017-12-02 20:38 UTC by Robin Johnson
Modified:	2018-02-01 22:32 UTC (History)
CC List:	3 users (show)

See Also:
Package list:	sys-apps/iproute2-4.14.1-r2 alpha amd64 arm arm64 hppa ia64 m68k ppc ppc64 s390 sh sparc x86
Runtime testing required:	Yes

Flags:	stable-bot: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Robin Johnson archtester

2017-12-02 20:38:28 UTC

Stablereq for iproute2-4.14.1-r1.

4.14.1 contains a single change over 4.14.0:
- upstream merged a uclibc fix for bug 626546

Comment 1 Robin Johnson archtester

2017-12-02 20:43:34 UTC

arches, please test iproute2-4.14.1-r1 lots & stabilize.

target keywords:
alpha amd64 arm arm64 hppa ia64 m68k ppc ppc64 s390 sh sparc x86

There is one known issue with a fix in progress:
- Bug 621662: ppp makes bad assumptions about ip route output and breaks. Will be fixed soon.

Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev

2017-12-08 20:40:44 UTC

x86 stable

Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev

2017-12-10 21:22:44 UTC

hppa stable

Comment 4 Anthony Basile gentoo-dev

2017-12-10 23:46:02 UTC

stable on ppc and ppc64

Comment 5 Hector Martin 2017-12-11 08:04:00 UTC

This ebuild is broken. It writes configuration stuff into 'Config' instead of 'config.mk', which does nothing. The package ends up configuring itself and all dependencies become automagic.

Comment 6 Anthony Basile gentoo-dev

2017-12-11 20:43:33 UTC

(In reply to Hector Martin from comment #5)
> This ebuild is broken. It writes configuration stuff into 'Config' instead
> of 'config.mk', which does nothing. The package ends up configuring itself
> and all dependencies become automagic.

yeah i can confirm that.  line 90 currently reads

 cat <<-EOF > Config

whereas it should be

 cat <<-EOF > config.mk

I'm testing at my end, can you test at yours and see that in fact this fixes the automagic.

Comment 7 Anthony Basile gentoo-dev

2017-12-11 21:01:14 UTC

(In reply to Anthony Basile from comment #6)
> (In reply to Hector Martin from comment #5)
> > This ebuild is broken. It writes configuration stuff into 'Config' instead
> > of 'config.mk', which does nothing. The package ends up configuring itself
> > and all dependencies become automagic.
> 
> yeah i can confirm that.  line 90 currently reads
> 
>  cat <<-EOF > Config
> 
> whereas it should be
> 
>  cat <<-EOF > config.mk
> 
> I'm testing at my end, can you test at yours and see that in fact this fixes
> the automagic.

Actually this isn't quite right, try this patch.  I tested using USE=-atm and USE=atm and found that only in the later case did I get tc/q_atm.so built.

diff --git a/sys-apps/iproute2/iproute2-4.14.1-r1.ebuild b/sys-apps/iproute2/iproute2-4.14.1-r1.ebuild
index 26aeb9bb97a..7cfc5a2544f 100644
--- a/sys-apps/iproute2/iproute2-4.14.1-r1.ebuild
+++ b/sys-apps/iproute2/iproute2-4.14.1-r1.ebuild
@@ -87,7 +87,9 @@ src_configure() {
        ${CC} ${CFLAGS} ${CPPFLAGS} ${LDFLAGS} test.c -lresolv >&/dev/null || sed -i '/^LDLIBS/s:-lresolv::' "${S}"/Makefile
        popd >/dev/null
 
-       cat <<-EOF > Config
+       default
+
+       cat <<-EOF >> config.mk
        TC_CONFIG_ATM := $(usex atm y n)
        TC_CONFIG_XT  := $(usex iptables y n)
        TC_CONFIG_NO_XT := $(usex iptables n y)

Comment 8 Jason Zaman gentoo-dev

2017-12-14 11:19:47 UTC

amd64 stable

Comment 9 Sergei Trofimovich (RETIRED) gentoo-dev

2017-12-14 19:48:45 UTC

ia64 stable

Comment 10 Michal Privoznik 2017-12-15 09:49:26 UTC

I don't think this is stable. There's a bug that prevents libvirt from working properly:

https://bugzilla.redhat.com/1514963

Comment 11 Thomas Deutschmann (RETIRED) gentoo-dev

2017-12-15 11:51:34 UTC

Restarting stabilization with =sys-apps/iproute2-4.14.1-r2 ...

Comment 12 Thomas Deutschmann (RETIRED) gentoo-dev

2017-12-15 11:53:29 UTC

(In reply to Thomas Deutschmann from comment #11)
> Restarting stabilization with =sys-apps/iproute2-4.14.1-r2 ...
...which fixes the automagic bug 640654 and contains the accepted patch from Michael! Thanks for the report ;)

Comment 13 Thomas Deutschmann (RETIRED) gentoo-dev

2017-12-19 15:48:32 UTC

x86 stable

Comment 14 Sergei Trofimovich (RETIRED) gentoo-dev

2017-12-26 21:35:02 UTC

ia64 stable

Comment 15 Mikle Kolyada (RETIRED) archtester

2017-12-26 23:41:51 UTC

amd64 stable

Comment 16 Sergei Trofimovich (RETIRED) gentoo-dev

2017-12-27 11:09:34 UTC

sparc stable (thanks to Rolf Eike Beer)

Comment 17 Sergei Trofimovich (RETIRED) gentoo-dev

2017-12-27 12:23:00 UTC

ppc/ppc64 stable

Comment 18 Markus Meier gentoo-dev

2018-01-10 06:11:30 UTC

arm stable

Comment 19 Sergei Trofimovich (RETIRED) gentoo-dev

2018-01-10 22:26:27 UTC

hppa stable (thanks to Rolf Eike Beer)

Comment 20 SpanKY gentoo-dev

2018-02-01 22:32:45 UTC

done the rest