Bug 636370 – Prefix-specific dev-lang/perl-5.26.1-r1 breaks on macOS prefix

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Stuart Shelton 2017-11-03 12:43:54 UTC]

dev-lang/perl-5.26.1-r1 fails with:

In file included from gv.c:36:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from toke.c:40:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from regcomp.c:75:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from pad.c:148:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from dump.c:29:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from op.c:163:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
In file included from perl.c:37:
In file included from ./perl.h:5651:
./perlvars.h:105:26: error: unknown type name 'locale_t'
PERLVAR(G, C_locale_obj, locale_t)
                         ^
1 error generated.
make: *** [GNUmakefile:259: pad.o] Error 1
make: *** Waiting for unfinished jobs....
1 error generated.
make: *** [GNUmakefile:259: gv.o] Error 1
1 error generated.
make: *** [GNUmakefile:259: dump.o] Error 1
1 error generated.
make: *** [GNUmakefile:320: perlmini.o] Error 1
1 error generated.
make: *** [GNUmakefile:312: opmini.o] Error 1
1 error generated.
make: *** [GNUmakefile:259: toke.o] Error 1
1 error generated.
make: *** [GNUmakefile:259: regcomp.o] Error 1
 * ERROR: dev-lang/perl-5.26.1-r1::gentoo_prefix failed (compile phase):
 *   emake failed


... which appears to be due to the change from dev-lang/perl-5.26.1 to dev-lang/perl-5.26.1-r1:

--- dev-lang/perl/perl-5.26.1.ebuild	2017-10-29 19:36:34.000000000 +0000
+++ dev-lang/perl/perl-5.26.1-r1.ebuild	2017-11-01 21:04:39.000000000 +0000
@@ -511,6 +511,7 @@
 		-Dsh="${EPREFIX}"/bin/sh \
 		-Dtargetsh="${EPREFIX}"/bin/sh \
 		-Uusenm \
+		-Ui_xlocale \
 		"${myconf[@]}" \
 		"${EXTRA_ECONF[@]}"


clang search directories are:

$ clang -x c -v -E /dev/null
clang version 3.9.1 (tags/RELEASE_391/final)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir: /opt/gentoo/usr/bin
clang -cc1 version 3.9.1 based upon LLVM 3.9.1 default target x86_64-apple-darwin17.2.0
ignoring nonexistent directory "/usr/local/include"
ignoring nonexistent directory "/opt/gentoo/Frameworks"
#include "..." search starts here:
#include <...> search starts here:
 /opt/gentoo/usr/include
 /opt/gentoo/usr/bin/../lib/clang/3.9.1/include
 /usr/include
 /System/Library/Frameworks (framework directory)
 /Library/Frameworks (framework directory)
End of search list.

[Comment 1 Fabian Groffen 2017-11-03 14:12:57 UTC]

On Sierra I don't have this problem.

[Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) 2017-11-04 03:56:46 UTC]

this change is added in -r1 due to changes in GLibc 2.26 which deprecates the existence of xlocale.h

What libc stuff does OSX Use?

[Comment 3 Andreas K. Hüttel 2017-11-04 14:09:34 UTC]

(In reply to Kent Fredric (IRC: kent\n) from comment #2)
> this change is added in -r1 due to changes in GLibc 2.26 which deprecates
> the existence of xlocale.h
> 
> What libc stuff does OSX Use?

Sigh, this ties in with #ifdef conditionsals I've seen in other packages. While glibc is going locale.h only with 2.26, some macos is xlocale.h only. 

I'm putting the parameter behind an "if use elibc_glibc ; "

[Comment 4 Larry the Git Cow 2017-11-04 14:26:51 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59e5b94ccd20a044eaa752ca5077c7d6d2b065b4

commit 59e5b94ccd20a044eaa752ca5077c7d6d2b065b4
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2017-11-04 14:24:39 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2017-11-04 14:24:39 +0000

    dev-lang/perl: Darwinism: Survival of the fittest command line switches. Bug 636370
    
    Closes: https://bugs.gentoo.org/636370
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 dev-lang/perl/perl-5.26.1-r1.ebuild | 7 ++++++-
 dev-lang/perl/perl-5.26.9999.ebuild | 7 ++++++-
 dev-lang/perl/perl-5.28.9999.ebuild | 7 ++++++-
 3 files changed, 18 insertions(+), 3 deletions(-)