Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 630416 - [Future EAPI] Ban dolib and libopts
Summary: [Future EAPI] Ban dolib and libopts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PMS/EAPI
URL: https://archives.gentoo.org/gentoo-de...
Whiteboard: in-eapi-7
Keywords:
Depends on:
Blocks: future-eapi
  Show dependency tree
 
Reported: 2017-09-08 19:12 UTC by Ulrich Müller
Modified: 2018-04-30 22:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-09-08 19:12:27 UTC
As posted to gentoo-dev:

I suggest that we ban the dolib and libopts commands in EAPI 7.

Rationale:
1. There are about 60 instances of dolib in the tree. At least one
   third of them appears to be wrong (e.g., should be replaced by
   dolib.so for correct mode).
2. libopts affects only dolib, while the more special commands dolib.a
   and dolib.so install libraries with fixed modes 0644 and 0755,
   respectively. (The latter is also consistent with dobin installing
   with fixed mode 0755, i.e., there is no binopts command.)
3. There is no newlib command corresponding to dolib, whereas
   newlib.{a,so} commands exist.
4. libopts is not used at all in the tree, which strongly indicates
   that there is no need for it.

Replacement:
Use dolib.a or dolib.so instead.
Comment 1 Larry the Git Cow gentoo-dev 2018-03-04 21:04:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=04a8eba03539b6e401022aee3aacf1fde3a8eeca

commit 04a8eba03539b6e401022aee3aacf1fde3a8eeca
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-09-21 14:43:29 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-03-04 21:03:53 +0000

    Ban dolib/libopts for EAPI 7
    
    Bug: https://bugs.gentoo.org/630416

 bin/eapi.sh                 | 4 ++++
 bin/ebuild-helpers/dolib    | 7 ++++++-
 bin/ebuild-helpers/dolib.a  | 4 ++--
 bin/ebuild-helpers/dolib.so | 4 ++--
 bin/phase-helpers.sh        | 6 +++++-
 5 files changed, 19 insertions(+), 6 deletions(-)}
Comment 2 Larry the Git Cow gentoo-dev 2018-04-30 22:14:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pms.git/commit/?id=a2634ccb6f5dfb323f1bbddcb8c9296b7a4d28f3

commit a2634ccb6f5dfb323f1bbddcb8c9296b7a4d28f3
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-09-29 14:02:49 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-03-31 15:30:43 +0000

    EAPI 7 bans dolib and libopts.
    
    Bug: https://bugs.gentoo.org/630416

 eapi-differences.tex |  7 +++++++
 pkg-mgr-commands.tex | 22 ++++++++++++++--------
 2 files changed, 21 insertions(+), 8 deletions(-)}