Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627098 - media-gfx/evoluspencil-2.0.5: calls doins without insinto
Summary: media-gfx/evoluspencil-2.0.5: calls doins without insinto
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Palimaka (kensington)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 588944
  Show dependency tree
 
Reported: 2017-08-05 14:13 UTC by Michael Orlitzky
Modified: 2017-09-26 13:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2017-08-05 14:13:32 UTC
The src_install phase of this ebuild is,

  src_install() {
    doins -r usr
    newbin "${FILESDIR}"/launcher ${PN}
  }

but it turns out that the PMS doesn't specify what happens when you call doins without having called insinto (bug 588944). Doing so is often a mistake, and can mess up permissions on important directories like /usr, /var, etc., so we'd like to make it an error. But before we can, we need to fix all of the packages doing it.

If it's not too much trouble, it would help us out if you could add an insinto call to the src_install above. (You might also want to consider calling doins further down the tree, to avoid permissions problems on /usr in the future). Thanks!
Comment 1 Larry the Git Cow gentoo-dev 2017-09-26 13:23:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4aed7ed890c6c5108d2d3d21c397f6a0a8e7fc84

commit 4aed7ed890c6c5108d2d3d21c397f6a0a8e7fc84
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-09-26 13:22:57 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-09-26 13:23:17 +0000

    media-gfx/evoluspencil: call insinto before doins
    
    Closes: https://bugs.gentoo.org/627098
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 media-gfx/evoluspencil/evoluspencil-2.0.5.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)