588944 – sys-apps/portage: make doins error out if insinto wasn't used

Bug 588944 - sys-apps/portage: make doins error out if insinto wasn't used

Summary: sys-apps/portage: make doins error out if insinto wasn't used

Status:	CONFIRMED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:	627094 627096 627098
Blocks:	563798
	Show dependency tree

Reported:	2016-07-16 18:35 UTC by Michał Górny
Modified:	2017-08-05 14:13 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-16 18:35:36 UTC

Proxy-maint just hit an ebuild where proxied maintainer used 'doins' to install files recursively into /. Aside the fact that this caused wrong permissions, I think that PMS doesn't specify any default path for doins.

Please make Portage error out if 'doins' is called with no path set by earlier 'insinto' call.

Comment 1 Michael Orlitzky gentoo-dev

2016-07-16 20:44:59 UTC

Here's a list of current offenders (probably not comprehensive):

dev-util/intel-ocl-sdk-2.0.31360
media-gfx/evoluspencil-2.0.5
sci-physics/geant-data-4.10.00
sci-physics/geant-data-4.10.01
sci-physics/geant-data-4.9.6_p02
sci-electronics/systemc-2.2.0-r2
sci-libs/spqr-1.2.3-r1
sci-visualization/xyscan-3.3.1

# Relies on the doins() call in linux-mod_src_install().
sys-fs/aufs4-0_pre20160627
sys-fs/aufs4-0_pre20160219
sys-fs/aufs4-0_pre20160223
sys-fs/aufs3-3_p20160627
sys-fs/aufs3-3_p20160223
sys-fs/aufs3-3_p20160219

# Bug, should be using dodoc() instead of doins().
dev-libs/gecode-3.7.3

Comment 2 Zac Medico gentoo-dev

2016-07-16 21:17:19 UTC

This looks like a good candidate for an eqawarn QA Notice.