Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 618442 - >=dev-vcs/git-2.13.6 [threads] sets legacy and unused variable THREADED_DELTA_SEARCH=YesPlease
Summary: >=dev-vcs/git-2.13.6 [threads] sets legacy and unused variable THREADED_DELTA...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-05-14 11:26 UTC by mikey
Modified: 2022-09-04 04:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove outdated THREADED_DELTA_SEARCH (file_618442.txt,464 bytes, patch)
2017-12-02 12:38 UTC, mikey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mikey 2017-05-14 11:26:44 UTC
Hi

The snippet for threads in the ebuild (all versions) reads

    use threads \                      
        && myopts+=" THREADED_DELTA_SEARCH=YesPlease" \
        || myopts+=" NO_PTHREADS=YesPlease" 

However, the Release Notes of 1.7.0 states:

 * THREADED_DELTA_SEARCH is no more.  If you build with threads, delta
   compression will always take advantage of it.

Suggestion is to remove this remnant from ancient versions.
Comment 1 mikey 2017-12-02 12:38:49 UTC
Created attachment 507686 [details, diff]
Remove outdated THREADED_DELTA_SEARCH

A patch which removes the obsolete line. Also applies to git-2.14.3, git-2.15.0, git-2.15.1, git-9999 with a slight offset.
Comment 2 Larry the Git Cow gentoo-dev 2019-04-20 22:48:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8cb6c7529bea98632e010af057934be02640d9b1

commit 8cb6c7529bea98632e010af057934be02640d9b1
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-04-20 22:46:27 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-04-20 22:48:07 +0000

    dev-vcs/git: THREADED_DELTA_SEARCH switch is long gone.
    
    Thanks-to: mikey@opentrash.com
    Closes: https://bugs.gentoo.org/618442
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 dev-vcs/git/git-2.19.2.ebuild    | 2 +-
 dev-vcs/git/git-2.20.1.ebuild    | 2 +-
 dev-vcs/git/git-2.21.0-r1.ebuild | 2 +-
 dev-vcs/git/git-2.21.0-r2.ebuild | 2 +-
 dev-vcs/git/git-2.21.0.ebuild    | 2 +-
 dev-vcs/git/git-9999-r1.ebuild   | 2 +-
 dev-vcs/git/git-9999-r2.ebuild   | 2 +-
 dev-vcs/git/git-9999-r3.ebuild   | 2 +-
 dev-vcs/git/git-9999.ebuild      | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)