Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868339 - dev-vcs/git: remove USE=threads and always-enable support
Summary: dev-vcs/git: remove USE=threads and always-enable support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 868336
  Show dependency tree
 
Reported: 2022-09-04 04:15 UTC by Sam James
Modified: 2022-12-06 06:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-04 04:15:18 UTC
USE=threads should always be enabled for git. 

Per https://git.github.io/rev_news/2021/06/27/edition-76/, the USE=-threads (no-pthreads) path is taken only for e.g. NonStop systems and is not well tested on Linux.

It should be safe to unconditionally enable.
Comment 1 Larry the Git Cow gentoo-dev 2022-09-16 23:25:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b1b3f9754a40861862473b9f1a689b9ecf86a75

commit 0b1b3f9754a40861862473b9f1a689b9ecf86a75
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-09-11 16:00:15 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-16 23:25:27 +0000

    dev-vcs/git: remove USE=threads and always-enable support
    
    Upstream enables pthreads by default, so enable it unconditionally.
    
    Closes: https://bugs.gentoo.org/868339
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/27210
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/git/git-2.37.3.ebuild  | 3 +--
 dev-vcs/git/git-9999-r1.ebuild | 3 +--
 dev-vcs/git/git-9999-r2.ebuild | 3 +--
 dev-vcs/git/git-9999-r3.ebuild | 3 +--
 dev-vcs/git/git-9999.ebuild    | 3 +--
 5 files changed, 5 insertions(+), 10 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2022-12-06 06:09:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=b53bc9e194fec2e825006be14a113c5b28452ad1

commit b53bc9e194fec2e825006be14a113c5b28452ad1
Author:     Yuan Liao <liaoyuan@gmail.com>
AuthorDate: 2022-12-05 18:16:27 +0000
Commit:     Yuan Liao <liaoyuan@gmail.com>
CommitDate: 2022-12-05 18:16:27 +0000

    www-apps/gogs: Fix dev-vcs/git[threads] dependency resolution
    
    USE="threads" has been removed since dev-vcs/git-2.37.3 because it has
    effectively become always-enabled.
    
    Bug: https://bugs.gentoo.org/868339
    Signed-off-by: Yuan Liao <liaoyuan@gmail.com>

 www-apps/gogs/gogs-0.12.3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)