Compilation fails in chromium/ui/gfx/codec/jpeg_codec.cc because of various invalid conversions from int to boolean or bool to boolean. This is a problem in upstream chromium and was reported there (including patch) as: https://bugs.chromium.org/p/chromium/issues/detail?id=686191 I also reported this at Qt as https://bugreports.qt.io/browse/QTBUG-58482. I have also attached a version of the patch created specifically for the qtwebengine-5.7.1 ebuild.
Created attachment 461656 [details, diff] Fix invalid conversion of booleans in jpeg codec of bundled chromium
Thanks. And does the patch preserve source compatibility with libjpeg-turbo?
Yes, this patch only removes the assumption that boolean is an int and uses the proper names TRUE and FALSE for the boolean type defined in the libjpeg headers.
This patch got into 5.10 branch: https://codereview.qt-project.org/#/c/206049/
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f340edd950eb281bb73bf51ab95b5eb5012ab3b5 commit f340edd950eb281bb73bf51ab95b5eb5012ab3b5 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-02-06 21:30:21 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-02-07 02:04:05 +0000 dev-qt/qtwebengine: Fix build with jpeg-9 Closes: https://bugs.gentoo.org/607424 Closes: https://bugs.gentoo.org/646456 Package-Manager: Portage-2.3.24, Repoman-2.3.6 .../files/qtwebengine-5.9.4-jpeg-9-1.patch | 70 ++++++++++++++++++++++ .../files/qtwebengine-5.9.4-jpeg-9-2.patch | 46 ++++++++++++++ dev-qt/qtwebengine/qtwebengine-5.9.4.ebuild | 7 ++- 3 files changed, 122 insertions(+), 1 deletion(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/qt.git/commit/?id=6ae7dcf1de5b2cf896fa6ceefd7e4c42d2da8b54 commit 6ae7dcf1de5b2cf896fa6ceefd7e4c42d2da8b54 Author: Michael Palimaka <kensington@gentoo.org> AuthorDate: 2018-02-07 10:29:50 +0000 Commit: Michael Palimaka <kensington@gentoo.org> CommitDate: 2018-02-07 10:30:43 +0000 dev-qt/qtwebengine: port media-libs/jpeg-9b patches from ::gentoo Bug: https://bugs.gentoo.org/607424 Bug: https://bugs.gentoo.org/646456 Package-Manager: Portage-2.3.19, Repoman-2.3.6 .../files/qtwebengine-5.9.4-jpeg-9-1.patch | 70 ++++++++++++++++++++++ .../files/qtwebengine-5.9.4-jpeg-9-2.patch | 46 ++++++++++++++ dev-qt/qtwebengine/qtwebengine-5.10.0.ebuild | 2 + dev-qt/qtwebengine/qtwebengine-5.10.9999.ebuild | 2 + dev-qt/qtwebengine/qtwebengine-5.11.9999.ebuild | 2 + dev-qt/qtwebengine/qtwebengine-5.9.9999.ebuild | 6 +- dev-qt/qtwebengine/qtwebengine-5.9999.ebuild | 2 + 7 files changed, 129 insertions(+), 1 deletion(-)}
