Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607424 - dev-qt/qtwebengine fails to compile chromium against >=media-libs/jpeg-9b
Summary: dev-qt/qtwebengine fails to compile chromium against >=media-libs/jpeg-9b
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: https://bugs.chromium.org/p/chromium/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: jpeg-9
  Show dependency tree
 
Reported: 2017-01-27 20:46 UTC by Maurice van der Pot
Modified: 2018-02-07 10:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix invalid conversion of booleans in jpeg codec of bundled chromium (qtwebengine-5.7.1-libjpeg9-booleans-fix.patch,1.86 KB, patch)
2017-01-27 20:47 UTC, Maurice van der Pot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maurice van der Pot 2017-01-27 20:46:17 UTC
Compilation fails in chromium/ui/gfx/codec/jpeg_codec.cc because of various invalid conversions from int to boolean or bool to boolean.

This is a problem in upstream chromium and was reported there (including patch) as:
https://bugs.chromium.org/p/chromium/issues/detail?id=686191

I also reported this at Qt as https://bugreports.qt.io/browse/QTBUG-58482.

I have also attached a version of the patch created specifically for the qtwebengine-5.7.1 ebuild.
Comment 1 Maurice van der Pot 2017-01-27 20:47:36 UTC
Created attachment 461656 [details, diff]
Fix invalid conversion of booleans in jpeg codec of bundled chromium
Comment 2 Davide Pesavento gentoo-dev 2017-01-27 23:55:18 UTC
Thanks. And does the patch preserve source compatibility with libjpeg-turbo?
Comment 3 Maurice van der Pot 2017-01-29 18:51:03 UTC
Yes, this patch only removes the assumption that boolean is an int and uses the proper names TRUE and FALSE for the boolean type defined in the libjpeg headers.
Comment 4 Andreas Sturmlechner gentoo-dev 2018-02-06 22:13:22 UTC
This patch got into 5.10 branch: https://codereview.qt-project.org/#/c/206049/
Comment 5 Larry the Git Cow gentoo-dev 2018-02-07 02:04:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f340edd950eb281bb73bf51ab95b5eb5012ab3b5

commit f340edd950eb281bb73bf51ab95b5eb5012ab3b5
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-02-06 21:30:21 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-02-07 02:04:05 +0000

    dev-qt/qtwebengine: Fix build with jpeg-9
    
    Closes: https://bugs.gentoo.org/607424
    Closes: https://bugs.gentoo.org/646456
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 .../files/qtwebengine-5.9.4-jpeg-9-1.patch         | 70 ++++++++++++++++++++++
 .../files/qtwebengine-5.9.4-jpeg-9-2.patch         | 46 ++++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.9.4.ebuild        |  7 ++-
 3 files changed, 122 insertions(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2018-02-07 10:30:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=6ae7dcf1de5b2cf896fa6ceefd7e4c42d2da8b54

commit 6ae7dcf1de5b2cf896fa6ceefd7e4c42d2da8b54
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2018-02-07 10:29:50 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2018-02-07 10:30:43 +0000

    dev-qt/qtwebengine: port media-libs/jpeg-9b patches from ::gentoo
    
    Bug: https://bugs.gentoo.org/607424
    Bug: https://bugs.gentoo.org/646456
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../files/qtwebengine-5.9.4-jpeg-9-1.patch         | 70 ++++++++++++++++++++++
 .../files/qtwebengine-5.9.4-jpeg-9-2.patch         | 46 ++++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.10.0.ebuild       |  2 +
 dev-qt/qtwebengine/qtwebengine-5.10.9999.ebuild    |  2 +
 dev-qt/qtwebengine/qtwebengine-5.11.9999.ebuild    |  2 +
 dev-qt/qtwebengine/qtwebengine-5.9.9999.ebuild     |  6 +-
 dev-qt/qtwebengine/qtwebengine-5.9999.ebuild       |  2 +
 7 files changed, 129 insertions(+), 1 deletion(-)}