Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604852 - media-sound/easytag add nautilus useflag (automagic gnome-base/nautilus dependency)
Summary: media-sound/easytag add nautilus useflag (automagic gnome-base/nautilus depen...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PATCH
: 608414 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-06 17:50 UTC by Sander Sweers
Modified: 2018-12-02 18:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sander Sweers 2017-01-06 17:50:07 UTC
easytag comes with a nautilus extension these days which is fine. However it is automagically enabled if libnautilus-extension is found which is not. Below patch add nautilus useflag plus conditional dep and configure option.

Untested but looking at the configure.ac in the easytag git repo this should work.

----------------
--- easytag-2.4.3.ebuild.orig	2017-01-06 18:34:21.546503443 +0100
+++ easytag-2.4.3.ebuild	2017-01-06 18:41:01.545484357 +0100
@@ -14,7 +14,7 @@
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos ~x86-solaris"
 
-IUSE="flac mp3 mp4 opus speex test vorbis wavpack"
+IUSE="flac mp3 mp4 nautilus opus speex test vorbis wavpack"
 REQUIRED_USE="
 	opus? ( vorbis )
 	speex? ( vorbis )
@@ -30,6 +30,7 @@
 		>=media-libs/libid3tag-0.15.1b-r4
 		)
 	mp4? ( >=media-libs/taglib-1.9.1[mp4(+)] )
+	nautilus? ( gnome-base/nautilus )
 	opus? (
 		>=media-libs/opus-1.1
 		>=media-libs/opusfile-0.4
@@ -63,6 +64,7 @@
 		$(use_enable test tests) \
 		$(use_enable mp3) \
 		$(use_enable mp3 id3v23) \
+		$(use_enable nautilus nautilus-actions) \
 		$(use_enable vorbis ogg) \
 		$(use_enable opus) \
 		$(use_enable speex) \
Comment 1 Sander Sweers 2017-01-10 22:34:46 UTC
Oh, the assignment reminded me to mention I did test this and things work as they should :)
Comment 2 Mart Raudsepp gentoo-dev 2017-02-20 18:25:10 UTC
*** Bug 608414 has been marked as a duplicate of this bug. ***
Comment 3 Sander Sweers 2017-09-30 16:55:50 UTC
Almost 9 months later...
Comment 4 coyote 2017-11-13 21:39:17 UTC
please push the patch.
Comment 5 Larry the Git Cow gentoo-dev 2018-12-02 18:43:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62ebb58deebdc65df8273d58e5de4fc787be277f

commit 62ebb58deebdc65df8273d58e5de4fc787be277f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-02 18:15:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-02 18:43:35 +0000

    media-sound/easytag: Add USE nautilus to fix automagic
    
    Non-maintainer commit.
    
    Thanks-to: Sander Sweers <Sander.Sweers@gmail.com>
    Closes: https://bugs.gentoo.org/604852
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/easytag/easytag-2.4.3-r1.ebuild | 4 +++-
 media-sound/easytag/metadata.xml            | 5 ++++-
 2 files changed, 7 insertions(+), 2 deletions(-)