There is a new upstream version of Webmin - 1.820 changelog: http://www.webmin.com/changes.html Sorry, don't know how to make a patch but though I would post the bump request so someone can pick up on it, seems to be a few security fixes there and current release gives a bunch of "Can't use 'defined(@array)'" errors...
*** Bug 605188 has been marked as a duplicate of this bug. ***
Created attachment 500176 [details] emerge --info
# ebuild webmin-1.860.ebuild manifest clean merge !!! Repository 'x-portage' is missing masters attribute in '/usr/local/portage/metadata/layout.conf' !!! Set 'masters = gentoo' in this file for future compatibility Appending /usr/local/portage to PORTDIR_OVERLAY... >>> Creating Manifest for /usr/local/portage/app-admin/webmin * webmin-1.860.tar.gz SHA256 SHA512 WHIRLPOOL size ;-) ... [ ok ] * checking ebuild checksums ;-) ... [ ok ] * checking auxfile checksums ;-) ... [ ok ] * checking miscfile checksums ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking webmin-1.860.tar.gz to /var/tmp/portage/app-admin/webmin-1.860/work >>> Source unpacked in /var/tmp/portage/app-admin/webmin-1.860/work >>> Preparing source in /var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860 ... [32;01m*[0m Fixing perl path in source files ... [A[72C [34;01m[ [32;01mok[34;01m ][0m >>> Source prepared. >>> Configuring source in /var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860 ... >>> Source configured. >>> Compiling source in /var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860 ... >>> Source compiled. >>> Test phase [not enabled]: app-admin/webmin-1.860 >>> Install webmin-1.860 into /var/tmp/portage/app-admin/webmin-1.860/image/ category app-admin [31;01m*[0m ERROR: app-admin/webmin-1.860::x-portage failed (install phase): [31;01m*[0m !!! newins: /var/tmp/portage/app-admin/webmin-1.860/files/gentoo-setup-1.860 does not exist [31;01m*[0m [31;01m*[0m If you need support, post the output of `emerge --info '=app-admin/webmin-1.860::x-portage'`, [31;01m*[0m the complete build log and the output of `emerge -pqv '=app-admin/webmin-1.860::x-portage'`. [31;01m*[0m The complete build log is located at '/var/tmp/portage/app-admin/webmin-1.860/temp/build.log'. [31;01m*[0m The ebuild environment file is located at '/var/tmp/portage/app-admin/webmin-1.860/temp/environment'. [31;01m*[0m Working directory: '/var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860' [31;01m*[0m S: '/var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860' * Messages for package app-admin/webmin-1.860: * ERROR: app-admin/webmin-1.860::x-portage failed (install phase): * !!! newins: /var/tmp/portage/app-admin/webmin-1.860/files/gentoo-setup-1.860 does not exist * * If you need support, post the output of `emerge --info '=app-admin/webmin-1.860::x-portage'`, * the complete build log and the output of `emerge -pqv '=app-admin/webmin-1.860::x-portage'`. * The complete build log is located at '/var/tmp/portage/app-admin/webmin-1.860/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/app-admin/webmin-1.860/temp/environment'. * Working directory: '/var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860' * S: '/var/tmp/portage/app-admin/webmin-1.860/work/webmin-1.860'
Ah, made a rookie mistake. 1.860 builds fine, no errors after renaming gentoo-setup-1.860, how should I proceed to get this bumped?
*** Bug 640420 has been marked as a duplicate of this bug. ***
Does any of you want to proxy maintain this? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Created attachment 509628 [details, diff] webmin-1.870.ebuild.patch OK @Pacho I am a bit confused about the bug naming conventions used here.... Last time there was a new upstream Webmin version and I named the bug "app-admin/webmin version bump", you corrected me and said the version number should be present in the name of the bug + every new version should have its own bug (if there is not already one created for this exact new version) ... Now it is vice versa... and I have to copy all the things from bug #640420 back here... Anyway.. As I stated in previous Webmin version bump bugs, since I am using Webmin I follow upstream development and the correctness of the ebuild, so I am maintaining it... So here goes the copying back (not an exact copying though) from bug #640420: There is a new upstream version of Webmin - 1.870. In this version existing CVEs have been addressed, some new features and bugs fixed also... There is no change upstream in the install procedure, so the 'gentoo-setup' script doesn't require any changes. In fact since the install procedure has been quite stable for the last 10 upstream versions, I do not see any reason the used by the ebuild 'gentoo-setup' script (in files folder) to be named after every version (like the current one in portage -> gentoo-setup-1.791). That is why in the new ebuild I reverted back the name of the used setup script.. Nothing else has changed upstream in terms of required modules, setup, install etc. The new ebuild: 1. reflects the needed change in calling phase functions - bug #596616 2. invalidates bug #623948 since the issues have been addressed upstream... 3. expects that its setup/configure script is named just 'gentoo-setup', so a renaming is desired in portage tree - files folder... As always I would advise removing all other old ebuilds from portage tree... The new bumped =app-admin/webmin-1.870 has been tested on x86 and amd64 and works ok... Thanks
(In reply to PhobosK from comment #7) > Created attachment 509628 [details, diff] [details, diff] > webmin-1.870.ebuild.patch > > > OK @Pacho > I am a bit confused about the bug naming conventions used here.... Last time > there was a new upstream Webmin version and I named the bug > "app-admin/webmin version bump", you corrected me and said the version > number should be present in the name of the bug + every new version should > have its own bug (if there is not already one created for this exact new > version) ... Now it is vice versa... and I have to copy all the things from > bug #640420 back here... > Ah, it's strange, in general we try to reuse oldest bug to keep from having dozens of bugs, each one asking for one concrete version bump... but maybe there was some exception for that concrete case... I don't remember :/ > Anyway.. As I stated in previous Webmin version bump bugs, since I am using > Webmin I follow upstream development and the correctness of the ebuild, so I > am maintaining it... Ah, great, I will CC proxy-maint people then :) Thanks
@Pacho, Why this dependency on bug 596618 ? This proposed here new ebuild for Webmin 1.870 (which is still the latest upstream Webmin version), should replace the current portage ebuild app-admin/webmin-1.791 and the latter should be removed... Besides the ebuild 1.870 had already addressed the "pkg_postinst calls pkg_config" problem ....
is the opposite then: we need this to fix the other bug , thanks for pointing out that ;)
*** Bug 659290 has been marked as a duplicate of this bug. ***
Just renaming the ebuild and patch to include the most version number causes the ebuild and patch to work just fine. Is there anyway we could get someone to perform this action? I tested and it works fine.
(In reply to Jerrod Frost from comment #12) > Just renaming the ebuild and patch to include the most version number causes > the ebuild and patch to work just fine. Is there anyway we could get someone > to perform this action? > > I tested and it works fine. Just a side note, I tested this with Webmin 1.881
(In reply to Jerrod Frost from comment #12) > Just renaming the ebuild and patch to include the most version number causes > the ebuild and patch to work just fine. Yes it would work fine, but there were some problems that needed to be addressed for the ebuild (like the "calling phase functions" etc see my previous post about 1.870 version - https://bugs.gentoo.org/600422#c7 ) that I did address in the proposed 1.870 ebuild.. > Is there anyway we could get someone > to perform this action? > > I tested and it works fine. Yeah the problem is that I thought I am the proxy maintainer of this package, but this doesn't mean I can push it in the portage tree... What's needed is someone from the Gentoo developers with portage access to take a look at the proposed changes, agree with them and push them to portage.... This someone used to be @Pacho Ramos, but my latest proposals were never uploaded to tree.... Anyway I will upload the ebuild for version 1.881 and we will wait for someone to finish this :)
Created attachment 539456 [details, diff] webmin-1.881.ebuild.patch There is a new upstream version of Webmin - 1.881. In this version existing CVEs have been addressed, some new features and bugs fixed also... There is no change upstream in the install procedure, so the 'gentoo-setup' script doesn't require any changes. In fact since the install procedure has been quite stable for the last 15 upstream versions, I do not see any reason the used by the ebuild 'gentoo-setup' script (in files folder) to be named after every version (like the current one in portage -> gentoo-setup-1.791). That is why in the new ebuild I reverted back the name of the used setup script.. Nothing else has changed upstream in terms of required modules, setup, install etc. The new ebuild: 1. reflects the needed change in calling phase functions - bug #596616 2. invalidates bug #623948 since the issues have been addressed upstream... 3. expects that its setup/configure script is named just 'gentoo-setup', so a renaming is desired in portage tree - "files" folder... As always I would advise removing all other old ebuilds from portage tree... The new bumped =app-admin/webmin-1.881 has been tested on x86 and amd64 and works ok... Thanks
PhobosK: sorry for the delay in reviewing your patch. As you can see, this package is without a maintainer. You seemed to indicate that you were interested. If that's the case, then amend your patch to add yourself as proxied maintainer. Refer to https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide for details. Note that we'll need your real name. See https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Copyright Without a proxy maintainer and with a security bug active for so long, this package will soon be purged from the tree.
(In reply to Virgil Dupras from comment #16) Hi Virgil :) No problem for me with the delay :) I guess who needed the new versions had already used the patch in their local repos ;) As for the maintaining of the package.... Yes, I am interested in maintaining the package in the way I'm doing it now - by filing as bug reports the version bumps (actually a couple of years ago this package got back to the tree after being thrown away, just because I rewrote its ebuild from scratch...). Proxy maintaining the package seemed to me OK but sadly I totally disagree with your newly accepted (2018-09-15) 'GLEP 76: Copyright Policy' in its part -> available to the public real name signing of the 'Certificate of Origin'... 'cause from my point of view, it is a way off... not to mention that it is also incompliant with the EU GDPR (General Data Protection Regulation (EU) 2016/679). Anyway this is a bug reporting system not a forum so... There are obviously two options for the existence of the webmin package: 1. Either I continue to upload the new versions ebuilds here and someone adds them to the tree when possible in time 2. Or the package is once again removed from the tree. (though that seems a bit off the open source community support of *nix but anyway bureaucracy seems to have come to Gentoo as well ;) ) So its totally your decision and I will accept it whatever it is...
Unless a gentoo developer (or even another proxied maintainer) steps up to maintain this package soon, option #2 is going to be inevitable because that "someone" from option #1 doesn't exist.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37700521dc61e1ca761f09d49def71eeafa0fb77 commit 37700521dc61e1ca761f09d49def71eeafa0fb77 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2018-10-14 12:24:17 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2018-10-14 13:02:22 +0000 app-admin/webmin: Version bump (#600422 by PhobosK) Closes: https://bugs.gentoo.org/600422 Closes: https://bugs.gentoo.org/596618 Signed-off-by: Pacho Ramos <pacho@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 app-admin/webmin/Manifest | 2 + app-admin/webmin/files/gentoo-setup | 438 +++++++++++++++++++++++++++++++++++ app-admin/webmin/webmin-1.881.ebuild | 314 +++++++++++++++++++++++++ 3 files changed, 754 insertions(+)
