Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592528 - dev-libs/cyrus-sasl fails to build with >=dev-libs/openssl-1.1.0
Summary: dev-libs/cyrus-sasl fails to build with >=dev-libs/openssl-1.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Net-Mail Packages
URL: https://github.com/cyrusimap/cyrus-sa...
Whiteboard:
Keywords:
: 655698 (view as bug list)
Depends on: 530032
Blocks: openssl-1.1
  Show dependency tree
 
Reported: 2016-08-31 07:13 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2019-02-06 05:18 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,126.40 KB, text/plain)
2016-08-31 07:13 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details
cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch (cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch,9.79 KB, patch)
2018-02-02 06:44 UTC, Quentin Minster
Details | Diff
cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch (cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch,10.54 KB, patch)
2018-02-02 07:23 UTC, Quentin Minster
Details | Diff
0001-Support-for-LDAP_OPT_TIMEOUT.patch (0001-Support-for-LDAP_OPT_TIMEOUT.patch,1.10 KB, patch)
2019-01-01 15:40 UTC, Kristian
Details | Diff
0002-Fix-compiler-warnings-on-latest-Fedora.patch (0002-Fix-compiler-warnings-on-latest-Fedora.patch,35.93 KB, patch)
2019-01-01 15:41 UTC, Kristian
Details | Diff
0003-Add-OpenSSL-1.1.0-support-in-saslauthd.patch (0003-Add-OpenSSL-1.1.0-support-in-saslauthd.patch,3.59 KB, patch)
2019-01-01 15:44 UTC, Kristian
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-31 07:13:57 UTC
Created attachment 444530 [details]
build.log

See attached build.log
Comment 1 Hanno Böck gentoo-dev 2017-07-10 12:50:06 UTC
Upstream fix (but no release yet):
https://github.com/cyrusimap/cyrus-sasl/commit/4c8e3f24bb943386a67b4de65bb849f562499dd0
Comment 2 Hanno Böck gentoo-dev 2017-12-24 16:05:34 UTC
2.1.27 has the fix:
https://www.cyrusimap.org/sasl/sasl/release-notes/2.1/index.html#new-in-2-1-27
Comment 3 Quentin Minster 2018-02-02 06:44:29 UTC
Created attachment 517534 [details, diff]
cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch

Attached is the fix that's in 2.1.27, backported to 2.1.26.
Comment 4 Quentin Minster 2018-02-02 07:23:17 UTC
Created attachment 517538 [details, diff]
cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch

Drowned in the sea of warnings that cyrus-sasl generates when it builds, I found some more references to OpenSSL functions removed in 1.1.0.

Attached is a new version of the patch which fixes those as well.
Comment 5 Craig Andrews gentoo-dev 2018-04-13 18:57:19 UTC
(In reply to Quentin Minster from comment #4)
> Created attachment 517538 [details, diff] [details, diff]
> cyrus-sasl-2.1.26-openssl-1.1.0-compatibility.patch
> 
> Drowned in the sea of warnings that cyrus-sasl generates when it builds, I
> found some more references to OpenSSL functions removed in 1.1.0.
> 
> Attached is a new version of the patch which fixes those as well.

Has this been sent upstream? If so, can someone provide a link to the commit, issues, pull request, etc?
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-06-15 07:10:04 UTC
This is already in the upstream git repo:

https://github.com/cyrusimap/cyrus-sasl/issues/467

https://github.com/cyrusimap/cyrus-sasl/commit/c0a37bfa25d7af272821191896d97ea12e80f1f7

And should be availabe since cyrus-sasl-2.1.27_rc7 (they are at 2.1.27_rc8 already).
Comment 7 Larry the Git Cow gentoo-dev 2018-10-24 12:30:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab9cb2adf29b582afb8541b4ceb5a3185c82ba30

commit ab9cb2adf29b582afb8541b4ceb5a3185c82ba30
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-10-24 12:30:31 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-10-24 12:30:31 +0000

    dev-libs/cyrus-sasl: Fixed build with openssl-1.1
    
    Bumped to EAPI-6 and did some ebuild cleanup.
    
    Closes: https://bugs.gentoo.org/592528
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 dev-libs/cyrus-sasl/cyrus-sasl-2.1.26-r11.ebuild   | 111 ++++---
 ...us-sasl-2.1.23-gss_c_nt_hostbased_service.patch |   4 +-
 .../files/cyrus-sasl-2.1.25-fix_heimdal.patch      |   8 +-
 .../files/cyrus-sasl-2.1.25-missing_header.patch   |   4 +-
 .../files/cyrus-sasl-2.1.25-service_keytabs.patch  |   8 +-
 ...us-sasl-2.1.26-fix_dovecot_authentication.patch |   8 +-
 .../files/cyrus-sasl-2.1.26-missing-size_t.patch   |   4 +-
 .../files/cyrus-sasl-2.1.26-openssl-1.1.patch      | 353 +++++++++++++++++++++
 8 files changed, 425 insertions(+), 75 deletions(-)
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-29 10:45:04 UTC
*** Bug 655698 has been marked as a duplicate of this bug. ***
Comment 9 Kristian 2019-01-01 15:40:24 UTC
Created attachment 559388 [details, diff]
0001-Support-for-LDAP_OPT_TIMEOUT.patch

After upgrading to openssl-1.1.0j rebuilding of cyrus-sasl-2.1.26-r12 with the in-tree-patch failed for me in saslauthd/lak.c with the same error: storage size of 'mdctx' isn't known
     EVP_MD_CTX mdctx;

looking at the github commits, the cyrus-sasl-2.1.26-openssl-1.1.patch seems to be incomplete, missing the same changes done to plugins/{ntml,otp}.c to saslauthd/lak.c which where in different commits upstream. Simply applying one commit from upstream did not work, so I needed to use 3 commits, which all needed a little bit of hand editing. The resulting 3 patches follow, in case someone runs into the same problem.

upstream commit id: 6b2dddb732643fa741101832c4fc0411c694b545
https://github.com/cyrusimap/cyrus-sasl/commit/6b2dddb732643fa741101832c4fc0411c694b545#diff-96de68d0f58933a261137807f790ae5a
Comment 10 Kristian 2019-01-01 15:41:33 UTC
Created attachment 559390 [details, diff]
0002-Fix-compiler-warnings-on-latest-Fedora.patch

large patch that should no change any functionality.
Comment 11 Kristian 2019-01-01 15:44:52 UTC
Created attachment 559392 [details, diff]
0003-Add-OpenSSL-1.1.0-support-in-saslauthd.patch

This patch has the changes to saslauthd/lak.c required to compile with openssl-1.1.0j

upstream commit id: 41c3e7ab8ceb3e9d69fa004f4ccf7a31030c5bdf
https://github.com/cyrusimap/cyrus-sasl/commit/41c3e7ab8ceb3e9d69fa004f4ccf7a31030c5bdf#diff-96de68d0f58933a261137807f790ae5a

I use the three patches in /etc/portage/patches/dev-libs/cyrus-sasl-2.1.26-r12/.
Comment 12 Larry the Git Cow gentoo-dev 2019-01-01 16:05:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f807113037587cd4572a79022313e7f66858e4e

commit 2f807113037587cd4572a79022313e7f66858e4e
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-11-20 10:58:18 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-01-01 16:05:46 +0000

    dev-libs/cyrus-sasl: Bump to version 2.1.27
    
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/10454
    Closes: https://bugs.gentoo.org/592528
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 dev-libs/cyrus-sasl/Manifest                       |   1 +
 dev-libs/cyrus-sasl/cyrus-sasl-2.1.27.ebuild       | 251 +++++++++++++++++++++
 .../files/cyrus-sasl-2.1.27-as_needed.patch        |  25 ++
 .../files/cyrus-sasl-2.1.27-autotools_fixes.patch  |  31 +++
 .../cyrus-sasl-2.1.27-avoid_pic_overwrite.patch    |  17 ++
 .../files/cyrus-sasl-2.1.27-doc_build_fix.patch    |  11 +
 ...us-sasl-2.1.27-gss_c_nt_hostbased_service.patch |  16 ++
 7 files changed, 352 insertions(+)