Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 530032 - dev-libs/cyrus-sasl-2.1.27 version bump
Summary: dev-libs/cyrus-sasl-2.1.27 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Net-Mail Packages
URL: https://www.cyrusimap.org/sasl/sasl/r...
Whiteboard:
Keywords:
Depends on:
Blocks: 592528
  Show dependency tree
 
Reported: 2014-11-21 11:25 UTC by Jonathan Aquilina
Modified: 2019-01-18 10:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cyrus-sasl-2.1.26-r11.ebuild_to_cyrus-sasl-2.1.27.ebuild.diff (cyrus-sasl-2.1.26-r11_to_cyrus-sasl-2.1.27.ebuild.diff,2.40 KB, text/plain)
2018-08-02 13:03 UTC, bug2017
Details
cyrus-sasl-2.1.27_rc8.ebuild (cyrus-sasl-2.1.27_rc8.ebuild,7.19 KB, text/plain)
2018-10-14 10:22 UTC, Hanno Böck
Details
0010-Update-required-libraries-when-ld-as-needed-is-used.patch (0010-Update-required-libraries-when-ld-as-needed-is-used.patch,1.49 KB, patch)
2018-10-14 10:23 UTC, Hanno Böck
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Aquilina 2014-11-21 11:25:44 UTC
the current version of Cyrus sasl is 2.4 

http://www.cyrusimap.org/mediawiki/index.php/Downloads

Could the version be bumped?
Comment 1 Oleg Gawriloff 2015-09-29 07:19:46 UTC
It seems thats there is mistake: at this link 2.4 is for cyrus-imap.
cyrus sasl is still 2.1
Comment 2 Hanno Böck gentoo-dev 2018-02-15 17:19:24 UTC
Looks like a mistake, but there is a newer version: 2.1.27. Changing bug subject.

https://www.cyrusimap.org/sasl/sasl/release-notes/2.1/index.html
Comment 3 bug2017 2018-08-02 13:03:46 UTC
Created attachment 542090 [details]
cyrus-sasl-2.1.26-r11.ebuild_to_cyrus-sasl-2.1.27.ebuild.diff

Currently cyrus-sasl-2.1.27 is available as rc8. I've tried to modify the ebuild, it installs, but is not tested. It would be nive to have the 2.1.27-rc8 because of openssl-1.1.x compability.

Issues:
It works only if it is named cyrus-sasl-2.1.27.ebuild it needs fixed in the name handling ('_rc8' in the ebuilnd name but '-rc8' in the file name, it will fail to unpack into the right directory if '_rc8' is added) 

Changes:
* remove all failing patches, probalby they were applied upstream
* commented out the 4 non failing patches
* append-ldflags $(no-as-needed) to fix an linking issue with ldbm
* commented out some dodoc, files have changed
Comment 4 Hanno Böck gentoo-dev 2018-10-14 09:40:55 UTC
I'm not sure how we should handle the huge number of existing patches.

I tried to go through them. As far as I can tell:

cyrus-sasl-2.1.26-CVE-2013-4122.patch
cyrus-sasl-2.1.26-canonuser-ldapdb-garbage-in-out-buffer.patch
cyrus-sasl-2.1.26-missing-size_t.patch

seem to be applied upstream, so that's fine.

cyrus-sasl-2.1.25-autotools_fixes.patch
references an upstream bug which can be accessed via wayback machine that says a better fix has been applied:
https://web.archive.org/web/20140725051356/https://bugzilla.cyrusimap.org/show_bug.cgi?id=3590

cyrus-sasl-2.1.25-missing_header.patch
seems simple enough and obviously a good idea, I created a PR with upstream:
https://github.com/cyrusimap/cyrus-sasl/pull/540

That leaves 10 patches that mostly don't apply any more, with unclear state. Some of them sound like serious issues (e.g. cyrus-sasl-2.1.26-fix_dovecot_authentication.patch), others are probably deprecated (e.g. there's an as-needed patch that's not applied upstream, but it compiles fine with as-needed for me). Ideally the people who added them should review if these issues still exist and if yes rework the patches to send them upstream.
Comment 5 Hanno Böck gentoo-dev 2018-10-14 09:43:58 UTC
And there are four more "de-facto patches" via sed lines in src_prepare().
Comment 6 Hanno Böck gentoo-dev 2018-10-14 10:22:43 UTC
Created attachment 551004 [details]
cyrus-sasl-2.1.27_rc8.ebuild

Here's an attempt at an ebuild for 2.1.27_rc8. Please note that this should be considered an early test, and many things should be reviewed. Yet it compiles and "seems to work".

Changes:
* remove all patches that don't apply.
* take as-needed patch from Debian (otherwise it doesn't compile, although I couldn't reproduce the compile failure outside portage).
* remove all dodoc/dohtml that no longer exist
* Remove sed lines that don't do anything on this version
* Change configure.in to configure.ac
* Remove reference to --with-javahome, this seems not to exist any more
* Adapt SRC_URI and S to work with upstream naming
Comment 7 Hanno Böck gentoo-dev 2018-10-14 10:23:06 UTC
Created attachment 551006 [details, diff]
0010-Update-required-libraries-when-ld-as-needed-is-used.patch
Comment 8 David Heidelberg (okias) 2018-10-18 21:52:41 UTC
@hanno - compiled, seems to compile (with OpenSSL 1.1.1) and run OK (Gentoo amd64).
Comment 9 tomas charvat 2018-11-29 14:36:03 UTC
cyrus-sasl 2.1.27 stable is out https://www.cyrusimap.org/sasl/sasl/release-notes/2.1/index.html#new-in-2-1-27

It also add openssl-1.1.0 support
Comment 10 David Heidelberg (okias) 2018-12-31 20:54:13 UTC
early test works for long time, can we get 2.1.27 please? (I'm running it on PROD without issues for more than month)
Comment 11 David Heidelberg (okias) 2019-01-03 13:39:08 UTC
I see .27 in  gentoo, can we close?
Comment 12 Manuel Rüger (RETIRED) gentoo-dev 2019-01-18 10:46:41 UTC
Already in ::gentoo