Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588104 - games-action/armagetronad: uses emake -j1 unnecessarily
Summary: games-action/armagetronad: uses emake -j1 unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-05 20:45 UTC by Austin English (RETIRED)
Modified: 2021-06-14 15:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Austin English (RETIRED) gentoo-dev 2016-07-05 20:45:29 UTC
games-action/armagetronad-0.2.8.3.3 does:
src_install() {
    emake -j1 DESTDIR="${D}" install
    ...
}

I tried removing that, and replacing with -j99 / -j, which builds fine for me. To see if it was a race, I ran it in a while loop for a few hours, but all compiles/installs succeeded.

There's no comment, and I couldn't find a bug referencing why it was added (nor anything useful in git log).

I'm working on removing games.eclass, but this is outside of that scope, so filing a bug and putting a FIXME instead.
Comment 1 Larry the Git Cow gentoo-dev 2017-11-19 13:34:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c23c7ac9592dc6e225c669dcaa9cb0d3eaafbc78

commit c23c7ac9592dc6e225c669dcaa9cb0d3eaafbc78
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2017-11-19 13:31:58 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-11-19 13:34:36 +0000

    games-action/armagetronad: Minor touchups
    
    Closes: https://bugs.gentoo.org/588104
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 .../armagetronad/armagetronad-0.2.8.3.3-r1.ebuild       | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2021-06-14 15:49:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad66a3fe06a3fc02c8f76bcdd63f38400f602b0f

commit ad66a3fe06a3fc02c8f76bcdd63f38400f602b0f
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-14 15:28:49 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-14 15:47:49 +0000

    games-action/armagetronad: restore -j1, fix dedicated, tidy
    
    j1 was removed for bug #588104, but turns out still needed for
    install until proper fix (bug #698020).
    
    No longer attempt to remove desktop/ when USE=dedicated (bug #716442).
    
    Bug: https://bugs.gentoo.org/588104
    Closes: https://bugs.gentoo.org/698020
    Closes: https://bugs.gentoo.org/716442
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../armagetronad/armagetronad-0.2.9.1.0.ebuild     | 47 +++++++++++-----------
 1 file changed, 24 insertions(+), 23 deletions(-)