The ebuild needs a second review, and fixing. At a first glance, I see the following problems: 1. empty RDEPEND (?!), 2. use of live eclass for keyworded release (easy to fix), 3. use of deprecated qt4-r2 eclass, 4. awful mixing of qt4-r2 & cmake, including phases that do not do anything (qt4-r2_src_unpack), 5. a lot of 'if' branches copying the same code, 6. reinvention of deprecated & banned games.eclass in the inline code, 7. in one of the conditionals, the game is installed into /usr/games (without /bin), 8. newins -> newicon? I also have a suspicion that it bundles ffmpeg. Please get those issues fixed or lastrite the package.
commit a401627148007f874469589a94805007c3614af6 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: Tue Jun 28 20:22:00 2016 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: Tue Jun 28 20:25:08 2016 package.mask: Mask games-emulation/ppsspp for QA violations, #587342
I don't touch anything Qt-related so I can't speak to that, but based on my local ppsspp ebuild (dating back to before it was in Portage) and assuming USE=sdl: - RDEPEND="media-libs/libsdl2 media-video/ffmpeg sys-libs/zlib" - DEPEND="${RDEPEND} dev-util/cmake" - Bug 585822 comment 2 gives a solution for the git checkout stuff (note that the only required submodules are lang, ext/armips, and ext/glslang). - CMakeLists.txt (at least at git HEAD, haven't checked the 1.2.2 tag) will automatically use system FFmpeg if available, but you need to hack it to link shared instead of static libraries: sed -i -e 's/\(lib[a-z]*\)\.a/\1.so/g' CMakeLists.txt || die
s/Bug 585822 comment 2/Bug 585722 comment 2/
Since this thread seems a little more active than the other, I'll list other problems I've encountered (and fixed in my local repo) about ppsspp: - Doesn't check if qt5 is compiled with the gles2 USE flag, which breaks the package. - Bundle ffmpeg when you just need CONFIG+='system_ffmpeg' for the eqmakes. I hit some compilation errors with -DUSE_SYSTEM_FFMPEG='TRUE' for the cmake/sdl one. - I don't if CONFIG+='release' is the default or not. That's basically it.
pr to fix this https://github.com/gentoo/gentoo/pull/4342
commit 07dcd0e1a674de8b3c71b2e5b34335b3f555eb9f (HEAD) Author: soredake <fdsfgs@krutt.org> AuthorDate: Tue Apr 4 16:17:54 2017 +0300 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: Tue Apr 4 23:13:58 2017 +0200 games-emulation/ppsspp: version bump to 1.4. Gentoo-Bug: https://bugs.gentoo.org/583818 Gentoo-Bug: https://bugs.gentoo.org/612826 Gentoo-Bug: https://bugs.gentoo.org/587342 Gentoo-Bug: https://bugs.gentoo.org/574118 Gentoo-Bug: https://bugs.gentoo.org/585722 Closes: https://github.com/gentoo/gentoo/pull/4342 games-emulation/ppsspp/Manifest | 8 ++ games-emulation/ppsspp/files/ppsspp-1.4-O2.patch | 32 ++++++++ .../ppsspp/files/ppsspp-1.4-assets-lookup.patch | 13 ++++ games-emulation/ppsspp/metadata.xml | 8 +- games-emulation/ppsspp/ppsspp-1.4.ebuild | 87 ++++++++++++++++++++++ 5 files changed, 145 insertions(+), 3 deletions(-) create mode 100644 games-emulation/ppsspp/Manifest create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-O2.patch create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-assets-lookup.patch create mode 100644 games-emulation/ppsspp/ppsspp-1.4.ebuild
Hi, thanks for the good work on the new ebuild, the Icon in the menu-entry is now missing, that needs to be corrected though. But i think the package.mask can now be removed?!
Thanks for the heads up! The mask has been removed.
