https://github.com/hrydgard/ppsspp/issues/5772 It seems that ffmpeg should be able to deal with ATRAC3(+) files now, so downloading and rebuilding ffmpeg (pretty annoying) just for this package shouldn't be mandatory. Our ffmpeg package already supports it. Maybe introduce a "system-ffmpeg" USE flag? Or just use the system one automatically. Reproducible: Always
I don't know if I should make another issue, but a "test" USE flag for the download of the pspautotests submodule would fit like a glove. I'm pretty sure we don't need the minidx9 one too.
Arch actually has a patch to do it easily. https://git.archlinux.org/svntogit/community.git/tree/trunk/ppsspp-ffmpeg.patch?h=packages/ppsspp
I have a patch to do it (using a messy git-2 then git submodule update directly) but I would like to test it before (https://bugs.gentoo.or/show_bug.cgi?id=583894)
I'm a bit confused at that issue; wasn't it fixed upstream even before this bug was opened?!? o.O The corresponding link is even linked above.. > https://github.com/hrydgard/ppsspp/issues/5772
The bug report is about the ebuild.
Ahh i see, it's still using the included ffmpeg by default, ok so the problem still exists. I tried to include "local mycmakeargs=( $(cmake-utils_use_use system-ffmpeg SYSTEM_FFMPEG) )" But libavcodec and libavformat show a lot of deprecated errors then and when emulating a game it crashes with "15:08:952 user_main E[ME]: HW/MediaEngine.cpp:82 FF: Assertion 0 failed at src/libavcodec/utils.c:601" So i think this is still an upstream problem.
In my local ebuild (that worked for 1.3.0) I just had: eqmake5 "${S}"/Qt/PPSSPPQt.pro CONFIG+='release' CONFIG+='system_ffmpeg' for Qt and cmake-utils_src_configure -DCMAKE_BUILD_TYPE='Release' -DUSE_SYSTEM_FFMPEG='TRUE' for SDL
I just tested with -DCMAKE_BUILD_TYPE='Release' -DUSE_SYSTEM_FFMPEG='TRUE' for SDL, but it still crashes at least with ppsspp-1.3. I dont think such ebuild option makes much sense until upstream got rid of all the deprecated warnings for system-ffmpeg.
(In reply to Hadrien Lacour from comment #7) Did you see runtime-improvements when using system-ffmpeg, like better sound? Or is it just prestige to have a system-ffmpeg instead of the stable included one?
Well, it's obviously because downloading and building ffmpeg for nothing is pretty annoying. And yeah, it's more correct this way.
I found there is an upstream bug, for the issue of >=ppsspp-1.3 not working with >=ffmpeg-3.1: https://github.com/hrydgard/ppsspp/issues/9026
pr to fix this https://github.com/gentoo/gentoo/pull/4342
commit 07dcd0e1a674de8b3c71b2e5b34335b3f555eb9f (HEAD) Author: soredake <fdsfgs@krutt.org> AuthorDate: Tue Apr 4 16:17:54 2017 +0300 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: Tue Apr 4 23:13:58 2017 +0200 games-emulation/ppsspp: version bump to 1.4. Gentoo-Bug: https://bugs.gentoo.org/583818 Gentoo-Bug: https://bugs.gentoo.org/612826 Gentoo-Bug: https://bugs.gentoo.org/587342 Gentoo-Bug: https://bugs.gentoo.org/574118 Gentoo-Bug: https://bugs.gentoo.org/585722 Closes: https://github.com/gentoo/gentoo/pull/4342 games-emulation/ppsspp/Manifest | 8 ++ games-emulation/ppsspp/files/ppsspp-1.4-O2.patch | 32 ++++++++ .../ppsspp/files/ppsspp-1.4-assets-lookup.patch | 13 ++++ games-emulation/ppsspp/metadata.xml | 8 +- games-emulation/ppsspp/ppsspp-1.4.ebuild | 87 ++++++++++++++++++++++ 5 files changed, 145 insertions(+), 3 deletions(-) create mode 100644 games-emulation/ppsspp/Manifest create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-O2.patch create mode 100644 games-emulation/ppsspp/files/ppsspp-1.4-assets-lookup.patch create mode 100644 games-emulation/ppsspp/ppsspp-1.4.ebuild
