I have been wanting to return to using cinnamon for a while now, but I have active disinterest in running networkmanager on my system. Please make networkmanager and by extension, modemmanager optional again. This was previously discussed on #529868, but that was not the main focus of that bug report. As noted in #529868, the cinnamon devs did express interest in upstreaming this change so that we do not need to maintain a patchset. This appears to be the only package currently preventing cinnamon from being emerged without networkmanager. Reproducible: Always
Created attachment 412100 [details] ebuild with optional nm/mm dependencies
Created attachment 412102 [details, diff] patch for making networkmanager/modemmanager optional
I've attached ebuild and appropriate patch to make networkmanager/modemmanager optional. In case if you will disable both flags: networkmanager and modemmanager - "network" module will not be built. In case if you enable networkmanager, but disable modemmanager - you will be able to use network menu, but modemmanager functions will be not available. Had to patch configure.ac, Makefile.am and cc-network-panel.c source file.
Please, forward this patch to upstream, so we will get possibility to disable MM/NM oob.
(In reply to Igor Filakhtov from comment #2) > Created attachment 412102 [details, diff] [details, diff] > patch for making networkmanager/modemmanager optional Unfortunately, we cannot accept this patch in its current form. In gentoo we must be able to disable networkmanager and modemmanager support even when building on a system where networkmanager and/or modemmanager are installed. See https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies for the reasoning.
Alexandre, Thanks. Will do ASAP.
Created attachment 412118 [details] cinnamon-control-center ebuild with optional modemmanager/networkmanager support Disabled automatic dependencies in ebuild
Created attachment 412120 [details, diff] patch for making networkmanager/modemmanager optional (no auto deps)
Attached new patch/ebuild. Automatic dependencies are removed, --disable-networkmanager and --disable-modemmanager flags were introduced instead. combination --enable-modemmanger --disable-networkmanager gives an error, because mm without nm makes no sense. Please, review. Thanks in advance!
up
ebuilds for Cinnamon without NetworkManagerk
Created attachment 417510 [details] cinnamon-2.8.5.ebuild
Created attachment 417512 [details] cinnamon-control-center-2.8.1.ebuild
Created attachment 417514 [details] cinnamon-control-center-2.8.1.ebuild
*** Bug 564778 has been marked as a duplicate of this bug. ***
Created attachment 442502 [details] cinnamon-3.0.7.ebuild cinnamon-3.0.7.ebuild
Created attachment 442504 [details] cinnamon-control-center-3.0.1.ebuild cinnamon-control-center-3.0.1.ebuild
Please ? At least remove USE modemmanager requirement. Why do one need to force that on a DE?
Hi @Joakim, I have PR open for cinnamon-control-center in upstream repo: https://github.com/linuxmint/cinnamon-control-center/pull/136. Still no luck on merging it though.
(In reply to Garry Filakhtov from comment #19) > Hi @Joakim, > > I have PR open for cinnamon-control-center in upstream repo: > https://github.com/linuxmint/cinnamon-control-center/pull/136. Still no luck > on merging it though. Hi Garry Thanks for letting me know. I commented on upstream lets hope it is resolved soon.
This appears to be merged in upstream. I use NM, but don't use MM, so this patch would be nice to have.
Created attachment 529164 [details] Optional networkmanager/modemmanager networkmanager and modemmanager have been optional since 3.4.0 Though, at some point, a set of #ifdefs went AWOL, so there is also an included patch from 3.8.0 upstream.
Created attachment 529166 [details, diff] Fix non modemmanager build Patch from upstream: https://github.com/linuxmint/cinnamon-control-center/commit/6a916057b06fda8d3ca90520e6936f3261a915ed
Created attachment 541912 [details] networkmanager/modemmanager optional ebuild Running 3.8.1 with this ebuild compiles fine and seems to run fine, no other patches or changes seem necessary.
Created attachment 558112 [details] Update for cinnamon 4.0.0 Update for cinnamon 4.0.0. Patch no longer needed as this is fully supported upstream. Can we also get the component changed back to Current? This is an ongoing ask applicable to the current cinnamon versions.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8da71837558fd68d32a72b8b7b5fb88071e78ecc commit 8da71837558fd68d32a72b8b7b5fb88071e78ecc Author: Matthew Turnbull <sparky@bluefang-logic.com> AuthorDate: 2020-05-13 05:52:22 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2020-05-29 00:10:46 +0000 gnome-extra/cinnamon: 4.4.8 version bump Update cinnamon to 4.4.8. Re-work python support as python-single-r1 with python3_{6,7} compat. Clean-up dependencies and make networkmanager optional. Closes: https://bugs.gentoo.org/553946 Closes: https://bugs.gentoo.org/704532 Closes: https://bugs.gentoo.org/662546 Closes: https://bugs.gentoo.org/709016 Bug: https://bugs.gentoo.org/718316 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Matthew S. Turnbull <sparky@bluefang-logic.com> Signed-off-by: Matt Turner <mattst88@gentoo.org> gnome-extra/cinnamon/Manifest | 1 + gnome-extra/cinnamon/cinnamon-4.4.8.ebuild | 176 +++++++++++++++++++++++++++++ gnome-extra/cinnamon/metadata.xml | 8 ++ 3 files changed, 185 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=db2ce06e3503ba5c9c7c793d0b42405b406355ee commit db2ce06e3503ba5c9c7c793d0b42405b406355ee Author: Matthew Turnbull <sparky@bluefang-logic.com> AuthorDate: 2020-05-13 03:19:55 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2020-05-29 00:10:46 +0000 gnome-extra/cinnamon-control-center: 4.4.0 version bump Update cinnamon-control-center to 4.4.0. CUPS dependencies belong in cinnamon-settings-daemon. Make networkmanager and modemmanager optional. Clean-up dead configure options. Bug: https://bugs.gentoo.org/553946 Bug: https://bugs.gentoo.org/704532 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Matthew S. Turnbull <sparky@bluefang-logic.com> Signed-off-by: Matt Turner <mattst88@gentoo.org> gnome-extra/cinnamon-control-center/Manifest | 1 + .../cinnamon-control-center-4.4.0.ebuild | 87 ++++++++++++++++++++++ gnome-extra/cinnamon-control-center/metadata.xml | 12 +++ 3 files changed, 100 insertions(+)
