Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 545344 - sys-apps/ed-1.11: Please consider using .tar.gz distfile
Summary: sys-apps/ed-1.11: Please consider using .tar.gz distfile
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 15:50 UTC by Ulrich Müller
Modified: 2022-12-14 11:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for ed-1.11.ebuild (ed-1.11.ebuild.diff,1021 bytes, patch)
2015-04-02 15:50 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-04-02 15:50:44 UTC
Created attachment 400408 [details, diff]
Patch for ed-1.11.ebuild

Upstream recommends using the .tar.gz distfile at fossies.org:
https://lists.gnu.org/archive/html/bug-ed/2015-01/msg00004.html

This would get rid of the dependency on the lzip unpacker which is used for little else than ed.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2015-04-02 17:15:34 UTC
IIRC this is the same guy who also develops lzip. The last time I got in contact with him requesting one of his package also being released as gzip/xz tarball I got disappointing feedback [1].

So I 

1) do _not_ want to rely on his daily mood for creating a differently compressed tarball of his sources.
2) do not want to ask him for such a tarball each time he releases a new version of his softwares.
3) do not want to always re-compress the tarball


Feel free to find someone fulfilling your request but I won't do it. To be honest I don't see the reason for such a workload when you can just install lzip and be done with it.


[1] http://lists.gnu.org/archive/html/bug-ddrescue/2013-10/msg00019.html
Comment 2 SpanKY gentoo-dev 2015-04-02 17:18:44 UTC
should be all set now in the tree; thanks for the report!

Commit message: Switch to gzip as lzip is uncommon, and not that much smaller for this package
http://sources.gentoo.org/sys-apps/ed/ed-1.11.ebuild?r1=1.1&r2=1.2
Comment 3 Ulrich Müller gentoo-dev 2015-04-02 17:54:57 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> IIRC this is the same guy who also develops lzip.

Yes he is, and AFAIK his packages are the only ones distributed in that uncommon format. (See bug 249059 comment #6 and following for his advocacy to add package manager support for lzip unpacking.)
Comment 4 SpanKY gentoo-dev 2015-04-03 00:49:10 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)

if there's a .gz available, lets use it, but otherwise i don't think we'll want to make one ourselves.  i've also interacted with him in the past and it wasn't exactly fruitful.
Comment 5 Larry the Git Cow gentoo-dev 2022-02-07 01:22:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e846fa4b82dbcba6025faffcde18ee6bdea4b3c

commit 3e846fa4b82dbcba6025faffcde18ee6bdea4b3c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-07 01:17:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-07 01:21:43 +0000

    sys-apps/ed: add 1.18
    
    Go back to using lzip. Upstream only provide lzip archives (and
    indeed the maintainer of ed is the maintainer of lzip) and repacking
    to avoid a BDEPEND for a relatively unpopular package is overkill.
    
    Bug: https://bugs.gentoo.org/545344
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/ed/Manifest       |  1 +
 sys-apps/ed/ed-1.18.ebuild | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
Comment 6 Ulrich Müller gentoo-dev 2022-02-07 02:10:58 UTC
Reopening. Rationale still applies.
Comment 7 Mike Gilbert gentoo-dev 2022-02-07 02:41:09 UTC
Closing again given the explanation in comment 5.
Comment 8 Larry the Git Cow gentoo-dev 2022-12-14 10:18:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7713a9f0fc204a09d6b2a57a46e520f07bed72be

commit 7713a9f0fc204a09d6b2a57a46e520f07bed72be
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-13 21:02:58 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-12-14 10:16:17 +0000

    unpacker.eclass: support >=app-arch/xz-utils-5.4.0 for lzip decompression
    
    >=app-arch/xz-utils-5.4.0 supports lzip decompression (not compression).
    
    Add support for unpacker.eclass to handle it for .lz files.
    
    Note that xz-utils is part of @system (and PMS requires that .xz is unpackable),
    while most users do not have lzip and friends installed.
    
    (Note that xz does not (currently, but does not plan on either) implement
    parallel decompression for .lz, but most .lz distfiles are small, so this
    isn't an issue.)
    
    Historically, we've often repacked .lz distfiles for important packages
    to avoid users needing to install app-arch/lzip for a single distfile,
    so this avoids the need for that (although I've not done it out of
    principle for things like sys-apps/ed).
    
    Bug: https://bugs.gentoo.org/249059
    Bug: https://bugs.gentoo.org/485462
    Bug: https://bugs.gentoo.org/501912
    Bug: https://bugs.gentoo.org/502990
    Bug: https://bugs.gentoo.org/545344
    Signed-off-by: Sam James <sam@gentoo.org>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 eclass/unpacker.eclass | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)