Created attachment 370890 [details, diff] patch against gx86 version Add support for app-arch/lzip (*.lz files)
Looks good to me. +1 for inclusion
@vapier: can we include this?
I've just added app-arch/pdlzip that's public-domain & plain C variant of lzip (from the same author). We may consider this since it's 50k while the normal lzip is 100k.
Created attachment 371226 [details, diff] patch against gx86 version (In reply to Michał Górny from comment #3) > I've just added app-arch/pdlzip that's public-domain & plain C variant of > lzip (from the same author). We may consider this since it's 50k while the > normal lzip is 100k. Good point.
Immediate users: $ fgrep -Rl '.tar.lz"' . ./app-text/ocrad/ocrad-0.18.ebuild ./app-text/ocrad/ocrad-0.21.ebuild ./sys-apps/ed/ed-1.10.ebuild ./sys-fs/ddrescue/ddrescue-1.17.ebuild ./sys-fs/ddrescue/ddrescue-1.17-r1.ebuild
Comment on attachment 371226 [details, diff] patch against gx86 version LGTM should we also support *.tlz ? or is that not a thing ?
(In reply to SpanKY from comment #6) > Comment on attachment 371226 [details, diff] [details, diff] > patch against gx86 version > LGTM Committed. + 27 Feb 2014; Christoph Junghans <ottxor@gentoo.org> unpacker.eclass: + added lzip support (bug #501912) + > > should we also support *.tlz ? or is that not a thing ? With 3 packages using lzip, this is not a thing yet ;-) @vapier: Should I move sys-apps/ed to use unpacker.eclass? @polynomial-c: feel free to use unpacker.eclass in sys-fs/ddrescue. @aballier: feel free to use unpacker.eclass in app-text/ocrad.
(In reply to Christoph Junghans from comment #7) > > @vapier: Should I move sys-apps/ed to use unpacker.eclass? > > @polynomial-c: feel free to use unpacker.eclass in sys-fs/ddrescue. sys-apps/ed and sys-fs/ddrescue done.
Well, on my systems nothing depends on lzip packages. On updating sys-apps/ed-1.10 emerge fails because comp evaluates to ' -dc'
Confirmed: 2014-02-27 21:39:30 (988 KB/s) - ‘/usr/portage/distfiles/ed-1.10.tar.lz’ saved [63717/63717] * ed-1.10.tar.lz SHA256 SHA512 WHIRLPOOL size ;-) ... [ ok ] >>> Unpacking source... >>> Unpacking ed-1.10.tar.lz to /var/tmp/portage/sys-apps/ed-1.10/work /var/tmp/portage/sys-apps/ed-1.10/temp/environment: line 258: -dc: command not found tar: This does not look like a tar archive tar: Exiting with failure status due to previous errors * ERROR: sys-apps/ed-1.10::gentoo failed (unpack phase): * unpacking /var/tmp/portage/sys-apps/ed-1.10/distdir/ed-1.10.tar.lz failed (comp= -dc arch=tar --no-same-owner -xof) * Neither app-arch/pdlzip nor app-arch/lzip are installed on my system.
(In reply to Thomas D. from comment #10) > Confirmed: Then you haven't done `emerge --sync` or the gentoo mirror you are using is out of date. > Neither app-arch/pdlzip nor app-arch/lzip are installed on my system. $ sudo emerge -1vp sys-apps/ed These are the packages that would be merged, in reverse order: Calculating dependencies... done! [ebuild R ] sys-apps/ed-1.10 0 kB [ebuild N ] app-arch/pdlzip-1.5 0 kB Total: 2 packages (1 new, 1 reinstall), Size of downloads: 0 kB http://sources.gentoo.org/viewvc.cgi/gentoo-x86/sys-apps/ed/ed-1.10.ebuild?r1=1.3&r2=1.4 was added from bug 502990 like an hour ago.
ocrad converted to unpacker.eclass too, so if I read all the comments right, there is nothing left to do here, closing then
Well, I synch'ed the tree before I posted and I also grep'ed the eclass for "lzip"... but everything looked like it should work.. However, now I sync'ed again: Timestamp of tree: Thu, 27 Feb 2014 20:45:01 +0000 ...3 minutes after I posted here, the mirror updated (well, this time I got another host from the pool) :) It is now working for me, too.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7713a9f0fc204a09d6b2a57a46e520f07bed72be commit 7713a9f0fc204a09d6b2a57a46e520f07bed72be Author: Sam James <sam@gentoo.org> AuthorDate: 2022-12-13 21:02:58 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2022-12-14 10:16:17 +0000 unpacker.eclass: support >=app-arch/xz-utils-5.4.0 for lzip decompression >=app-arch/xz-utils-5.4.0 supports lzip decompression (not compression). Add support for unpacker.eclass to handle it for .lz files. Note that xz-utils is part of @system (and PMS requires that .xz is unpackable), while most users do not have lzip and friends installed. (Note that xz does not (currently, but does not plan on either) implement parallel decompression for .lz, but most .lz distfiles are small, so this isn't an issue.) Historically, we've often repacked .lz distfiles for important packages to avoid users needing to install app-arch/lzip for a single distfile, so this avoids the need for that (although I've not done it out of principle for things like sys-apps/ed). Bug: https://bugs.gentoo.org/249059 Bug: https://bugs.gentoo.org/485462 Bug: https://bugs.gentoo.org/501912 Bug: https://bugs.gentoo.org/502990 Bug: https://bugs.gentoo.org/545344 Signed-off-by: Sam James <sam@gentoo.org> Signed-off-by: Michał Górny <mgorny@gentoo.org> eclass/unpacker.eclass | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-)
