Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506500 - x11-terms/rxvt-unicode might use the wrong xsubpp
Summary: x11-terms/rxvt-unicode might use the wrong xsubpp
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: PATCH
: 774132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-01 23:20 UTC by Reza Jelveh
Modified: 2021-03-10 07:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use prefix path with xsubpp (fix-invalid-xsubpp.patch,1012 bytes, patch)
2014-04-01 23:21 UTC, Reza Jelveh
Details | Diff
use the right xsubpp path (rxvt-unicode-9.15-xsubpp.patch,642 bytes, patch)
2014-04-06 20:36 UTC, Reza Jelveh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Reza Jelveh 2014-04-01 23:20:33 UTC
if your prefix xsubpp and /usr/bin/xsubpp differ in perl versions urxvt will fail to merge this patch fixes it

Reproducible: Always
Comment 1 Reza Jelveh 2014-04-01 23:21:17 UTC
Created attachment 374058 [details, diff]
use prefix path with xsubpp
Comment 2 Fabian Groffen gentoo-dev 2014-04-06 12:25:24 UTC
uhm, isn't this patch just not using the prefix perl? that looks wrong to me...
Comment 3 Reza Jelveh 2014-04-06 20:36:27 UTC
Created attachment 374422 [details, diff]
use the right xsubpp path

you're right i submitted the wrong patch. also it seems like maybe the path should be something entirely different
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-04-14 18:14:41 UTC
Comment on attachment 374422 [details, diff]
use the right xsubpp path

>--- a/src/Makefile.in
>+++ b/src/Makefile.in
>@@ -112,7 +112,7 @@
> 	$(PERL) -MExtUtils::Embed -e xsinit -- -std urxvt
> 
> rxvtperl.C: rxvtperl.xs iom_perl.h iom_perl.xs typemap typemap.iom
>-	PERL="$(PERL)" $(PERL) @PERLPRIVLIBEXP@/ExtUtils/xsubpp -C++ -typemap @PERLPRIVLIBEXP@/ExtUtils/typemap -typemap typemap.iom -typemap typemap -prototypes $(srcdir)/rxvtperl.xs >$@
>+	PERL="$(PERL)" $(PERL) ${EPREFIX}/usr/bin/xsubpp -C++ -typemap @PERLPRIVLIBEXP@/ExtUtils/typemap -typemap typemap.iom -typemap typemap -prototypes $(srcdir)/rxvtperl.xs >$@

The build system uses no such variable as EPREFIX, so it is not a good idea to introduce it here. An appropriate patch would expose PERLPRIVLIBEXP in configure.ac instead so that we can override it as needed in the ebuild.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2014-04-14 18:17:58 UTC
Also, we have files/rxvt-unicode-9.15-xsubpp.patch in place already. Any proper tinkering should probably replace that patch.
Comment 6 Fabian Groffen gentoo-dev 2021-01-06 20:13:34 UTC
I think we'd have to look at current versions of this package to see what the state is
Comment 7 Marek Szuba archtester gentoo-dev 2021-03-08 11:09:47 UTC
Still broken.
Comment 8 Marek Szuba archtester gentoo-dev 2021-03-08 11:10:06 UTC
*** Bug 774132 has been marked as a duplicate of this bug. ***
Comment 9 Jake Lilly 2021-03-08 17:46:01 UTC
Started digging for some further information surrounding this. This bug appears to be the background info for the xsubpp patch: https://bugs.gentoo.org/424697
Comment 10 Jake Lilly 2021-03-10 03:58:39 UTC
After reading more, it seems the xsubpp patch may have had more to do with the version of perl in the tree at the time, and the ParseXS version being supplied in the tree under the perl-core category. Now, it appears we just have a virtual for perl-ExtUtils-ParseXS, which in my case was satisfied by dev-lang/perl-5.32.1. Please, take my observation with a grain of salt - I'm no expert :)

My workaround was to simply exclude the xsubpp patch and emerge it.
Comment 11 Larry the Git Cow gentoo-dev 2021-03-10 07:24:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2bfec260e57586d91de7da25029f893eef1094ea

commit 2bfec260e57586d91de7da25029f893eef1094ea
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2021-03-10 07:24:01 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-03-10 07:24:14 +0000

    x11-terms/rxvt-unicode: fix build on Prefix
    
    Closes: https://bugs.gentoo.org/506500
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 x11-terms/rxvt-unicode/rxvt-unicode-9.22-r7.ebuild | 5 ++++-
 x11-terms/rxvt-unicode/rxvt-unicode-9999.ebuild    | 7 +++++--
 2 files changed, 9 insertions(+), 3 deletions(-)